Menu

#13 GUI problem with T1 and T2 files

fixed
4.1.1
GUI
Model-free analysis
2019-04-18
2019-03-13
No

Hello, when I try to go through the procedure of using the attached T1 and T2 DC files, the software (4.1.1) hangs up indefinetly. In particular, a clock icon appears, in place of the arrow, upon me clicking on the “next” button, and nothing else happens for several minutes, or until my patience is finished and I have to shut down the software. I do not believe that it should take several minutes to load a file.
Stefano

2 Attachments

Related

Bugs: #13

Discussion

  • Edward d'Auvergne

    Could you please outline the steps to reproduce this? Do you initialise a model-free analysis? Do you load sequence information from another file?

     
  • Edward d'Auvergne

    Ok, I can reproduce this now. I created a quick sequence file from the attached data files. Running relax in debug mode shows that the following error occurs:

    relax> bruker.read(ri_id='R1', file='/data/relax/debugging/bug_13/APO_T1_500.txt', dir=None)
    debug> GUI interpreter:  Applying the bruker.read user function for synchronous execution.
    Opening the file '/data/relax/debugging/bug_13/APO_T1_500.txt' for reading.
    Traceback (most recent call last):
      File "/data/relax/relax/gui/wizards/wiz_objects.py", line 632, in _go_next
        self._pages[self._current_page]._apply(event)
      File "/data/relax/relax/gui/wizards/wiz_objects.py", line 166, in _apply
        self.exec_status = self.on_execute()
      File "/data/relax/relax/gui/uf_objects.py", line 917, in on_execute
        return_status = self.execute(self.name, **kargs)
      File "/data/relax/relax/gui/uf_objects.py", line 839, in execute
        return_status = interpreter.apply(uf, *args, **kwds)
      File "/data/relax/relax/gui/interpreter.py", line 109, in apply
        fn(*args, **kwds)
      File "/data/relax/relax/pipe_control/bruker.py", line 54, in read
        values, errors, res_nums, int_type, frq, ri_type, spin_name, isotope, version = parse_file(file=file, dir=dir)
      File "/data/relax/relax/lib/software/bruker_dc.py", line 165, in parse_file
        rx_err = float(row[-1])
    ValueError: could not convert string to float: Done
    debug> Observer: 'gui_uf' unregistering 'bruker.read'.
    debug> The key 'bruker.read' does not exist.
    

    The GUI then is stuck with the spinning mouse cursor. Testing this in relax shows that the broken GUI issue was introduced between relax 4.0.3 and 4.1.0. The Bruker DC reading error was present in 4.0.3.

    This is therefore two seperate bugs:

    • The frozen GUI when an error is raised that is not a RelaxError.
    • Support for newer Bruker DC files is lacking.

    For this bug report, I'll concentrate on the GUI issue. A separate bug report can be created for the new Bruker DC format.

     
    • Stefano Ciurli

      Stefano Ciurli - 2019-03-13

      Good, I look forward to the solution of both problems.
      Kind regards,
      Stefano

      On 13 Mar 2019, at 14:22, Edward d'Auvergne edauvergne@users.sourceforge.netamp#101;amp#100;amp#97;amp#117;amp#118;amp#101;amp#114;amp#103;amp#110;amp#101;amp#64;amp#117;amp#115;amp#101;amp#114;amp#115;amp#46;amp#115;amp#111;amp#117;amp#114;amp#99;amp#101;amp#102;amp#111;amp#114;amp#103;amp#101;amp#46;amp#110;amp#101;amp#116; wrote:

      Ok, I can reproduce this now. I created a quick sequence file from the attached data files. Running relax in debug mode shows that the following error occurs:

      relax> bruker.read(ri_id='R1', file='/data/relax/debugging/bug_13/APO_T1_500.txt', dir=None)
      debug> GUI interpreter: Applying the bruker.read user function for synchronous execution.
      Opening the file '/data/relax/debugging/bug_13/APO_T1_500.txt' for reading.
      Traceback (most recent call last):
      File "/data/relax/relax/gui/wizards/wiz_objects.py", line 632, in _go_next
      self._pages[self._current_page]._apply(event)
      File "/data/relax/relax/gui/wizards/wiz_objects.py", line 166, in _apply
      self.exec_status = self.on_execute()
      File "/data/relax/relax/gui/uf_objects.py", line 917, in on_execute
      return_status = self.execute(self.name, kargs)
      File "/data/relax/relax/gui/uf_objects.py", line 839, in execute
      return_status = interpreter.apply(uf, *args,
      kwds)
      File "/data/relax/relax/gui/interpreter.py", line 109, in apply
      fn(args, *kwds)
      File "/data/relax/relax/pipe_control/bruker.py", line 54, in read
      values, errors, res_nums, int_type, frq, ri_type, spin_name, isotope, version = parse_file(file=file, dir=dir)
      File "/data/relax/relax/lib/software/bruker_dc.py", line 165, in parse_file
      rx_err = float(row[-1])
      ValueError: could not convert string to float: Done
      debug> Observer: 'gui_uf' unregistering 'bruker.read'.
      debug> The key 'bruker.read' does not exist.

      The GUI then is stuck with the spinning mouse cursor. Testing this in relax shows that the broken GUI issue was introduced between relax 4.0.3 and 4.1.0. The Bruker DC reading error was present in 4.0.3.

      This is therefore two seperate bugs:

      • The frozen GUI when an error is raised that is not a RelaxError.
      • Support for newer Bruker DC files is lacking.

      For this bug report, I'll concentrate on the GUI issue. A separate bug report can be created for the new Bruker DC format.


      [tickets:#13]https://sourceforge.net/p/nmr-relax/tickets/13/ GUI problem with T1 and T2 files

      Status: open
      Created: Wed Mar 13, 2019 12:15 PM UTC by Stefano Ciurli
      Last Updated: Wed Mar 13, 2019 01:00 PM UTC
      Owner: Edward d'Auvergne
      Attachments:

      Hello, when I try to go through the procedure of using the attached T1 and T2 DC files, the software (4.1.1) hangs up indefinetly. In particular, a clock icon appears, in place of the arrow, upon me clicking on the “next” button, and nothing else happens for several minutes, or until my patience is finished and I have to shut down the software. I do not believe that it should take several minutes to load a file.
      Stefano


      Sent from sourceforge.nethttp://sourceforge.net because you indicated interest in https://sourceforge.net/p/nmr-relax/tickets/13/

      To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

       

      Related

      Bugs: #13

  • Edward d'Auvergne

    Note that the bug of the frozen GUI when an error is raised that is not a RelaxError is now fixed in relax 4.1.1.

     
  • Stefano Ciurli

    Stefano Ciurli - 2019-04-18

    Edward, I downloaded the 4.1.1 version (no change in name from the previous one, correct?) but the problem with frozen GUI is still there. Also, maybe this is related to the error concerning the format of the Bruker DC file, and that is not solved, yet? Please explain. Best, Stefano

     
  • Edward d'Auvergne

    The bug of not reading the newer Bruker DC file format has been fixed.

     
  • Edward d'Auvergne

    The frozen GUI bug has been shifted into bug #14.

     

Log in to post a comment.

MongoDB Logo MongoDB