Menu

Commit [r26350]  Maximize  Restore  History

Merged revisions 26305-26306 via svnmerge from

svn+ssh://bugman@.../svn/relax/trunk

........
r26305 | bugman | 2014-10-17 14:58:52 +0200 (Fri, 17 Oct 2014) | 14 lines

Changed the logic for how the new analysis wizard in the GUI is destroyed.

This relates to bug #22818 (https://gna.org/bugs/?22818), the GUI test suite failures in MS Windows
- PyAssertionError: C++ assertion "Assert failure".

The Destroy() method has been added to the Analysis_wizard class to properly close all elements of
the wizard. This is now called from the menu_new() method of the Analysis_controller class, which
is the target of the menu item and toolbar button.

To allow the test suite to use this, the menu_new() method now accepts the destroy boolean argument.
The test suite can set this to False and then access the GUI elements after calling the method
(however the Destroy() method must be called by the test suite).
........
r26306 | bugman | 2014-10-17 15:05:32 +0200 (Fri, 17 Oct 2014) | 16 lines

Resign of how the new analysis wizard is handled in the GUI tests.

This relates to bug #22818 (https://gna.org/bugs/?22818), the GUI test suite failures in MS Windows
- PyAssertionError: C++ assertion "Assert failure".

The GUI test base class method new_analysis_wizard() has been created to simplify the process. When
a new analysis is desired, this method should be called. It will return the analysis page GUI
element for use in the test. The method standardises the execution of the new analysis wizard and
sets up the analysis in the GUI. It also properly destroys the wizard to avoid the memory leaking
issues such as bug #22818.

All GUI tests have been converted to use new_analysis_wizard(). This allows the GUI tests to pass
on MS Windows. However there are still significant sources of memory leaks (the USER Objects count)
visible in the Windows Task Manager.
........

bugman 2014-10-22

changed /branches/space_mapping_refactor
changed /branches/space_mapping_refactor/gui/analyses/__init__.py
changed /branches/space_mapping_refactor/gui/analyses/wizard.py
changed /branches/space_mapping_refactor/test_suite/gui_tests/base_classes.py
changed /branches/space_mapping_refactor/test_suite/gui_tests/bruker.py
changed /branches/space_mapping_refactor/test_suite/gui_tests/general.py
changed /branches/space_mapping_refactor/test_suite/gui_tests/model_free.py
changed /branches/space_mapping_refactor/test_suite/gui_tests/noe.py
changed /branches/space_mapping_refactor/test_suite/gui_tests/relax_disp.py
changed /branches/space_mapping_refactor/test_suite/gui_tests/rx.py
/branches/space_mapping_refactor/gui/analyses/__init__.py Diff Switch to side-by-side view
Loading...
/branches/space_mapping_refactor/gui/analyses/wizard.py Diff Switch to side-by-side view
Loading...
/branches/space_mapping_refactor/test_suite/gui_tests/base_classes.py Diff Switch to side-by-side view
Loading...
/branches/space_mapping_refactor/test_suite/gui_tests/bruker.py Diff Switch to side-by-side view
Loading...
/branches/space_mapping_refactor/test_suite/gui_tests/general.py Diff Switch to side-by-side view
Loading...
/branches/space_mapping_refactor/test_suite/gui_tests/model_free.py Diff Switch to side-by-side view
Loading...
/branches/space_mapping_refactor/test_suite/gui_tests/noe.py Diff Switch to side-by-side view
Loading...
/branches/space_mapping_refactor/test_suite/gui_tests/relax_disp.py Diff Switch to side-by-side view
Loading...
/branches/space_mapping_refactor/test_suite/gui_tests/rx.py Diff Switch to side-by-side view
Loading...
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.