Menu

SVN archive Commit Log


Commit Date  
[r23334] by tlinnet

Modified unit tests demonstrating edge case 'no Rex' failures of the model 'NS CPMG 2-site expanded'.

This is to align with the current return of data in the disp_speed branch.

This follows from the ideas in the post http://article.gmane.org/gmane.science.nmr.relax.devel/5858.
This is related to: task #7793: (https://gna.org/task/?7793) Speed-up of dispersion models.

This is to implement catching of math domain errors, before they occur.

These tests cover all parameter value combinations which result in no exchange:

- dw = 0.0,
- pA = 1.0,
- kex = 0.0,
- dw = 0.0 and pA = 1.0,
- dw = 0.0 and kex = 0.0,
- pA = 1.0 and kex = 0.0,
- dw = 0.0, pA = 1.0, and kex = 0.0.

2014-05-22 13:19:32 Tree
[r23333] by tlinnet

Align math-domain catching for model NS CPMG 2-site expanded with trunk implementation.

task #7793: (https://gna.org/task/?7793) Speed-up of dispersion models.

This is to implement catching of math domain errors, before they occur.

The catching of errors have to be more careful.

2014-05-22 13:19:30 Tree
[r23332] by tlinnet

Merged revisions 23331 via svnmerge from
svn+ssh://tlinnet@.../svn/relax/trunk

........
r23331 | bugman | 2014-05-22 14:52:08 +0200 (Thu, 22 May 2014) | 10 lines

Fix for all edge case 'no Rex' failures of the 'NS CPMG 2-site expanded' model.

This uses the no exchange checking idea, modified to function in the relax trunk, from
http://article.gmane.org/gmane.science.nmr.relax.devel/5847. This is importantly on line 1 of the
function.

The recently introduced set of 7 unit tests (r23327) comprehensively showing these failures now all
pass. This commit is mainly for demonstration purposes.
........

2014-05-22 12:59:45 Tree
[r23331] by bugman

Fix for all edge case 'no Rex' failures of the 'NS CPMG 2-site expanded' model.

This uses the no exchange checking idea, modified to function in the relax trunk, from
http://article.gmane.org/gmane.science.nmr.relax.devel/5847. This is importantly on line 1 of the
function.

The recently introduced set of 7 unit tests (r23327) comprehensively showing these failures now all
pass. This commit is mainly for demonstration purposes.

2014-05-22 12:52:08 Tree
[r23330] by tlinnet

Merged revisions 23327-23329 via svnmerge from
svn+ssh://tlinnet@.../svn/relax/trunk

........
r23327 | bugman | 2014-05-22 14:05:01 +0200 (Thu, 22 May 2014) | 17 lines

Added 7 unit tests demonstrating edge case 'no Rex' failures of the 'NS CPMG 2-site expanded' model.

This follows from the ideas in the post http://article.gmane.org/gmane.science.nmr.relax.devel/5858.

These tests cover all parameter value combinations which result in no exchange:

- dw = 0.0,
- pA = 1.0,
- kex = 0.0,
- dw = 0.0 and pA = 1.0,
- dw = 0.0 and kex = 0.0,
- pA = 1.0 and kex = 0.0,
- dw = 0.0, pA = 1.0, and kex = 0.0.

Such tests should be replicated for all dispersion models.
........
r23328 | bugman | 2014-05-22 14:30:58 +0200 (Thu, 22 May 2014) | 6 lines

Created the Structure.test_bug_22069_structure_delete_helix_attribute system test.

This is to catch bug #22069 (https://gna.org/bugs/index.php?22069), the failure of the
structure.delete user function with "AttributeError: Internal instance has no attribute 'helices'".
........
r23329 | bugman | 2014-05-22 14:37:09 +0200 (Thu, 22 May 2014) | 6 lines

Fix for bug #22069 by only deleting helix and sheet data with structure.delete when it exists.

This is bug #22069 (https://gna.org/bugs/index.php?22069), the failure of the structure.delete user
function with "AttributeError: Internal instance has no attribute 'helices'".
........

2014-05-22 12:50:55 Tree
[r23329] by bugman

Fix for bug #22069 by only deleting helix and sheet data with structure.delete when it exists.

This is bug #22069 (https://gna.org/bugs/index.php?22069), the failure of the structure.delete user
function with "AttributeError: Internal instance has no attribute 'helices'".

2014-05-22 12:37:09 Tree
[r23328] by bugman

Created the Structure.test_bug_22069_structure_delete_helix_attribute system test.

This is to catch bug #22069 (https://gna.org/bugs/index.php?22069), the failure of the
structure.delete user function with "AttributeError: Internal instance has no attribute 'helices'".

2014-05-22 12:30:58 Tree
[r23327] by bugman

Added 7 unit tests demonstrating edge case 'no Rex' failures of the 'NS CPMG 2-site expanded' model.

This follows from the ideas in the post http://article.gmane.org/gmane.science.nmr.relax.devel/5858.

These tests cover all parameter value combinations which result in no exchange:

- dw = 0.0,
- pA = 1.0,
- kex = 0.0,
- dw = 0.0 and pA = 1.0,
- dw = 0.0 and kex = 0.0,
- pA = 1.0 and kex = 0.0,
- dw = 0.0, pA = 1.0, and kex = 0.0.

Such tests should be replicated for all dispersion models.

2014-05-22 12:05:01 Tree
[r23326] by bugman

Parameter update for the 2nd rotor CaM frame order test model optimisation script.

The Euler angles for the rotation about the motional pivot have been replaced by the translation
vector and Euler angle CoM rotation parameters.

2014-05-22 10:13:26 Tree
[r23325] by bugman

Merged revisions 23315-23319 via svnmerge from
svn+ssh://bugman@.../svn/relax/trunk

........
r23315 | tlinnet | 2014-05-21 20:36:33 +0200 (Wed, 21 May 2014) | 5 lines

Implemented systemtest Relax_disp.test_cpmg_synthetic_ns3d_to_b14.

bug #22021: (https://gna.org/bugs/?22021) Model B14 shows bad fitting to data.

This is to catch model B14 showing bad fitting behaviour.
........
r23316 | tlinnet | 2014-05-21 20:36:36 +0200 (Wed, 21 May 2014) | 42 lines

Extremely important fix to the model B14.

This was discovered by author Andrew Baldwin of the inspection of his code in relax.

bug #22021: (https://gna.org/bugs/?22021) Model B14 shows bad fitting to data.

The implementation was performed wrong for calculation of g3 and g4.
The implementations should be performed by trigonometric functions.

The model B14 was previously in a state of non-functioning.

The B14 model now shows excellent performance.

For the challenging case of data created with numerical model NS CPMG 2-site 3D:

sfrq_1 = 599.8908617*1E6
time_T2_1 = 0.06
ncycs_1 = [2, 4, 8, 10, 20, 30, 40, 60]
sfrq_2 = 499.8908617*1E6
time_T2_2 = 0.05
ncycs_2 = [2, 4, 8, 10, 30, 35, 40, 50]

r2 = 10. rad/s.
kex: 1000 rad/s
pA: 0.99
dw: 2. ppm

CR72 would fit:
----------
CR72 Ala :1@... r2 599.9 GRID=10.116 MIN=10.000 SET=10.000 RELC=0.000
CR72 Ala :1@... r2 499.9 GRID=10.080 MIN=9.999 SET=10.000 RELC=0.000
CR72 Ala :1@... pA GRID=0.929 MIN=0.990 SET=0.990 RELC=0.000
CR72 Ala :1@... dw GRID=1.429 MIN=1.925 SET=2.000 RELC=0.039
CR72 Ala :1@... kex GRID=5714.714 MIN=1034.721 SET=1000.000 RELC=0.034

B14 fits:
-----------
B14 Ala :1@... r2 599.9 GRID=10.116 MIN=10.000 SET=10.000 RELC=0.000
B14 Ala :1@... r2 499.9 GRID=10.080 MIN=10.000 SET=10.000 RELC=0.000
B14 Ala :1@... pA GRID=0.929 MIN=0.990 SET=0.990 RELC=0.000
B14 Ala :1@... dw GRID=1.429 MIN=2.000 SET=2.000 RELC=0.000
B14 Ala :1@... kex GRID=10000.000 MIN=1000.001 SET=1000.000 RELC=0.000
........
r23317 | tlinnet | 2014-05-21 20:36:37 +0200 (Wed, 21 May 2014) | 7 lines

Parameter precision increase for systemtest Relax_disp.test_baldwin_synthetic.

The correct implementation of the trigometric functions allow for higher precision.

bug #22021: (https://gna.org/bugs/?22021) Model B14 shows bad fitting to data.

Dublicate line codes was also removed.
........
r23318 | tlinnet | 2014-05-21 20:36:39 +0200 (Wed, 21 May 2014) | 5 lines

Code cleanup in systemtest Relax_disp.test_baldwin_synthetic_full.

bug #22021: (https://gna.org/bugs/?22021) Model B14 shows bad fitting to data.

The precision could also be increased with 1 digit.
........
r23319 | tlinnet | 2014-05-21 20:36:41 +0200 (Wed, 21 May 2014) | 5 lines

Code clean-up in systemtest Relax_disp.test_baldwin_synthetic.

bug #22021: (https://gna.org/bugs/?22021) Model B14 shows bad fitting to data.

Removing many unnecessary lines of code.
........

2014-05-22 10:06:48 Tree
Older >
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.