Menu

Commit [r22510]  Maximize  Restore  History

Merged revisions 22508-22509 via svnmerge from

svn+ssh://bugman@.../svn/relax/trunk

........
r22508 | bugman | 2014-03-19 08:37:35 +0100 (Wed, 19 Mar 2014) | 7 lines

Created the Structure.test_bug_21814_pdb_no_80_space_padding system test.

This is for catching bug #21814 (https://gna.org/bugs/?21814), the PDB reading failure when the PDB
records are not padded to 80 spaces. The PDB file used for the test is the same file as attached to
the bug report.
........
r22509 | bugman | 2014-03-19 08:53:20 +0100 (Wed, 19 Mar 2014) | 9 lines

Fix for bug #21814 (https://gna.org/bugs/?21814).

This is the PDB reading failure when the PDB records are not padded to 80 spaces. The fix is
simple, all PDB records are pre-validated. This includes removing all newline characters and
padding each PDB record to 80 spaces when needed. This will however add an overhead cost -- the
internal PDB reader will now be slower. However corrupted PDB files, produced by MODELLER for
example, not padded to 80 spaces will now be better supported.
........

bugman 2014-03-19

changed /branches/double_rotor
changed /branches/double_rotor/lib/structure/internal/object.py
changed /branches/double_rotor/test_suite/system_tests/structure.py
copied /trunk/test_suite/shared_data/structures/SpUreE_dimer_H_new.pdb.bz2 -> /branches/double_rotor/test_suite/shared_data/structures/SpUreE_dimer_H_new.pdb.bz2
/branches/double_rotor/lib/structure/internal/object.py Diff Switch to side-by-side view
Loading...
/branches/double_rotor/test_suite/system_tests/structure.py Diff Switch to side-by-side view
Loading...
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.