#12 Problem with makefile dsk

v3.2.8
closed-fixed
nobody
None
5
2014-01-12
2007-10-10
No

This is a very strange bug which I can't pin down. I can compile both 6809 and 6309 files from the Level2 directory with the makefile. However, I can't make disks. the command
make -f makefile dsk
errors out while trying to stock the CMDS directory with a complaint about matching ' (single quote).

With this in mind, if I then move to either the coco3 or coco3_6309 directories and enter
make -f makefile dsk
all disks are made and stocked. No errors are reported.

I don't see anything in the Level2 makefile that could be causing the above. This is on a WinXP system with MinGW and msys installed.

As bugs go, this is more an annoyance than anything else.

Discussion

  • Boisy Pitre

    Boisy Pitre - 2008-05-26

    Logged In: YES
    user_id=42881
    Originator: NO

    Is there an update to this problem Robert?

     
  • Robert Gault

    Robert Gault - 2008-05-27

    Logged In: YES
    user_id=859353
    Originator: YES

    I've not looked at this since filing the initial bug report. Gene has asked me to look at a dEd DD.BIT problem so I'll see what happens when I'm ready to compile a new dEd version.

    I'm pretty sure this bug is something in the makefile which you, Boisy, should be able to find more easilly than I. :)

     
  • Boisy Pitre

    Boisy Pitre - 2010-01-15

    Did this ever get addressed? If so we need to close it.

     
  • Robert Gault

    Robert Gault - 2010-01-16

    Christopher Hawks has come up with a correction for the quote problem, some script files that change all the makefiles.
    Chris runs this before an update
    ----------------------------------------------

    #$/bin/sh

    rm -f tmp

    files=`find . -name makefile -print`

    for file in $files
    do
    grep -q "no-print-directory" $file
    if [ $? -eq 0 ]; then
    echo $file
    sed -e "s/make --no-print-directory show/make show/" "$file" >tmp
    touch -r "$file" tmp
    mv tmp "$file"
    fi
    done
    ----------------------------------------------------------------------
    and runs this after an update.
    ----------------------------------------------------------------------

    #$/bin/sh

    rm -f tmp

    files=`find . -name makefile -print`

    for file in $files
    do
    grep -q "make show" $file
    if [ $? -eq 0 ]; then
    echo $file
    sed -e "s/make show/make --no-print-directory show/" "$file" >tmp
    touch -r "$file" tmp
    mv tmp "$file"
    fi
    done

    It seems to work for several people that compile the source code.

     
  • Christopher Hawks

    Works for me and Gene on Linux, for Robert in msys (?) on winders. If Mac OS doesn't mind, we can add the --no-print-directory option in the makefiles and we're fixed.

    Boisy: I thought I passed you the scripts. can you try the script that adds the option (script name is 'mine') (or just add the --no-print-directory to a 'make' command and Mac OS doesn't mind (it is probably the default).

     
  • Boisy Pitre

    Boisy Pitre - 2010-01-16

    Chris you may have but I don't remember. Exactly where does this option get passed?

     
  • Christopher Hawks

    Boisy:

    Some of the make commands (like these from level1/coco/makefile) are changed from:
    CMDS = $(shell $(CD) cmds; make showobjs)
    CMDS_D2 = $(shell $(CD) cmds; make showobjs_d2)
    BOOTTRACK = $(shell $(CD) modules; make showboottrack)
    to:
    CMDS = $(shell $(CD) cmds; make --no-print-directory showobjs)
    CMDS_D2 = $(shell $(CD) cmds; make --no-print-directory showobjs_d2)
    BOOTTRACK = $(shell $(CD) modules; make --no-print-directory showboottrack)

    Without the option, make adds lines like:
    Entering directory `/work/nitros9/level1/cmds'
    (Note that the single quotes are different.)
    This causes the [ /bin/sh: command substitution: line 0: unexpected EOF while looking for matching `'' ] error

     
  • Tormod Volden

    Tormod Volden - 2014-01-12
    • status: open --> closed-fixed
    • Group: --> v1.0 (example)
     
  • Tormod Volden

    Tormod Volden - 2014-01-12

    I believe this was fixed a long time ago. There is --no-print-directory in all the relevant places.

     
  • Tormod Volden

    Tormod Volden - 2014-01-12
    • Group: v1.0 (example) --> v3.2.9
     

Anonymous
Anonymous

Cancel  Add attachments