#2 Banshee support for "Now Playing"

open
nobody
None
5
2010-01-25
2010-01-25
No

I couldn't get the internal executeCommand function to do what I wanted so this patch pulls in subprocess again, but of course feel free to change it to use executeCommand.

Discussion

  • Christian Storgaard

    Oh, of course: patch attached.

     
  • quinox

    quinox - 2010-02-09

    I don't see any patch files attached to this bug report.

    We do not monitor this tracker. If you repost this at http://www.nicotine-plus.org/newticket we'll fix it ASAP.

     
  • Christian Storgaard

    You are right, that was weird. Patch attached now.

     
  • quinox

    quinox - 2010-02-14

    You seem to have been writing your patch against an older version of n+ - nowadays we use .glade files for defining GUI. The executeCommand doesn't work because you're giving all the commands as a single parameter instead of multiple. The regexp code is ugly at its best.

    Besides that thanks for the patch, I'll see if I can make it work. We're going to put out 1.2.15 very soon so you're just in time

     
  • quinox

    quinox - 2010-02-14

    I've applied your patch ad verbatim, but I'm really not happy with the regex. Since banshee wants to pull in 47MB worth of dependencies (all on .NET) I'm not going to try it out myself, could you see if the SVN version works properly?

    If you don't feel like rewriting the regex please provide a few example outputs from the banshee CLI so I can rewrite it.

    our Subversion: http://www.nicotine-plus.org/wiki/NicotineFromSubversion

     

Log in to post a comment.