Plant View doesn't update when Components are unselected
Modeling and Simulation made NiCE!
Brought to you by:
amccaskey,
jayjaybillings
I think I've got this working on my local branch of the git repo, I just need to test it a little more.
We may need to change the way we render plant components when they are in an "invalid" state, for instance junctions with no attached pipes.
Anna, when you get a chance, can you test this out? If it works for you, I can close this ticket.
We'll also need to add it to the change log.
This works on both Linux and Windows, but I did notice a buffer overflow error in
CustomTube.javawhen the vertex/normal/texture coordinates are read into float buffers.This only happened when unchecking "Components", which in turn unchecked all of the plant components.
This is not easily reproducible... I think it was a delayed thread that tried to work with the buffers after the view was removed from the scene. However, there could be a bug in
CustomTube.java. Frankly, the way it re-creates the tube mesh buffers is a little clunky (why re-create a buffer if its size doesn't change?).I think we should close this ticket. If anyone else experiences the buffer overflow bug, we should open a separate ticket to track it.
Setting to pending until Anna can give the signal that it works well on her machine.
This works for me. Closing this ticket.