Unchecking parent blocks should uncheck all child blocks too
Modeling and Simulation made NiCE!
Brought to you by:
amccaskey,
jayjaybillings
So what exactly does checking a node mean? Previously it corresponded
directly to a node's being active. Is being checked just so they are not
written to the file? Should we comment out the blocks in the file so they
can be persisted?
Jordan
On Sep 18, 2014 11:35 AM, "Anna Wojtowicz" awoj@users.sf.net wrote:
Related
MOOSE Bugs:
#3Being unchecked means they aren't written to file, but everything is still persisted whether its active or not.
Unchecking a parent actually means that all children are skipped from being written out too, whether or not the children are active, and this behavior is fine.
The only real issue here is that, visually, it might look confusing when you uncheck a parent, and its children still remain checked. To someone other than ourselves, it might look like subblocks will be written out without a parent block, even if ultimately we know that's not what happens.
So tl;dr unchecking a parent (setting
active = false
) should also set all children to inactive as well.I just fixed this with my last commit. In the
MOOSETreeCompositeViewer
, when a node is unchecked, all of its childTreeComposite
s are set as inactive. This is of course updated in the underlyingTreeViewer
.Closing.