Menu

#3 Unchecking parent blocks should uncheck all child blocks too

2.0
closed
None
2014-09-22
2014-09-18
No

Currently in the MOOSE TreeViewer, when you uncheck a parent node, the children remain checked. The action of unchecking a parent node should propagate through all the child and subchild nodes as well. On the other hand, unchecking a child should have no affect on the parent (the current behavior).

Related

MOOSE Bugs: #3

Discussion

  • Jordan Deyton

    Jordan Deyton - 2014-09-19

    So what exactly does checking a node mean? Previously it corresponded
    directly to a node's being active. Is being checked just so they are not
    written to the file? Should we comment out the blocks in the file so they
    can be persisted?

    Jordan
    On Sep 18, 2014 11:35 AM, "Anna Wojtowicz" awoj@users.sf.net wrote:


    Status: open
    Milestone: 2.0
    Created: Thu Sep 18, 2014 03:35 PM UTC by Anna Wojtowicz
    Last Updated: Thu Sep 18, 2014 03:35 PM UTC
    Owner: Jordan Deyton

    Currently in the MOOSE TreeViewer, when you uncheck a parent node, the
    children remain checked. The action of unchecking a parent node should
    propagate through all the child and subchild nodes as well. On the other
    hand, unchecking a child should have no affect on the parent (the current
    behavior).


    Sent from sourceforge.net because you indicated interest in
    https://sourceforge.net/p/niceproject/moosebugs/3/

    To unsubscribe from further messages, please visit
    https://sourceforge.net/auth/subscriptions/

     

    Related

    MOOSE Bugs: #3

  • Anna Wojtowicz

    Anna Wojtowicz - 2014-09-19

    Being unchecked means they aren't written to file, but everything is still persisted whether its active or not.

    Unchecking a parent actually means that all children are skipped from being written out too, whether or not the children are active, and this behavior is fine.

    The only real issue here is that, visually, it might look confusing when you uncheck a parent, and its children still remain checked. To someone other than ourselves, it might look like subblocks will be written out without a parent block, even if ultimately we know that's not what happens.

     
  • Anna Wojtowicz

    Anna Wojtowicz - 2014-09-19

    So tl;dr unchecking a parent (setting active = false) should also set all children to inactive as well.

     
  • Jordan Deyton

    Jordan Deyton - 2014-09-22
    • status: open --> closed
     
  • Jordan Deyton

    Jordan Deyton - 2014-09-22

    I just fixed this with my last commit. In the MOOSETreeCompositeViewer, when a node is unchecked, all of its child TreeComposites are set as inactive. This is of course updated in the underlying TreeViewer.

    Closing.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.