|
From: NHibernate J. <mik...@us...> - 2007-08-29 19:09:47
|
PostgreSQL 8.3 dialect with Guid type support
---------------------------------------------
Key: NH-1111
URL: http://jira.nhibernate.org/browse/NH-1111
Project: NHibernate
Issue Type: New Feature
Components: Data Providers
Affects Versions: 2.0.0.Alpha1
Reporter: David Bachmann
Attachments: PostgreSQL83Dialect.cs
Next version of PostgreSQL, 8.3, will support DbType.Guid.
This new dialect add this functionality.
It was not tested because Npgsql currently doesn't recognise DbType.Guid. But, except a big surprise, this should work like a charm.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: NHibernate J. <mik...@us...> - 2007-09-26 06:08:00
|
[ http://jira.nhibernate.org/browse/NH-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_15888 ]
Fabio Maulo commented on NH-1111:
---------------------------------
Are you secure that your patch work ? Are you test it using Guid in a "where" clause ?
Guid is not the same type of uuid.
I think that work for causality.
The right generator for PostgreSQL is uuid.hex.
Please check it and send the link of PostgreSQL and Npgsql where they talk about Guid.
Thanks.
> PostgreSQL 8.3 dialect with Guid type support
> ---------------------------------------------
>
> Key: NH-1111
> URL: http://jira.nhibernate.org/browse/NH-1111
> Project: NHibernate
> Issue Type: New Feature
> Components: Data Providers
> Affects Versions: 2.0.0.Alpha1
> Reporter: David Bachmann
> Attachments: PostgreSQL83Dialect.cs
>
>
> Next version of PostgreSQL, 8.3, will support DbType.Guid.
> This new dialect add this functionality.
> It was not tested because Npgsql currently doesn't recognise DbType.Guid. But, except a big surprise, this should work like a charm.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: NHibernate J. <mik...@us...> - 2007-09-28 12:08:02
|
[ http://jira.nhibernate.org/browse/NH-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_15907 ]
David Bachmann commented on NH-1111:
------------------------------------
PostgreSQL 8.3 supports GUID type by providing a new native type named UUID.
http://developer.postgresql.org/pgdocs/postgres/datatype-uuid.html
SQL queries like this one are now possible:
select * from foo where foo.uuid_field = '01234567-abcd-abcd-abcd-0123456789ab';
I've submitted a patch to Npgsql to add this new feature. It has been approved and applied on the CVS repository of Npgsl2:
http://pgfoundry.org/tracker/index.php?func=detail&aid=1008782&group_id=1000140&atid=592
http://lists.pgfoundry.org/pipermail/npgsql-devel/2007-September/000381.html
Every unit tests who failed with error 'Dialect does not support DbType.Guid' are now successfully passing.
Furthermore I've added a test to verify that GUID type are correctly supported in a where clause. (see attached patch)
Tests were done on Windows XP against PostgreSQL-8.3-dev1 (Windows binary version from PgInstaller: http://pgfoundry.org/projects/pginstaller/ ) using current CVS version of Npgsql2.
> PostgreSQL 8.3 dialect with Guid type support
> ---------------------------------------------
>
> Key: NH-1111
> URL: http://jira.nhibernate.org/browse/NH-1111
> Project: NHibernate
> Issue Type: New Feature
> Components: Data Providers
> Affects Versions: 2.0.0.Alpha1
> Reporter: David Bachmann
> Attachments: PostgreSQL83Dialect.cs
>
>
> Next version of PostgreSQL, 8.3, will support DbType.Guid.
> This new dialect add this functionality.
> It was not tested because Npgsql currently doesn't recognise DbType.Guid. But, except a big surprise, this should work like a charm.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: NHibernate J. <mik...@us...> - 2007-09-28 12:10:02
|
[ http://jira.nhibernate.org/browse/NH-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bachmann updated NH-1111:
-------------------------------
Attachment: NHibernate.Test.TypesTest.GuidTypeFixture.patch
> PostgreSQL 8.3 dialect with Guid type support
> ---------------------------------------------
>
> Key: NH-1111
> URL: http://jira.nhibernate.org/browse/NH-1111
> Project: NHibernate
> Issue Type: New Feature
> Components: Data Providers
> Affects Versions: 2.0.0.Alpha1
> Reporter: David Bachmann
> Attachments: NHibernate.Test.TypesTest.GuidTypeFixture.patch, PostgreSQL83Dialect.cs
>
>
> Next version of PostgreSQL, 8.3, will support DbType.Guid.
> This new dialect add this functionality.
> It was not tested because Npgsql currently doesn't recognise DbType.Guid. But, except a big surprise, this should work like a charm.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: NHibernate J. <mik...@us...> - 2007-09-28 14:24:59
|
[ http://jira.nhibernate.org/browse/NH-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_15913 ]
Fabio Maulo commented on NH-1111:
---------------------------------
Ok and thank for the test; it will be useful for some other Dialect too.
I'm going to post your patch ASAP.
> PostgreSQL 8.3 dialect with Guid type support
> ---------------------------------------------
>
> Key: NH-1111
> URL: http://jira.nhibernate.org/browse/NH-1111
> Project: NHibernate
> Issue Type: New Feature
> Components: Data Providers
> Affects Versions: 2.0.0.Alpha1
> Reporter: David Bachmann
> Attachments: NHibernate.Test.TypesTest.GuidTypeFixture.patch, PostgreSQL83Dialect.cs
>
>
> Next version of PostgreSQL, 8.3, will support DbType.Guid.
> This new dialect add this functionality.
> It was not tested because Npgsql currently doesn't recognise DbType.Guid. But, except a big surprise, this should work like a charm.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: NHibernate J. <mik...@us...> - 2007-09-28 14:26:58
|
[ http://jira.nhibernate.org/browse/NH-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fabio Maulo reassigned NH-1111:
-------------------------------
Assignee: Fabio Maulo
> PostgreSQL 8.3 dialect with Guid type support
> ---------------------------------------------
>
> Key: NH-1111
> URL: http://jira.nhibernate.org/browse/NH-1111
> Project: NHibernate
> Issue Type: New Feature
> Components: Data Providers
> Affects Versions: 2.0.0.Alpha1
> Reporter: David Bachmann
> Assignee: Fabio Maulo
> Attachments: NHibernate.Test.TypesTest.GuidTypeFixture.patch, PostgreSQL83Dialect.cs
>
>
> Next version of PostgreSQL, 8.3, will support DbType.Guid.
> This new dialect add this functionality.
> It was not tested because Npgsql currently doesn't recognise DbType.Guid. But, except a big surprise, this should work like a charm.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: NHibernate J. <mik...@us...> - 2007-10-03 13:46:59
|
[ http://jira.nhibernate.org/browse/NH-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fabio Maulo closed NH-1111.
---------------------------
Resolution: Fixed
Fix Version/s: 2.0.0.Alpha1
Changed PostgreSQL82Dialect directly.
> PostgreSQL 8.3 dialect with Guid type support
> ---------------------------------------------
>
> Key: NH-1111
> URL: http://jira.nhibernate.org/browse/NH-1111
> Project: NHibernate
> Issue Type: New Feature
> Components: Data Providers
> Affects Versions: 2.0.0.Alpha1
> Reporter: David Bachmann
> Assignee: Fabio Maulo
> Fix For: 2.0.0.Alpha1
>
> Attachments: NHibernate.Test.TypesTest.GuidTypeFixture.patch, PostgreSQL83Dialect.cs
>
>
> Next version of PostgreSQL, 8.3, will support DbType.Guid.
> This new dialect add this functionality.
> It was not tested because Npgsql currently doesn't recognise DbType.Guid. But, except a big surprise, this should work like a charm.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|