nhibernate-issues

[nhibernate-issues] [JIRA] Created: (NH-765) Use "(" and ")" to enclose the ToString of LogicalExpression.cs

[NHibernate J. <mik...@us...>]

Use "(" and ")" to enclose the ToString of LogicalExpression.cs
---------------------------------------------------------------

         Key: NH-765
         URL: http://jira.nhibernate.org/browse/NH-765
     Project: NHibernate
        Type: Patch
  Components: Core  
    Versions: 1.2.0.Beta1    
    Reporter: Kailuo Wang
    Priority: Trivial
 Attachments: LogicExpressionToString.patch


-			return _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString();
+			return "(" + _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString() + ")";

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[nhibernate-issues] [JIRA] Commented: (NH-765) Use "(" and ")" to enclose the ToString of LogicalExpression.cs

[NHibernate J. <mik...@us...>]

     [ http://jira.nhibernate.org/browse/NH-765?page=comments#action_14140 ]
     
Kailuo Wang commented on NH-765:
--------------------------------

An extremely simple patch :). 


> Use "(" and ")" to enclose the ToString of LogicalExpression.cs
> ---------------------------------------------------------------
>
>          Key: NH-765
>          URL: http://jira.nhibernate.org/browse/NH-765
>      Project: NHibernate
>         Type: Patch
>   Components: Core
>     Versions: 1.2.0.Beta1
>     Reporter: Kailuo Wang
>     Priority: Trivial
>  Attachments: LogicExpressionToString.patch
>
> -			return _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString();
> +			return "(" + _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString() + ")";

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[nhibernate-issues] [JIRA] Commented: (NH-765) Use "(" and ")" to enclose the ToString of LogicalExpression.cs

[NHibernate J. <mik...@us...>]

     [ http://jira.nhibernate.org/browse/NH-765?page=comments#action_14150 ]
     
Sergey Koshcheyev commented on NH-765:
--------------------------------------

I will add it, but ToString() isn't used anywhere, so I don't understand why you want it changed.

> Use "(" and ")" to enclose the ToString of LogicalExpression.cs
> ---------------------------------------------------------------
>
>          Key: NH-765
>          URL: http://jira.nhibernate.org/browse/NH-765
>      Project: NHibernate
>         Type: Patch
>   Components: Core
>     Versions: 1.2.0.Beta1
>     Reporter: Kailuo Wang
>     Priority: Trivial
>  Attachments: LogicExpressionToString.patch
>
> -			return _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString();
> +			return "(" + _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString() + ")";

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[nhibernate-issues] [JIRA] Closed: (NH-765) Use "(" and ")" to enclose the ToString of LogicalExpression.cs

[NHibernate J. <mik...@us...>]

     [ http://jira.nhibernate.org/browse/NH-765?page=all ]
     
Sergey Koshcheyev closed NH-765:
--------------------------------

    Fix Version: 1.2.0.Beta2
     Resolution: Fixed

> Use "(" and ")" to enclose the ToString of LogicalExpression.cs
> ---------------------------------------------------------------
>
>          Key: NH-765
>          URL: http://jira.nhibernate.org/browse/NH-765
>      Project: NHibernate
>         Type: Patch
>   Components: Core
>     Versions: 1.2.0.Beta1
>     Reporter: Kailuo Wang
>     Priority: Trivial
>      Fix For: 1.2.0.Beta2
>  Attachments: LogicExpressionToString.patch
>
> -			return _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString();
> +			return "(" + _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString() + ")";

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[nhibernate-issues] [JIRA] Commented: (NH-765) Use "(" and ")" to enclose the ToString of LogicalExpression.cs

[NHibernate J. <mik...@us...>]

     [ http://jira.nhibernate.org/browse/NH-765?page=comments#action_14154 ]
     
Kailuo Wang commented on NH-765:
--------------------------------

It will be used when in debug. 
ToString() helps debugger understand what and how the criteria consists of.   

> Use "(" and ")" to enclose the ToString of LogicalExpression.cs
> ---------------------------------------------------------------
>
>          Key: NH-765
>          URL: http://jira.nhibernate.org/browse/NH-765
>      Project: NHibernate
>         Type: Patch
>   Components: Core
>     Versions: 1.2.0.Beta1
>     Reporter: Kailuo Wang
>     Priority: Trivial
>      Fix For: 1.2.0.Beta2
>  Attachments: LogicExpressionToString.patch
>
> -			return _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString();
> +			return "(" + _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString() + ")";

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[nhibernate-issues] [JIRA] Updated: (NH-765) Use "(" and ")" to enclose the ToString of LogicalExpression.cs

[NHibernate J. <mik...@us...>]

     [ http://jira.nhibernate.org/browse/NH-765?page=all ]

Sergey Koshcheyev updated NH-765:
---------------------------------

    Comment: was deleted

> Use "(" and ")" to enclose the ToString of LogicalExpression.cs
> ---------------------------------------------------------------
>
>          Key: NH-765
>          URL: http://jira.nhibernate.org/browse/NH-765
>      Project: NHibernate
>         Type: Patch
>   Components: Core
>     Versions: 1.2.0.Beta1
>     Reporter: Kailuo Wang
>     Priority: Trivial
>      Fix For: 1.2.0.Beta2
>  Attachments: LogicExpressionToString.patch
>
> -			return _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString();
> +			return "(" + _lhs.ToString() + ' ' + Op + ' ' + _rhs.ToString() + ")";

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira