From: NHibernate J. <mik...@us...> - 2006-11-16 19:30:29
|
CacheKey key is invalid - memcached fails to store objects. ----------------------------------------------------------- Key: NH-813 URL: http://jira.nhibernate.org/browse/NH-813 Project: NHibernate Type: Patch Components: Core Versions: 1.2.0.Beta2 Reporter: Stuart Carnie Attachments: cachekey-fix.patch The CacheKey derives from IdentifierSpace, which is EntityMetaModel.RootTypeAssemblyQualifiedName. This name contains spaces, which causes an issue with MemCache, in the 'set' command. With the spaces in the key, an invalid command is sent to the memcached server. I have provided a patch that exposes a new property on EntityMetaModel, RootName (to match the property name in Hibernate), which simply replaces the spaces with underscores '_'. Now memcached caching works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: NHibernate J. <mik...@us...> - 2006-11-17 05:06:32
|
[ http://jira.nhibernate.org/browse/NH-813?page=all ] Sergey Koshcheyev updated NH-813: --------------------------------- Fix Version: 1.2.0.CR1 > CacheKey key is invalid - memcached fails to store objects. > ----------------------------------------------------------- > > Key: NH-813 > URL: http://jira.nhibernate.org/browse/NH-813 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta2 > Reporter: Stuart Carnie > Fix For: 1.2.0.CR1 > Attachments: cachekey-fix.patch > > The CacheKey derives from IdentifierSpace, which is EntityMetaModel.RootTypeAssemblyQualifiedName. This name contains spaces, which causes an issue with MemCache, in the 'set' command. With the spaces in the key, an invalid command is sent to the memcached server. > I have provided a patch that exposes a new property on EntityMetaModel, RootName (to match the property name in Hibernate), which simply replaces the spaces with underscores '_'. Now memcached caching works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: NHibernate J. <mik...@us...> - 2006-11-17 05:19:28
|
[ http://jira.nhibernate.org/browse/NH-813?page=comments#action_14420 ] Stuart Carnie commented on NH-813: ---------------------------------- I can port the functionality of Hibernate, if preferred. This allows the 'entity-name' attribute to be specified in the hbm.xml files. > CacheKey key is invalid - memcached fails to store objects. > ----------------------------------------------------------- > > Key: NH-813 > URL: http://jira.nhibernate.org/browse/NH-813 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta2 > Reporter: Stuart Carnie > Fix For: 1.2.0.CR1 > Attachments: cachekey-fix.patch > > The CacheKey derives from IdentifierSpace, which is EntityMetaModel.RootTypeAssemblyQualifiedName. This name contains spaces, which causes an issue with MemCache, in the 'set' command. With the spaces in the key, an invalid command is sent to the memcached server. > I have provided a patch that exposes a new property on EntityMetaModel, RootName (to match the property name in Hibernate), which simply replaces the spaces with underscores '_'. Now memcached caching works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: NHibernate J. <mik...@us...> - 2006-11-17 05:24:28
|
[ http://jira.nhibernate.org/browse/NH-813?page=comments#action_14421 ] Sergey Koshcheyev commented on NH-813: -------------------------------------- This would be great of course, but it's probably a separate issue. I haven't yet looked at what would be the correct way to fix this problem so I can't tell if entity-names would be the right solution. > CacheKey key is invalid - memcached fails to store objects. > ----------------------------------------------------------- > > Key: NH-813 > URL: http://jira.nhibernate.org/browse/NH-813 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta2 > Reporter: Stuart Carnie > Fix For: 1.2.0.CR1 > Attachments: cachekey-fix.patch > > The CacheKey derives from IdentifierSpace, which is EntityMetaModel.RootTypeAssemblyQualifiedName. This name contains spaces, which causes an issue with MemCache, in the 'set' command. With the spaces in the key, an invalid command is sent to the memcached server. > I have provided a patch that exposes a new property on EntityMetaModel, RootName (to match the property name in Hibernate), which simply replaces the spaces with underscores '_'. Now memcached caching works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: NHibernate J. <mik...@us...> - 2006-11-20 11:36:30
|
[ http://jira.nhibernate.org/browse/NH-813?page=comments#action_14442 ] Sergey Koshcheyev commented on NH-813: -------------------------------------- A better fix would be to alter MemCachedClient.KeyAsString method to do the right thing for keys of type CacheKey instead of just calling their ToString method. > CacheKey key is invalid - memcached fails to store objects. > ----------------------------------------------------------- > > Key: NH-813 > URL: http://jira.nhibernate.org/browse/NH-813 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta2 > Reporter: Stuart Carnie > Fix For: 1.2.0.CR1 > Attachments: cachekey-fix.patch > > The CacheKey derives from IdentifierSpace, which is EntityMetaModel.RootTypeAssemblyQualifiedName. This name contains spaces, which causes an issue with MemCache, in the 'set' command. With the spaces in the key, an invalid command is sent to the memcached server. > I have provided a patch that exposes a new property on EntityMetaModel, RootName (to match the property name in Hibernate), which simply replaces the spaces with underscores '_'. Now memcached caching works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: NHibernate J. <mik...@us...> - 2006-11-20 16:09:36
|
[ http://jira.nhibernate.org/browse/NH-813?page=comments#action_14446 ] Stuart Carnie commented on NH-813: ---------------------------------- I just thought it would be better to format the key appropriately earlier on, for performance reasons. If we do it where I suggested, we only remove the spaces once, when the meta-data for the entity is loaded, rather than every time we need to search for an entity in the cache. This results in less memory pressure, since we're not forced to allocate memory for the new string. Cheers, Stu > CacheKey key is invalid - memcached fails to store objects. > ----------------------------------------------------------- > > Key: NH-813 > URL: http://jira.nhibernate.org/browse/NH-813 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta2 > Reporter: Stuart Carnie > Fix For: 1.2.0.CR1 > Attachments: cachekey-fix.patch > > The CacheKey derives from IdentifierSpace, which is EntityMetaModel.RootTypeAssemblyQualifiedName. This name contains spaces, which causes an issue with MemCache, in the 'set' command. With the spaces in the key, an invalid command is sent to the memcached server. > I have provided a patch that exposes a new property on EntityMetaModel, RootName (to match the property name in Hibernate), which simply replaces the spaces with underscores '_'. Now memcached caching works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: NHibernate J. <mik...@us...> - 2006-11-20 16:31:39
|
[ http://jira.nhibernate.org/browse/NH-813?page=comments#action_14447 ] Ayende Rahien commented on NH-813: ---------------------------------- I don't think that the string is going to cause any significant issues, and I don't think that we should change NH to fit the cache. I just run into the same issue today, so that was happy timing > CacheKey key is invalid - memcached fails to store objects. > ----------------------------------------------------------- > > Key: NH-813 > URL: http://jira.nhibernate.org/browse/NH-813 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta2 > Reporter: Stuart Carnie > Fix For: 1.2.0.CR1 > Attachments: cachekey-fix.patch > > The CacheKey derives from IdentifierSpace, which is EntityMetaModel.RootTypeAssemblyQualifiedName. This name contains spaces, which causes an issue with MemCache, in the 'set' command. With the spaces in the key, an invalid command is sent to the memcached server. > I have provided a patch that exposes a new property on EntityMetaModel, RootName (to match the property name in Hibernate), which simply replaces the spaces with underscores '_'. Now memcached caching works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: NHibernate J. <mik...@us...> - 2006-11-21 09:38:36
|
[ http://jira.nhibernate.org/browse/NH-813?page=all ] Ayende Rahien reassigned NH-813: -------------------------------- Assign To: Ayende Rahien > CacheKey key is invalid - memcached fails to store objects. > ----------------------------------------------------------- > > Key: NH-813 > URL: http://jira.nhibernate.org/browse/NH-813 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta2 > Reporter: Stuart Carnie > Assignee: Ayende Rahien > Fix For: 1.2.0.CR1 > Attachments: cachekey-fix.patch > > The CacheKey derives from IdentifierSpace, which is EntityMetaModel.RootTypeAssemblyQualifiedName. This name contains spaces, which causes an issue with MemCache, in the 'set' command. With the spaces in the key, an invalid command is sent to the memcached server. > I have provided a patch that exposes a new property on EntityMetaModel, RootName (to match the property name in Hibernate), which simply replaces the spaces with underscores '_'. Now memcached caching works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: NHibernate J. <mik...@us...> - 2006-11-21 13:59:40
|
[ http://jira.nhibernate.org/browse/NH-813?page=all ] Ayende Rahien resolved NH-813: ------------------------------ Resolution: Fixed fixed in svn > CacheKey key is invalid - memcached fails to store objects. > ----------------------------------------------------------- > > Key: NH-813 > URL: http://jira.nhibernate.org/browse/NH-813 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta2 > Reporter: Stuart Carnie > Assignee: Ayende Rahien > Fix For: 1.2.0.CR1 > Attachments: cachekey-fix.patch > > The CacheKey derives from IdentifierSpace, which is EntityMetaModel.RootTypeAssemblyQualifiedName. This name contains spaces, which causes an issue with MemCache, in the 'set' command. With the spaces in the key, an invalid command is sent to the memcached server. > I have provided a patch that exposes a new property on EntityMetaModel, RootName (to match the property name in Hibernate), which simply replaces the spaces with underscores '_'. Now memcached caching works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |