From: cremor (JIRA) <nh...@gm...> - 2011-06-20 11:33:08
|
ProxyObjectReference creates a new ProxyFactory for each deserialization which disables proxy caching ----------------------------------------------------------------------------------------------------- Key: NH-2773 URL: http://216.121.112.228/browse/NH-2773 Project: NHibernate Issue Type: Bug Components: ByteCode providers Affects Versions: 3.2.0Beta1 Reporter: cremor Priority: Major If you deserialize a session which contains references to proxies a new ProxyFactory (and thus ProxyCache) is created for each reference which results in a new proxy assembly and module for each reference. I think this class should also use the static ProxyFactory field of the DefaultProxyFactory so the cache is correctly used. A test for this assumption is attached. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: cremor (JIRA) <nh...@gm...> - 2011-06-20 11:35:08
|
[ http://216.121.112.228/browse/NH-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cremor updated NH-2773: ----------------------- Attachment: NH2773 Test.zip > ProxyObjectReference creates a new ProxyFactory for each deserialization which disables proxy caching > ----------------------------------------------------------------------------------------------------- > > Key: NH-2773 > URL: http://216.121.112.228/browse/NH-2773 > Project: NHibernate > Issue Type: Bug > Components: ByteCode providers > Affects Versions: 3.2.0Beta1 > Reporter: cremor > Priority: Major > Attachments: NH2773 Test.zip > > > If you deserialize a session which contains references to proxies a new ProxyFactory (and thus ProxyCache) is created for each reference which results in a new proxy assembly and module for each reference. > I think this class should also use the static ProxyFactory field of the DefaultProxyFactory so the cache is correctly used. A test for this assumption is attached. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: cremor (JIRA) <nh...@gm...> - 2011-06-20 14:21:15
|
[ http://216.121.112.228/browse/NH-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21313#action_21313 ] cremor commented on NH-2773: ---------------------------- I just saw that in Beta2 the ProxyFactory field of the DefaultProxyFactory isn't static any more. I don't know if the DefaultProxyFactory itself is cached anywhere but if not my test will of course fail even after the fix (and I'd then also wonder how the proxy caching works at all). > ProxyObjectReference creates a new ProxyFactory for each deserialization which disables proxy caching > ----------------------------------------------------------------------------------------------------- > > Key: NH-2773 > URL: http://216.121.112.228/browse/NH-2773 > Project: NHibernate > Issue Type: Bug > Components: ByteCode providers > Affects Versions: 3.2.0Beta1 > Reporter: cremor > Priority: Major > Attachments: NH2773 Test.zip > > > If you deserialize a session which contains references to proxies a new ProxyFactory (and thus ProxyCache) is created for each reference which results in a new proxy assembly and module for each reference. > I think this class should also use the static ProxyFactory field of the DefaultProxyFactory so the cache is correctly used. A test for this assumption is attached. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Fabio M. (JIRA) <nh...@gm...> - 2011-06-21 13:15:32
|
[ http://216.121.112.228/browse/NH-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21314#action_21314 ] Fabio Maulo commented on NH-2773: --------------------------------- The test fail even with static ProxyFactory. The DefaultProxyFactory is part of the BytecodeProvider (static in Environment) > ProxyObjectReference creates a new ProxyFactory for each deserialization which disables proxy caching > ----------------------------------------------------------------------------------------------------- > > Key: NH-2773 > URL: http://216.121.112.228/browse/NH-2773 > Project: NHibernate > Issue Type: Bug > Components: ByteCode providers > Affects Versions: 3.2.0Beta1 > Reporter: cremor > Priority: Major > Attachments: NH2773 Test.zip > > > If you deserialize a session which contains references to proxies a new ProxyFactory (and thus ProxyCache) is created for each reference which results in a new proxy assembly and module for each reference. > I think this class should also use the static ProxyFactory field of the DefaultProxyFactory so the cache is correctly used. A test for this assumption is attached. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Fabio M. (JIRA) <nh...@gm...> - 2011-06-21 14:23:16
|
[ http://216.121.112.228/browse/NH-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabio Maulo resolved NH-2773. ----------------------------- Resolution: Fixed Fix Version/s: 3.2.0CR1 > ProxyObjectReference creates a new ProxyFactory for each deserialization which disables proxy caching > ----------------------------------------------------------------------------------------------------- > > Key: NH-2773 > URL: http://216.121.112.228/browse/NH-2773 > Project: NHibernate > Issue Type: Bug > Components: ByteCode providers > Affects Versions: 3.2.0Beta1 > Reporter: cremor > Priority: Major > Fix For: 3.2.0CR1 > > Attachments: NH2773 Test.zip > > > If you deserialize a session which contains references to proxies a new ProxyFactory (and thus ProxyCache) is created for each reference which results in a new proxy assembly and module for each reference. > I think this class should also use the static ProxyFactory field of the DefaultProxyFactory so the cache is correctly used. A test for this assumption is attached. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: cremor (JIRA) <nh...@gm...> - 2011-06-21 14:31:24
|
[ http://216.121.112.228/browse/NH-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21315#action_21315 ] cremor commented on NH-2773: ---------------------------- Just tried to test that but I could only reach a ProxyFactoryFactory (and not the ProxyFactory itself) via the BytecodeProvider. But it seems like you have fixed it differently now? > ProxyObjectReference creates a new ProxyFactory for each deserialization which disables proxy caching > ----------------------------------------------------------------------------------------------------- > > Key: NH-2773 > URL: http://216.121.112.228/browse/NH-2773 > Project: NHibernate > Issue Type: Bug > Components: ByteCode providers > Affects Versions: 3.2.0Beta1 > Reporter: cremor > Priority: Major > Fix For: 3.2.0CR1 > > Attachments: NH2773 Test.zip > > > If you deserialize a session which contains references to proxies a new ProxyFactory (and thus ProxyCache) is created for each reference which results in a new proxy assembly and module for each reference. > I think this class should also use the static ProxyFactory field of the DefaultProxyFactory so the cache is correctly used. A test for this assumption is attached. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |