nhibernate-issues

[nhibernate-issues] [JIRA] Commented: (NH-1452) Join element doesn't support keys with property-refs

[NHibernate J. <nh...@gm...>]

    [ http://jira.nhibernate.org/browse/NH-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467#action_17467 ] 

Jozef Sevcik commented on NH-1452:
----------------------------------

Patch I attached will not work for persistence/HQL.
It can fix loading entities that uses <join> with <property-ref> but when saving, primary key of parent is still used. Haven't tested HQL, but I assume it will not work properly.
There are two options:
1. Add support for persistence/HQL/StatelessSession also (http://opensource.atlassian.com/projects/hibernate/browse/HHH-1829?focusedCommentId=26029#action_26029 may be helpful, but it's not trivial IMHO)
2. Completely revert this feature (which has never been supported by Hibernate, e.g. <join> with <property-ref> has never been implemented in Hibernate, see Gavin response here: http://forum.hibernate.org/viewtopic.php?t=937111)
Problem is that 'property-ref' remains in XSD schema for <join><key>, that's why people tend to think this should work and it's bug if it does not work.

> Join element doesn't support keys with property-refs
> ----------------------------------------------------
>
>                 Key: NH-1452
>                 URL: http://jira.nhibernate.org/browse/NH-1452
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.CR2
>            Reporter: Brian Rumschlag
>            Priority: Major
>         Attachments: 1452.patch, NH1452.patch
>
>
> The <join> element does not use the property-ref attribute on it's <key>.
> It will always join to the child table by the primary key.
> Attached is the failing test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-1452) Join element doesn't support keys with property-refs

[Daniel G. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20611#action_20611 ] 

Daniel Guenter commented on NH-1452:
------------------------------------

I've patched this issue for both 2.1 and now 3.0 GA. The patch files can be found under issue 1681.

http://216.121.112.228/browse/NH-1681

Works for querying/persistence. Not sure if this will ever be integrated into the trunk, but I can always hope.

> Join element doesn't support keys with property-refs
> ----------------------------------------------------
>
>                 Key: NH-1452
>                 URL: http://216.121.112.228/browse/NH-1452
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.CR2
>            Reporter: Brian Rumschlag
>            Priority: Major
>         Attachments: 1452.patch, NH1452.patch
>
>
> The <join> element does not use the property-ref attribute on it's <key>.
> It will always join to the child table by the primary key.
> Attached is the failing test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-1452) Join element doesn't support keys with property-refs

[Jenar (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21190#action_21190 ] 

Jenar commented on NH-1452:
---------------------------

Would be great if this issue will get fixed in next NHibernate release, because i need it for some bigger project and this is a "base funtionality" in nativ sql.

> Join element doesn't support keys with property-refs
> ----------------------------------------------------
>
>                 Key: NH-1452
>                 URL: http://216.121.112.228/browse/NH-1452
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.CR2
>            Reporter: Brian Rumschlag
>            Priority: Major
>         Attachments: 1452.patch, NH1452.patch
>
>
> The <join> element does not use the property-ref attribute on it's <key>.
> It will always join to the child table by the primary key.
> Attached is the failing test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-1452) Join element doesn't support keys with property-refs

[Jenar (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21191#action_21191 ] 

Jenar commented on NH-1452:
---------------------------

Update: I mean for NHibernate 3.2.0 ;-)

> Join element doesn't support keys with property-refs
> ----------------------------------------------------
>
>                 Key: NH-1452
>                 URL: http://216.121.112.228/browse/NH-1452
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.CR2
>            Reporter: Brian Rumschlag
>            Priority: Major
>         Attachments: 1452.patch, NH1452.patch
>
>
> The <join> element does not use the property-ref attribute on it's <key>.
> It will always join to the child table by the primary key.
> Attached is the failing test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-1452) Join element doesn't support keys with property-refs

[Daniel G. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21196#action_21196 ] 

Daniel Guenter commented on NH-1452:
------------------------------------

I'll be patching this issue "again" when 3.2 GA comes out along with all of the other little issues that I've reported, patched and nobody has commented on.

https://bitbucket.org/nicaog/nhibernate-patches

> Join element doesn't support keys with property-refs
> ----------------------------------------------------
>
>                 Key: NH-1452
>                 URL: http://216.121.112.228/browse/NH-1452
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.CR2
>            Reporter: Brian Rumschlag
>            Priority: Major
>         Attachments: 1452.patch, NH1452.patch
>
>
> The <join> element does not use the property-ref attribute on it's <key>.
> It will always join to the child table by the primary key.
> Attached is the failing test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[nhibernate-issues] [NHJIRA] Commented: (NH-1452) Join element doesn't support keys with property-refs

[David M. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21296#action_21296 ] 

David McClelland commented on NH-1452:
--------------------------------------

Is this the same as NH-1681?  We'd love to see this patch rolled into the trunk.

> Join element doesn't support keys with property-refs
> ----------------------------------------------------
>
>                 Key: NH-1452
>                 URL: http://216.121.112.228/browse/NH-1452
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.CR2
>            Reporter: Brian Rumschlag
>            Priority: Major
>         Attachments: 1452.patch, NH1452.patch
>
>
> The <join> element does not use the property-ref attribute on it's <key>.
> It will always join to the child table by the primary key.
> Attached is the failing test case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira