Thread: [nhibernate-issues] [NHJIRA] Created: (NH-2551) Bad code practice. Function SessionFactoryImpl.GetI

Brought to you by: ayenderahien, bahusoid, fabiomaulo, fdelaporte, and 5 others

nhibernate-issues

[nhibernate-issues] [NHJIRA] Created: (NH-2551) Bad code practice. Function SessionFactoryImpl.GetImplementors: if type not found - value from ReflectHelper.ClassForFullName returns through TypeLoadException.

From: Michael F. (JIRA) <nh...@gm...> - 2011-02-28 12:49:10

Bad code practice. Function SessionFactoryImpl.GetImplementors: if type not found - value from ReflectHelper.ClassForFullName returns through TypeLoadException.
----------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: NH-2551
                 URL: http://216.121.112.228/browse/NH-2551
             Project:  NHibernate
          Issue Type: Bug
          Components: Core
    Affects Versions: 3.0.0.GA
            Reporter: Michael F.
            Priority: Major


Function NHibernate.DLL!NHibernate.Util.ReflectHelper.ClassForFullName(string classFullName) Line 222
NHibernate.DLL!NHibernate.Impl.SessionFactoryImpl.GetImplementors(string className) Line 616


to reproduce in VS2010
1. VS2010: set checkbox in menu Debug->Exceptions->Common language runtime exceptions->Thrown
2. try run standard test from a solution in debug mode:
NHibernate.Test.Linq.ByMethod.AnyTests.AnySublist()
3. System.TypeLoadException will be thrown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[nhibernate-issues] [NHJIRA] Commented: (NH-2551) Bad code practice. Function SessionFactoryImpl.GetImplementors: if type not found - value from ReflectHelper.ClassForFullName returns through TypeLoadException.

From: Julian M. (JIRA) <nh...@gm...> - 2011-03-02 09:49:21

    [ http://216.121.112.228/browse/NH-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20609#action_20609 ] 

Julian Maughan commented on NH-2551:
------------------------------------

How would you improve it?

> Bad code practice. Function SessionFactoryImpl.GetImplementors: if type not found - value from ReflectHelper.ClassForFullName returns through TypeLoadException.
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: NH-2551
>                 URL: http://216.121.112.228/browse/NH-2551
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.0.0.GA
>            Reporter: Michael F.
>            Priority: Major
>
> Function NHibernate.DLL!NHibernate.Util.ReflectHelper.ClassForFullName(string classFullName) Line 222
> NHibernate.DLL!NHibernate.Impl.SessionFactoryImpl.GetImplementors(string className) Line 616
> to reproduce in VS2010
> 1. VS2010: set checkbox in menu Debug->Exceptions->Common language runtime exceptions->Thrown
> 2. try run standard test from a solution in debug mode:
> NHibernate.Test.Linq.ByMethod.AnyTests.AnySublist()
> 3. System.TypeLoadException will be thrown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[nhibernate-issues] [NHJIRA] Updated: (NH-2551) Bad code practice. Function SessionFactoryImpl.GetImplementors: if type not found - value from ReflectHelper.ClassForFullName returns through TypeLoadException.

From: Fabio M. (JIRA) <nh...@gm...> - 2011-04-25 13:39:43

     [ http://216.121.112.228/browse/NH-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo updated NH-2551:
----------------------------

    Issue Type: Improvement  (was: Bug)

> Bad code practice. Function SessionFactoryImpl.GetImplementors: if type not found - value from ReflectHelper.ClassForFullName returns through TypeLoadException.
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: NH-2551
>                 URL: http://216.121.112.228/browse/NH-2551
>             Project:  NHibernate
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 3.0.0.GA
>            Reporter: Michael F.
>            Priority: Major
>
> Function NHibernate.DLL!NHibernate.Util.ReflectHelper.ClassForFullName(string classFullName) Line 222
> NHibernate.DLL!NHibernate.Impl.SessionFactoryImpl.GetImplementors(string className) Line 616
> to reproduce in VS2010
> 1. VS2010: set checkbox in menu Debug->Exceptions->Common language runtime exceptions->Thrown
> 2. try run standard test from a solution in debug mode:
> NHibernate.Test.Linq.ByMethod.AnyTests.AnySublist()
> 3. System.TypeLoadException will be thrown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[nhibernate-issues] [NHJIRA] Resolved: (NH-2551) Bad code practice. Function SessionFactoryImpl.GetImplementors: if type not found - value from ReflectHelper.ClassForFullName returns through TypeLoadException.

From: Fabio M. (JIRA) <nh...@gm...> - 2011-04-25 13:48:47

     [ http://216.121.112.228/browse/NH-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Maulo resolved NH-2551.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 3.2.0Alpha3

> Bad code practice. Function SessionFactoryImpl.GetImplementors: if type not found - value from ReflectHelper.ClassForFullName returns through TypeLoadException.
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: NH-2551
>                 URL: http://216.121.112.228/browse/NH-2551
>             Project:  NHibernate
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 3.0.0.GA
>            Reporter: Michael F.
>            Priority: Major
>             Fix For: 3.2.0Alpha3
>
>
> Function NHibernate.DLL!NHibernate.Util.ReflectHelper.ClassForFullName(string classFullName) Line 222
> NHibernate.DLL!NHibernate.Impl.SessionFactoryImpl.GetImplementors(string className) Line 616
> to reproduce in VS2010
> 1. VS2010: set checkbox in menu Debug->Exceptions->Common language runtime exceptions->Thrown
> 2. try run standard test from a solution in debug mode:
> NHibernate.Test.Linq.ByMethod.AnyTests.AnySublist()
> 3. System.TypeLoadException will be thrown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira