nhibernate-commit

[Nhibernate-commit] SF.net SVN: nhibernate:[3855] trunk/nhibernate/src/NHibernate/Transaction/ AdoTransaction.cs

[<te...@us...>]

Revision: 3855
          http://nhibernate.svn.sourceforge.net/nhibernate/?rev=3855&view=rev
Author:   tehlike
Date:     2008-10-13 16:40:25 +0000 (Mon, 13 Oct 2008)

Log Message:
-----------
Minor (fix NH-1522)

Modified Paths:
--------------
    trunk/nhibernate/src/NHibernate/Transaction/AdoTransaction.cs

Modified: trunk/nhibernate/src/NHibernate/Transaction/AdoTransaction.cs
===================================================================
--- trunk/nhibernate/src/NHibernate/Transaction/AdoTransaction.cs	2008-10-13 13:38:26 UTC (rev 3854)
+++ trunk/nhibernate/src/NHibernate/Transaction/AdoTransaction.cs	2008-10-13 16:40:25 UTC (rev 3855)
@@ -206,7 +206,7 @@
 			}
 			finally
 			{
-				CloseIfRequerid();
+				CloseIfRequired();
 			}
 		}
 
@@ -249,7 +249,7 @@
 				finally
 				{
 					AfterTransactionCompletion(false);
-					CloseIfRequerid();
+					CloseIfRequired();
 				}
 			}
 		}
@@ -288,7 +288,7 @@
 			get { return trans.IsolationLevel; }
 		}
 
-		void CloseIfRequerid()
+		void CloseIfRequired()
 		{
 			//bool close = session.ShouldAutoClose() && !transactionContext.isClosed();
 			//if (close)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Nhibernate-commit] SF.net SVN: nhibernate:[4936] trunk/nhibernate/src/NHibernate/Transaction/ AdoTransaction.cs

[<aye...@us...>]

Revision: 4936
          http://nhibernate.svn.sourceforge.net/nhibernate/?rev=4936&view=rev
Author:   ayenderahien
Date:     2010-01-27 14:40:36 +0000 (Wed, 27 Jan 2010)

Log Message:
-----------
Fixing NH-2082 applied patch from Bartosz Pierzchlewicz

Modified Paths:
--------------
    trunk/nhibernate/src/NHibernate/Transaction/AdoTransaction.cs

Modified: trunk/nhibernate/src/NHibernate/Transaction/AdoTransaction.cs
===================================================================
--- trunk/nhibernate/src/NHibernate/Transaction/AdoTransaction.cs	2010-01-27 14:38:34 UTC (rev 4935)
+++ trunk/nhibernate/src/NHibernate/Transaction/AdoTransaction.cs	2010-01-27 14:40:36 UTC (rev 4936)
@@ -115,6 +115,11 @@
 				{
 					throw new TransactionException("Cannot restart transaction after failed commit");
 				}
+				
+				if (isolationLevel == IsolationLevel.Unspecified)
+				{
+					isolationLevel = session.Factory.Settings.IsolationLevel;
+				}
 
 				log.Debug(string.Format("Begin ({0})", isolationLevel));
 
@@ -122,11 +127,6 @@
 				{
 					if (isolationLevel == IsolationLevel.Unspecified)
 					{
-						isolationLevel = session.Factory.Settings.IsolationLevel;
-					}
-
-					if (isolationLevel == IsolationLevel.Unspecified)
-					{
 						trans = session.Connection.BeginTransaction();
 					}
 					else


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Nhibernate-commit] SF.net SVN: nhibernate:[5546] trunk/nhibernate/src/NHibernate/Transaction/ AdoTransaction.cs

[<pa...@us...>]

Revision: 5546
          http://nhibernate.svn.sourceforge.net/nhibernate/?rev=5546&view=rev
Author:   patearl
Date:     2011-03-27 00:18:24 +0000 (Sun, 27 Mar 2011)

Log Message:
-----------
Improved compatibility of transaction handling across databases.

Modified Paths:
--------------
    trunk/nhibernate/src/NHibernate/Transaction/AdoTransaction.cs

Modified: trunk/nhibernate/src/NHibernate/Transaction/AdoTransaction.cs
===================================================================
--- trunk/nhibernate/src/NHibernate/Transaction/AdoTransaction.cs	2011-03-26 19:41:34 UTC (rev 5545)
+++ trunk/nhibernate/src/NHibernate/Transaction/AdoTransaction.cs	2011-03-27 00:18:24 UTC (rev 5546)
@@ -75,6 +75,9 @@
 				}
 				log.Debug("Enlist Command");
 
+                // If you try to assign a disposed transaction to a command with MSSQL, it will leave the command's
+                // transaction as null and not throw an error.  With SQLite, for example, it will throw an exception
+                // here instead.  Because of this, we set the trans field to null in when Dispose is called.
 				command.Transaction = trans;
 			}
 		}
@@ -363,6 +366,7 @@
 					if (trans != null)
 					{
 						trans.Dispose();
+					    trans = null;
 						log.Debug("IDbTransaction disposed.");
 					}
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.