nhibernate-commit

[Peter S. <sz...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/SqlCommand
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv13204/SqlCommand

Modified Files:
	Parameter.cs SelectFragment.cs SqlBaseBuilder.cs SqlString.cs 
Log Message:
Fixed performance issue regarding empty strings


Index: SqlString.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/SqlCommand/SqlString.cs,v
retrieving revision 1.14
retrieving revision 1.15
diff -C2 -d -r1.14 -r1.15
*** SqlString.cs	13 Sep 2004 07:11:05 -0000	1.14
--- SqlString.cs	21 Sep 2004 09:58:25 -0000	1.15
***************
*** 113,117 ****
  			builderString = builder.ToString();
  
! 			if(builderString!=String.Empty) 
  			{
  				sqlBuilder.Add(builderString);
--- 113,117 ----
  			builderString = builder.ToString();
  
! 			if(builderString.Length > 0) 
  			{
  				sqlBuilder.Add(builderString);
***************
*** 286,290 ****
  				// move on to the next SqlPart, otherwise lets make sure that 
  				// it does in fact start with the value
! 				if(partText!=String.Empty) 
  				{
  					return partText.StartsWith(value);
--- 286,290 ----
  				// move on to the next SqlPart, otherwise lets make sure that 
  				// it does in fact start with the value
! 				if(partText.Length > 0) 
  				{
  					return partText.StartsWith(value);

Index: Parameter.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/SqlCommand/Parameter.cs,v
retrieving revision 1.9
retrieving revision 1.10
diff -C2 -d -r1.9 -r1.10
*** Parameter.cs	9 Aug 2004 03:13:18 -0000	1.9
--- Parameter.cs	21 Sep 2004 09:58:25 -0000	1.10
***************
*** 149,153 ****
  		public override string ToString() 
  		{
! 			return (tableAlias==null || tableAlias==String.Empty)? 
  				":" + name : 
  				":" + tableAlias + "." + name;
--- 149,153 ----
  		public override string ToString() 
  		{
! 			return (tableAlias==null || tableAlias.Length == 0)? 
  				":" + name : 
  				":" + tableAlias + "." + name;

Index: SqlBaseBuilder.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/SqlCommand/SqlBaseBuilder.cs,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** SqlBaseBuilder.cs	10 Sep 2004 21:23:15 -0000	1.2
--- SqlBaseBuilder.cs	21 Sep 2004 09:58:25 -0000	1.3
***************
*** 69,73 ****
  
  				string columnName;
! 				if(tableAlias!=null && tableAlias!=String.Empty) {
  					columnName = tableAlias + StringHelper.Dot + columnNames[i];
  				}
--- 69,73 ----
  
  				string columnName;
! 				if(tableAlias!=null && tableAlias.Length > 0) {
  					columnName = tableAlias + StringHelper.Dot + columnNames[i];
  				}

Index: SelectFragment.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/SqlCommand/SelectFragment.cs,v
retrieving revision 1.5
retrieving revision 1.6
diff -C2 -d -r1.5 -r1.6
*** SelectFragment.cs	16 Aug 2004 05:18:52 -0000	1.5
--- SelectFragment.cs	21 Sep 2004 09:58:25 -0000	1.6
***************
*** 47,51 ****
  		public SelectFragment AddColumn(string tableAlias, string columnName, string columnAlias) 
  		{
! 			if(tableAlias==null || tableAlias==String.Empty) 
  			{
  				columns.Add(columnName);
--- 47,51 ----
  		public SelectFragment AddColumn(string tableAlias, string columnName, string columnAlias) 
  		{
! 			if(tableAlias==null || tableAlias.Length == 0) 
  			{
  				columns.Add(columnName);