nhibernate-commit — CVS Commits

[Nhibernate-commit] nhibernate/src/NHibernate.Test FooBarTest.cs,1.64,1.65

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate.Test
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv9912/NHibernate.Test

Modified Files:
	FooBarTest.cs 
Log Message:
Fixed a FetchMode to use the property name.

Index: FooBarTest.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate.Test/FooBarTest.cs,v
retrieving revision 1.64
retrieving revision 1.65
diff -C2 -d -r1.64 -r1.65
*** FooBarTest.cs	9 Sep 2004 21:20:17 -0000	1.64
--- FooBarTest.cs	11 Sep 2004 00:10:39 -0000	1.65
***************
*** 548,552 ****
  				.Add( Expression.Expression.In("Boolean", new bool[] {f.Boolean, f.Boolean} ) )
  				.SetFetchMode("TheFoo", FetchMode.Eager)
! 				.SetFetchMode("baz", FetchMode.Lazy)
  				.List();
  
--- 548,552 ----
  				.Add( Expression.Expression.In("Boolean", new bool[] {f.Boolean, f.Boolean} ) )
  				.SetFetchMode("TheFoo", FetchMode.Eager)
! 				.SetFetchMode("Baz", FetchMode.Lazy)
  				.List();
  

[Nhibernate-commit] nhibernate/src/NHibernate/Engine IPreparer.cs,1.2,1.3

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Engine
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv8474/src/NHibernate/Engine

Modified Files:
	IPreparer.cs 
Log Message:
Fixing some of the xmldoc problems.

Index: IPreparer.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Engine/IPreparer.cs,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** IPreparer.cs	25 Aug 2004 03:54:48 -0000	1.2
--- IPreparer.cs	10 Sep 2004 21:23:15 -0000	1.3
***************
*** 23,27 ****
  		/// 
  		/// DESIGNTHOUGHT: This is a bit of a false statement now - in order for ADO.NET to Prepare a command the
! 		/// Size & Precision of the Parameter HAVE to be set.  The current NHibernate codebase does
  		/// not do this.  I think to IType we can add a method int[] Size() and int[] Precision and
  		/// update each Type accordingly.  The only bad part about that is that for var length Parameters
--- 23,27 ----
  		/// 
  		/// DESIGNTHOUGHT: This is a bit of a false statement now - in order for ADO.NET to Prepare a command the
! 		/// Size & Precision of the Parameter HAVE to be set.  The current NHibernate codebase does
  		/// not do this.  I think to IType we can add a method int[] Size() and int[] Precision and
  		/// update each Type accordingly.  The only bad part about that is that for var length Parameters

[Nhibernate-commit] nhibernate/src/NHibernate/Util IdentityMap.cs,1.12,1.13

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Util
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv8474/src/NHibernate/Util

Modified Files:
	IdentityMap.cs 
Log Message:
Fixing some of the xmldoc problems.

Index: IdentityMap.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Util/IdentityMap.cs,v
retrieving revision 1.12
retrieving revision 1.13
diff -C2 -d -r1.12 -r1.13
*** IdentityMap.cs	28 Aug 2004 15:51:29 -0000	1.12
--- IdentityMap.cs	10 Sep 2004 21:23:16 -0000	1.13
***************
*** 8,12 ****
  
  	/// <summary>
! 	/// An <c>IDictionary</c> where keys are compared by object identity, rather than <c>equals</c>.
  	/// 
  	/// All external users of this class need to have no knowledge of the IdentityKey - it is all
--- 8,12 ----
  
  	/// <summary>
! 	/// An <see cref="IDictionary" /> where keys are compared by object identity, rather than <c>equals</c>.
  	/// 
  	/// All external users of this class need to have no knowledge of the IdentityKey - it is all
***************
*** 14,22 ****
  	/// </summary>
  	/// <remarks>
  	/// Do NOT use a System.Value type as the key for this Hashtable - only classes.  See
! 	/// the google thread 
! 	/// http://groups.google.com/groups?hl=en&lr=&ie=UTF-8&oe=UTF-8&threadm=bds2rm%24ruc%241%40charly.heeg.de&rnum=1&prev=/groups%3Fhl%3Den%26lr%3D%26ie%3DUTF-8%26oe%3DUTF-8%26q%3DSystem.Runtime.CompilerServices.RuntimeHelpers.GetHashCode%26sa%3DN%26tab%3Dwg
  	/// about why using System.Value is a bad thing.
! 	/// <p>
  	/// If I understand it correctly, the first call to get an object defined by a DateTime("2003-01-01")
  	/// would box the DateTime and return the identity key for the box.  If you were to get that Key and
--- 14,23 ----
  	/// </summary>
  	/// <remarks>
+ 	/// <para>
  	/// Do NOT use a System.Value type as the key for this Hashtable - only classes.  See
! 	/// the <a href="http://groups.google.com/groups?hl=en&lr=&ie=UTF-8&oe=UTF-8&threadm=bds2rm%24ruc%241%40charly.heeg.de&rnum=1&prev=/groups%3Fhl%3Den%26lr%3D%26ie%3DUTF-8%26oe%3DUTF-8%26q%3DSystem.Runtime.CompilerServices.RuntimeHelpers.GetHashCode%26sa%3DN%26tab%3Dwg">google thread</a>
  	/// about why using System.Value is a bad thing.
! 	/// </para>
! 	/// <para>
  	/// If I understand it correctly, the first call to get an object defined by a DateTime("2003-01-01")
  	/// would box the DateTime and return the identity key for the box.  If you were to get that Key and
***************
*** 24,28 ****
  	/// would box it again (into a different box) and it would have a different IdentityKey - so you would
  	/// not get the same value for the same DateTime value. 
! 	/// </p>
  	/// </remarks>
  	[Serializable]
--- 25,29 ----
  	/// would box it again (into a different box) and it would have a different IdentityKey - so you would
  	/// not get the same value for the same DateTime value. 
! 	/// </para>
  	/// </remarks>
  	[Serializable]

[Nhibernate-commit] nhibernate/src/NHibernate/Property FieldAccessor.cs,1.3,1.4 PropertyAccessorFactory.cs,1.3,1.4

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Property
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv8474/src/NHibernate/Property

Modified Files:
	FieldAccessor.cs PropertyAccessorFactory.cs 
Log Message:
Fixing some of the xmldoc problems.

Index: PropertyAccessorFactory.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Property/PropertyAccessorFactory.cs,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -d -r1.3 -r1.4
*** PropertyAccessorFactory.cs	23 Aug 2004 13:11:08 -0000	1.3
--- PropertyAccessorFactory.cs	10 Sep 2004 21:23:15 -0000	1.4
***************
*** 31,40 ****
  		/// <returns></returns>
  		/// <remarks>
! 		/// <p>
  		/// The built in ways of accessing the values of Properties in your domain class are:
! 		/// </p>
  		/// <list type="table">
  		///		<listheader>
! 		///			<term>access method</term>
  		///			<description>How NHibernate accesses the Mapped Class.</description>
  		///		</listheader>
--- 31,40 ----
  		/// <returns></returns>
  		/// <remarks>
! 		/// <para>
  		/// The built in ways of accessing the values of Properties in your domain class are:
! 		/// </para>
  		/// <list type="table">
  		///		<listheader>
! 		///			<term>Access Method</term>
  		///			<description>How NHibernate accesses the Mapped Class.</description>
  		///		</listheader>
***************
*** 52,56 ****
  		///				in the Mapped Class those will be bypassed and NHibernate will go straight to the
  		///				field.  This is a good option if your setters have business rules attached to them
! 		///				or if you don't want to expose a field through a Getter & Setter.
  		///			</description>
  		///		</item>
--- 52,56 ----
  		///				in the Mapped Class those will be bypassed and NHibernate will go straight to the
  		///				field.  This is a good option if your setters have business rules attached to them
! 		///				or if you don't want to expose a field through a Getter &amp; Setter.
  		///			</description>
  		///		</item>
***************
*** 73,81 ****
  		///		</item>
  		///	</list>
! 		///	<p>
  		///	In order for the <c>nosetter</c> to know the name of the field to access NHibernate needs to know
  		///	what the naming strategy is.  The following naming strategies are built into NHibernate:
! 		///	</p>
  		///	<list type="table">
  		///		<item>
  		///			<term>camelcase</term>
--- 73,85 ----
  		///		</item>
  		///	</list>
! 		///	<para>
  		///	In order for the <c>nosetter</c> to know the name of the field to access NHibernate needs to know
  		///	what the naming strategy is.  The following naming strategies are built into NHibernate:
! 		///	</para>
  		///	<list type="table">
+ 		///		<listheader>
+ 		///			<term>Naming Strategy</term>
+ 		///			<description>How NHibernate converts the value of the <c>name</c> attribute to a field name.</description>
+ 		///		</listheader>
  		///		<item>
  		///			<term>camelcase</term>

Index: FieldAccessor.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Property/FieldAccessor.cs,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -d -r1.3 -r1.4
*** FieldAccessor.cs	23 Aug 2004 13:11:08 -0000	1.3
--- FieldAccessor.cs	10 Sep 2004 21:23:15 -0000	1.4
***************
*** 67,71 ****
  		/// <returns>The name of the Field.</returns>
  		/// <remarks>
! 		/// This uses the convention that a Property named <c>Id</c> will have a field </c>id</c>
  		/// </remarks>
  		private string GetFieldName(string propertyName) 
--- 67,71 ----
  		/// <returns>The name of the Field.</returns>
  		/// <remarks>
! 		/// This uses the convention that a Property named <c>Id</c> will have a field <c>id</c>
  		/// </remarks>
  		private string GetFieldName(string propertyName) 

[Nhibernate-commit] nhibernate/src/NHibernate/Collection PersistentCollection.cs,1.13,1.14 Set.cs,1.12,1.13

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Collection
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv8474/src/NHibernate/Collection

Modified Files:
	PersistentCollection.cs Set.cs 
Log Message:
Fixing some of the xmldoc problems.

Index: PersistentCollection.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Collection/PersistentCollection.cs,v
retrieving revision 1.13
retrieving revision 1.14
diff -C2 -d -r1.13 -r1.14
*** PersistentCollection.cs	2 Sep 2004 15:07:19 -0000	1.13
--- PersistentCollection.cs	10 Sep 2004 21:23:14 -0000	1.14
***************
*** 14,19 ****
  	/// persistent when held by a persistent object. Collections can be
  	/// passed between different objects (change "roles") and this might
! 	/// cause their elements to move from one database table to another.<br>
! 	/// <br>
  	/// Hibernate "wraps" a java collection in an instance of
  	/// PersistentCollection. This mechanism is designed to support
--- 14,19 ----
  	/// persistent when held by a persistent object. Collections can be
  	/// passed between different objects (change "roles") and this might
! 	/// cause their elements to move from one database table to another.
! 	/// <br /><br />
  	/// Hibernate "wraps" a java collection in an instance of
  	/// PersistentCollection. This mechanism is designed to support
***************
*** 21,30 ****
  	/// lazy instantiation of collection elements. The downside is that
  	/// only certain abstract collection types are supported and any
! 	/// extra semantics are lost<br>
! 	/// <br>
! 	/// Applications should <em>never</em> use classes in this package 
! 	/// directly, unless extending the "framework" here.<br>
! 	/// <br>
! 	/// Changes to <em>structure</em> of the collection are recorded by the
  	/// collection calling back to the session. Changes to mutable
  	/// elements (ie. composite elements) are discovered by cloning their
--- 21,30 ----
  	/// lazy instantiation of collection elements. The downside is that
  	/// only certain abstract collection types are supported and any
! 	/// extra semantics are lost.
! 	/// <br /><br />
! 	/// Applications should <b>never</b> use classes in this package 
! 	/// directly, unless extending the "framework" here.
! 	/// <br /><br />
! 	/// Changes to <b>structure</b> of the collection are recorded by the
  	/// collection calling back to the session. Changes to mutable
  	/// elements (ie. composite elements) are discovered by cloning their
***************
*** 32,36 ****
  	/// time.
  	/// 
- 	/// @author Gavin King
  	/// </summary>
  	[Serializable]
--- 32,35 ----

Index: Set.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Collection/Set.cs,v
retrieving revision 1.12
retrieving revision 1.13
diff -C2 -d -r1.12 -r1.13
*** Set.cs	2 Sep 2004 15:07:19 -0000	1.12
--- Set.cs	10 Sep 2004 21:23:14 -0000	1.13
***************
*** 32,36 ****
  
  		/// <summary>
! 		/// Returns a Hashtable where the Key & the Value are both a Copy of the
  		/// same object.
  		/// <see cref="PersistentCollection.Snapshot"/>
--- 32,36 ----
  
  		/// <summary>
! 		/// Returns a Hashtable where the Key &amp; the Value are both a Copy of the
  		/// same object.
  		/// <see cref="PersistentCollection.Snapshot"/>

[Nhibernate-commit] nhibernate/src/NHibernate/Mapping Property.cs,1.8,1.9 RootClass.cs,1.9,1.10

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Mapping
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv8474/src/NHibernate/Mapping

Modified Files:
	Property.cs RootClass.cs 
Log Message:
Fixing some of the xmldoc problems.

Index: Property.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Mapping/Property.cs,v
retrieving revision 1.8
retrieving revision 1.9
diff -C2 -d -r1.8 -r1.9
*** Property.cs	22 Aug 2004 06:22:13 -0000	1.8
--- Property.cs	10 Sep 2004 21:23:15 -0000	1.9
***************
*** 27,30 ****
--- 27,33 ----
  		}
  
+ 		/// <summary>
+ 		/// Gets the number of columns this property uses in the db.
+ 		/// </summary>
  		public int ColumnSpan 
  		{
***************
*** 32,35 ****
--- 35,41 ----
  		}
  
+ 		/// <summary>
+ 		/// Gets an <see cref="ICollection"/> of <see cref="Column"/>s.
+ 		/// </summary>
  		public ICollection ColumnCollection 
  		{
***************
*** 37,40 ****
--- 43,49 ----
  		}
  
+ 		/// <summary>
+ 		/// Gets or Sets the name of the Property in the class.
+ 		/// </summary>
  		public string Name 
  		{

Index: RootClass.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Mapping/RootClass.cs,v
retrieving revision 1.9
retrieving revision 1.10
diff -C2 -d -r1.9 -r1.10
*** RootClass.cs	29 Apr 2004 16:36:55 -0000	1.9
--- RootClass.cs	10 Sep 2004 21:23:15 -0000	1.10
***************
*** 5,8 ****
--- 5,86 ----
  namespace NHibernate.Mapping 
  {	
+ 	/// <summary>
+ 	/// Declaration of a System.Type by using the <c>&lt;class&gt;</c> element.
+ 	/// </summary>
+ 	/// <remarks>
+ 	/// <p>The <c>&lt;class&gt;</c> element has the following attributes available:</p>
+ 	/// <list type="table">
+ 	///		<listheader>
+ 	///			<term>Attribute</term>
+ 	///			<description>Possible Values</description>
+ 	///		</listheader>
+ 	///		<item>
+ 	///			<term>name</term>
+ 	///			<description>The fully qualified TypeName so it can be loaded by Reflection</description>
+ 	///		</item>
+ 	///		<item>
+ 	///			<term>table</term>
+ 	///			<description>The name of its database table.</description>
+ 	///		</item>
+ 	///		<item>
+ 	///			<term>discriminator-value</term>
+ 	///			<description>
+ 	///				(optional - defaults to the FullClassName)  A value that distinguishes individual
+ 	///				subclasses, used for polymorphic behavior.
+ 	///			</description>
+ 	///		</item>
+ 	///		<item>
+ 	///			<term>mutable</term>
+ 	///			<description>
+ 	///				(optional - defaults to <c>true</c>)  Specifies that instances of the class
+ 	///				are (not) mutable.
+ 	///			</description>
+ 	///		</item>
+ 	///		<item>
+ 	///			<term>schema</term>
+ 	///			<description>(optional)  Override the schema name specified by the root <c>&lt;hibernate-mapping&gt;</c> element.</description>
+ 	///		</item>
+ 	///		<item>
+ 	///			<term>proxy</term>
+ 	///			<description>
+ 	///				(optional) Specifies an interface to use for lazy initializing proxies.  
+ 	///				You may specify the name of the class itself. 
+ 	///				(TODO: update once Proxies are implemented)
+ 	///			</description>
+ 	///		</item>
+ 	///		<item>
+ 	///			<term>dynamic-update</term>
+ 	///			<description>
+ 	///				(optional - defaults to <c>false</c>) Specifies the <c>UPDATE</c> SQL should 
+ 	///				be generated at runtime and contain only those columns whose values have changed.
+ 	///			</description>
+ 	///		</item>
+ 	///		<item>
+ 	///			<term>dynamic-insert</term>
+ 	///			<description>
+ 	///				(optional - defaults to <c>false</c>)  Specifies the <c>INSERT</c> SQL should 
+ 	///				be generated at runtime and contain only those columns whose values are not null.
+ 	///			</description>
+ 	///		</item>
+ 	///		<item>
+ 	///			<term>polymorphism</term>
+ 	///			<description>
+ 	///				(optional, defaults to <c>implicit</c>)  Determines whether implicit or explicit
+ 	///				query polymorphism is used.	
+ 	///			</description>
+ 	///		</item>
+ 	///		<item>
+ 	///			<term>where</term>
+ 	///			<description>
+ 	///				(optional) Specify an arbitrary SQL <c>WHERE</c> condition to be used 
+ 	///				when retrieving objects of this class.
+ 	///			</description>
+ 	///		</item>
+ 	///		<item>
+ 	///			<term>persister</term>
+ 	///			<description>(optional)  Specifies a custom <see cref="Persister.IClassPersister"/>.</description>
+ 	///		</item>
+ 	/// </list>
+ 	/// </remarks>
  	public class RootClass : PersistentClass 
  	{
***************
*** 111,114 ****
--- 189,228 ----
  		}
  
+ 		/// <summary>
+ 		/// Gets or Sets the <see cref="Property"/> to use as the Version Property
+ 		/// </summary>
+ 		/// <value>The <see cref="Property"/> to use for Versioning.</value>
+ 		/// <remarks>
+ 		/// <para>
+ 		/// The &;tlversion&gt; element is optional and indicates that the table contains versioned data. 
+ 		/// This is particularly useful if you plan to use long transactions (see below). 
+ 		/// </para>
+ 		/// <para>
+ 		/// <list type="table">
+ 		///		<listheader>
+ 		///			<term>Attribute</term>
+ 		///			<description>Possible Values</description>
+ 		///		</listheader>
+ 		///		<item>
+ 		///			<term>column</term>
+ 		///			<description>
+ 		///				The name of the <c>column</c> holding the version number.  
+ 		///				Defaults to the Property name.
+ 		///			</description>
+ 		///		</item>
+ 		///		<item>
+ 		///			<term>name</term>
+ 		///			<description>The name of the Property in the Persistent Class.</description>
+ 		///		</item>
+ 		///		<item>
+ 		///			<term>type</term>
+ 		///			<description>
+ 		///				The <see cref="Type.IType"/> of the Property.  Defaults to an <see cref="Type.Int32Type"/>.  It 
+ 		///				be any <see cref="Type.IVersionType"/>.   
+ 		///			</description>
+ 		///		</item>
+ 		///	</list>
+ 		/// </para>
+ 		/// </remarks>
  		public override Property Version 
  		{
***************
*** 117,120 ****
--- 231,239 ----
  		}
  
+ 		/// <summary>
+ 		/// Gets a value indicating if the <see cref="PersistentClass" /> is versioned
+ 		/// by NHibernate.
+ 		/// </summary>
+ 		/// <value><c>true</c> if there is a version property.</value>
  		public override bool IsVersioned 
  		{

[Nhibernate-commit] nhibernate/src/NHibernate/Persister AbstractEntityPersister.cs,1.24,1.25

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Persister
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23636/NHibernate/Persister

Modified Files:
	AbstractEntityPersister.cs 
Log Message:
Switched order of null check to be before Equals because Mono does 
not like have a null object passed into Equals.

Index: AbstractEntityPersister.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Persister/AbstractEntityPersister.cs,v
retrieving revision 1.24
retrieving revision 1.25
diff -C2 -d -r1.24 -r1.25
*** AbstractEntityPersister.cs	2 Sep 2004 15:11:01 -0000	1.24
--- AbstractEntityPersister.cs	10 Sep 2004 12:21:21 -0000	1.25
***************
*** 655,659 ****
  			//pis.Add( typeof(INHibernateProxy) );
  			// != null because we use arraylist instead of hashset
! 			if (!mappedClass.Equals(pi) && pi!=null ) 
  			{
  				pis.Add(pi); 
--- 655,660 ----
  			//pis.Add( typeof(INHibernateProxy) );
  			// != null because we use arraylist instead of hashset
! 			// mono does not like a null value passed into Equals()
! 			if ( pi!=null && !mappedClass.Equals(pi) ) 
  			{
  				pis.Add(pi); 

[Nhibernate-commit] nhibernate/src/NHibernate/Collection Bag.cs,1.5,1.6

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Collection
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv11723/NHibernate/Collection

Modified Files:
	Bag.cs 
Log Message:
Added a TODO comment because of how poorly Bag implements IList.Add
because of diff between java collections and .net collections.

Index: Bag.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Collection/Bag.cs,v
retrieving revision 1.5
retrieving revision 1.6
diff -C2 -d -r1.5 -r1.6
*** Bag.cs	9 Aug 2004 03:11:45 -0000	1.5
--- Bag.cs	9 Sep 2004 21:22:14 -0000	1.6
***************
*** 298,301 ****
--- 298,304 ----
  			else 
  			{
+ 				//TODO: take a look at this - I don't like it because it changes the 
+ 				// meaning of Add - instead of returning the index it was added at 
+ 				// returns a "fake" index - not consistent with IList interface...
  				return -1;
  			}

[Nhibernate-commit] nhibernate/src/NHibernate.Test/TypesTest DateTimeTypeFixture.cs,NONE,1.1

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate.Test/TypesTest
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv11326/TypesTest

Added Files:
	DateTimeTypeFixture.cs 
Log Message:
Added test for DateTimeType and modified name of Table in hand 
coded Sql inside of FooBarTest because MySql is case sensitive.

--- NEW FILE: DateTimeTypeFixture.cs ---
using System;

using NHibernate.Type;

using NUnit.Framework;

namespace NHibernate.Test.TypesTest 
{

	/// <summary>
	/// TestFixtures for the <see cref="DateTimeType"/>.
	/// </summary>
	[TestFixture]
	public class DateTimeTypeFixture 
	{
		[Test]
		public void DeepCopyNotNull() 
		{
			NullableType type = NHibernate.DateTime;

			object value1 = DateTime.Now;

			object value2 = type.DeepCopyNotNull(value1);

			Assert.AreEqual( value1, value2, "Copies should be the same.");
			Assert.IsFalse( Object.ReferenceEquals(value1, value2), "Should be different objects in memory." );

			value2 = ((DateTime)value2).AddHours(2);

			Assert.IsFalse( value1==value2, "value2 was changed, should not be the same." );
		}
	}
}

[Nhibernate-commit] nhibernate/src/NHibernate.Test FooBarTest.cs,1.63,1.64 NHibernate.Test-1.1.csproj,1.40,1.41

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate.Test
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv11326

Modified Files:
	FooBarTest.cs NHibernate.Test-1.1.csproj 
Log Message:
Added test for DateTimeType and modified name of Table in hand 
coded Sql inside of FooBarTest because MySql is case sensitive.

Index: FooBarTest.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate.Test/FooBarTest.cs,v
retrieving revision 1.63
retrieving revision 1.64
diff -C2 -d -r1.63 -r1.64
*** FooBarTest.cs	2 Sep 2004 13:04:57 -0000	1.63
--- FooBarTest.cs	9 Sep 2004 21:20:17 -0000	1.64
***************
*** 671,675 ****
  
  			IDbCommand deleteCmd = s.Connection.CreateCommand();
! 			deleteCmd.CommandText = "delete from fooArray where id_='" + baz.Code + "' and i>=8";
  			deleteCmd.CommandType = CommandType.Text;
  			int rows = deleteCmd.ExecuteNonQuery();
--- 671,675 ----
  
  			IDbCommand deleteCmd = s.Connection.CreateCommand();
! 			deleteCmd.CommandText = "delete from FooArray where id_='" + baz.Code + "' and i>=8";
  			deleteCmd.CommandType = CommandType.Text;
  			int rows = deleteCmd.ExecuteNonQuery();

Index: NHibernate.Test-1.1.csproj
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate.Test/NHibernate.Test-1.1.csproj,v
retrieving revision 1.40
retrieving revision 1.41
diff -C2 -d -r1.40 -r1.41
*** NHibernate.Test-1.1.csproj	1 Sep 2004 00:10:28 -0000	1.40
--- NHibernate.Test-1.1.csproj	9 Sep 2004 21:20:17 -0000	1.41
***************
*** 487,490 ****
--- 487,495 ----
                  />
                  <File
+                     RelPath = "TypesTest\DateTimeTypeFixture.cs"
+                     SubType = "Code"
+                     BuildAction = "Compile"
+                 />
+                 <File
                      RelPath = "TypesTest\DecimalTypeFixture.cs"
                      SubType = "Code"

[Nhibernate-commit] nhibernate/src/NHibernate/Type DateTimeType.cs,1.7,1.8

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Type
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv10547

Modified Files:
	DateTimeType.cs 
Log Message:
Applied patch in http://jira.nhibernate.org:8080/browse/NH-116

Index: DateTimeType.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Type/DateTimeType.cs,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -d -r1.7 -r1.8
*** DateTimeType.cs	21 Aug 2004 16:37:32 -0000	1.7
--- DateTimeType.cs	9 Sep 2004 21:17:46 -0000	1.8
***************
*** 86,91 ****
  		public override object DeepCopyNotNull(object value) 
  		{
! 			DateTime old = (DateTime) value;
! 			return new DateTime(old.Year, old.Month, old.Day, old.Hour, old.Minute, old.Second);
  		}
  
--- 86,93 ----
  		public override object DeepCopyNotNull(object value) 
  		{
! 			// take advantage of the fact that unboxing with the cast
! 			// and then reboxing with the return as an object will
! 			// return a different box.  
! 			return (DateTime)value;
  		}
  

[Nhibernate-commit] unsubscribe

[Jerry S. <jer...@re...>]

unsubscribe

----- Original Message ----- 
From: <nhi...@li...>
To: <nhi...@li...>
Sent: Monday, September 06, 2004 1:29 PM
Subject: Nhibernate-commit digest, Vol 1 #181 - 1 msg


> Send Nhibernate-commit mailing list submissions to
> nhi...@li...
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://lists.sourceforge.net/lists/listinfo/nhibernate-commit
> or, via email, send a message with subject or body 'help' to
> nhi...@li...
>
> You can reach the person managing the list at
> nhi...@li...
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Nhibernate-commit digest..."
>
>
> Today's Topics:
>
>   1. unsubscribe (Jerry Shea)
>
> --__--__--
>
> Message: 1
> From: "Jerry Shea" <jer...@re...>
> To: <nhi...@li...>
> Date: Mon, 6 Sep 2004 08:22:26 +1000
> Organization: Renewtek
> Subject: [Nhibernate-commit] unsubscribe
> Reply-To: nhi...@li...
>
> unsubscribe
> ----- Original Message ----- 
> From: <nhi...@li...>
> To: <nhi...@li...>
> Sent: Saturday, September 04, 2004 1:40 PM
> Subject: Nhibernate-commit digest, Vol 1 #180 - 1 msg
>
>
>> Send Nhibernate-commit mailing list submissions to
>> nhi...@li...
>>
>> To subscribe or unsubscribe via the World Wide Web, visit
>> https://lists.sourceforge.net/lists/listinfo/nhibernate-commit
>> or, via email, send a message with subject or body 'help' to
>> nhi...@li...
>>
>> You can reach the person managing the list at
>> nhi...@li...
>>
>> When replying, please edit your Subject line so it is more specific
>> than "Re: Contents of Nhibernate-commit digest..."
>>
>>
>> Today's Topics:
>>
>>   1. nhibernate/src/NHibernate/Metadata IClassMetadata.cs,1.4,1.5 
>> (Michael
>> Doerfler)
>>
>> -- __--__-- 
>>
>> Message: 1
>> From: Michael Doerfler <mik...@us...>
>> To: nhi...@li...
>> Date: Fri, 03 Sep 2004 19:02:14 +0000
>> Subject: [Nhibernate-commit] nhibernate/src/NHibernate/Metadata
>> IClassMetadata.cs,1.4,1.5
>> Reply-To: nhi...@li...
>>
>> Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Metadata
>> In directory
>> sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv12534/NHibernate/Metadata
>>
>> Modified Files:
>> IClassMetadata.cs
>> Log Message:
>> Added VersionProperty since AbstractEntityPersister already had it.
>>
>> Index: IClassMetadata.cs
>> ===================================================================
>> RCS file:
>> /cvsroot/nhibernate/nhibernate/src/NHibernate/Metadata/IClassMetadata.cs,v
>> retrieving revision 1.4
>> retrieving revision 1.5
>> diff -C2 -d -r1.4 -r1.5
>> *** IClassMetadata.cs 30 Mar 2004 15:32:13 -0000 1.4
>> --- IClassMetadata.cs 3 Sep 2004 19:02:11 -0000 1.5
>> ***************
>> *** 105,108 ****
>> --- 105,113 ----
>>  object GetVersion(object obj);
>>
>> + /// <summary>
>> + /// Gets the index of the version property
>> + /// </summary>
>> + int VersionProperty { get; }
>> +
>>  }
>>  }
>>
>>
>>
>>
>> -- __--__-- 
>>
>> _______________________________________________
>> Nhibernate-commit mailing list
>> Nhi...@li...
>> https://lists.sourceforge.net/lists/listinfo/nhibernate-commit
>>
>>
>> End of Nhibernate-commit Digest
>>
>
>
>
>
>
> --__--__--
>
> _______________________________________________
> Nhibernate-commit mailing list
> Nhi...@li...
> https://lists.sourceforge.net/lists/listinfo/nhibernate-commit
>
>
> End of Nhibernate-commit Digest
> 

[Nhibernate-commit] unsubscribe

[Jerry S. <jer...@re...>]

unsubscribe
----- Original Message ----- 
From: <nhi...@li...>
To: <nhi...@li...>
Sent: Saturday, September 04, 2004 1:40 PM
Subject: Nhibernate-commit digest, Vol 1 #180 - 1 msg


> Send Nhibernate-commit mailing list submissions to
> nhi...@li...
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://lists.sourceforge.net/lists/listinfo/nhibernate-commit
> or, via email, send a message with subject or body 'help' to
> nhi...@li...
>
> You can reach the person managing the list at
> nhi...@li...
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Nhibernate-commit digest..."
>
>
> Today's Topics:
>
>   1. nhibernate/src/NHibernate/Metadata IClassMetadata.cs,1.4,1.5 (Michael 
> Doerfler)
>
> --__--__--
>
> Message: 1
> From: Michael Doerfler <mik...@us...>
> To: nhi...@li...
> Date: Fri, 03 Sep 2004 19:02:14 +0000
> Subject: [Nhibernate-commit] nhibernate/src/NHibernate/Metadata 
> IClassMetadata.cs,1.4,1.5
> Reply-To: nhi...@li...
>
> Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Metadata
> In directory 
> sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv12534/NHibernate/Metadata
>
> Modified Files:
> IClassMetadata.cs
> Log Message:
> Added VersionProperty since AbstractEntityPersister already had it.
>
> Index: IClassMetadata.cs
> ===================================================================
> RCS file: 
> /cvsroot/nhibernate/nhibernate/src/NHibernate/Metadata/IClassMetadata.cs,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -C2 -d -r1.4 -r1.5
> *** IClassMetadata.cs 30 Mar 2004 15:32:13 -0000 1.4
> --- IClassMetadata.cs 3 Sep 2004 19:02:11 -0000 1.5
> ***************
> *** 105,108 ****
> --- 105,113 ----
>  object GetVersion(object obj);
>
> + /// <summary>
> + /// Gets the index of the version property
> + /// </summary>
> + int VersionProperty { get; }
> +
>  }
>  }
>
>
>
>
> --__--__--
>
> _______________________________________________
> Nhibernate-commit mailing list
> Nhi...@li...
> https://lists.sourceforge.net/lists/listinfo/nhibernate-commit
>
>
> End of Nhibernate-commit Digest
> 

[Nhibernate-commit] nhibernate/src/NHibernate/Metadata IClassMetadata.cs,1.4,1.5

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Metadata
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv12534/NHibernate/Metadata

Modified Files:
	IClassMetadata.cs 
Log Message:
Added VersionProperty since AbstractEntityPersister already had it.

Index: IClassMetadata.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Metadata/IClassMetadata.cs,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -d -r1.4 -r1.5
*** IClassMetadata.cs	30 Mar 2004 15:32:13 -0000	1.4
--- IClassMetadata.cs	3 Sep 2004 19:02:11 -0000	1.5
***************
*** 105,108 ****
--- 105,113 ----
  		object GetVersion(object obj);
  
+ 		/// <summary>
+ 		/// Gets the index of the version property
+ 		/// </summary>
+ 		int VersionProperty { get; }
+ 
  	}
  }

[Nhibernate-commit] nhibernate/src/NHibernate.Test AssemblyInfo.cs,1.6,1.7

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate.Test
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv10204/src/NHibernate.Test

Modified Files:
	AssemblyInfo.cs 
Log Message:
Updated AssemblyInfo files from build 0.2.0.0 - the NHibernate.AssemblyInfo
had the AssemblyKeyFileAttribute commented out but it was built for 
distribution with it left in.

Index: AssemblyInfo.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate.Test/AssemblyInfo.cs,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -d -r1.6 -r1.7
*** AssemblyInfo.cs	23 Jul 2004 13:17:07 -0000	1.6
--- AssemblyInfo.cs	2 Sep 2004 16:53:56 -0000	1.7
***************
*** 2,27 ****
  using System.Runtime.CompilerServices;
  
  
! [assembly: AssemblyTitleAttribute("NHibernate.Test")]
! [assembly: AssemblyDescriptionAttribute("The Unit Test for NHibernate.")]
! [assembly: AssemblyCompanyAttribute("nhibernate.sf.net")]
  [assembly: AssemblyProductAttribute("NHibernate.Test")]
! [assembly: AssemblyCopyright("Licensed under LGPL.")]
! [assembly: AssemblyTrademark("")]
! [assembly: AssemblyCulture("")]		
! 
! //
! // Version information for an assembly consists of the following four values:
! //
! //      Major Version
! //      Minor Version 
! //      .NET Framwork Version
! //      Build Number
! //
! // You can specify all the values or you can default the Revision and Build Numbers 
! // by using the '*' as shown below:
! [assembly: AssemblyVersionAttribute("0.0.5000.6")]
! [assembly: AssemblyInformationalVersionAttribute("0.0")]
! [assembly: AssemblyFileVersionAttribute("0.0000.6")]
  
- [assembly: AssemblyDelaySignAttribute(false)]
\ No newline at end of file
--- 2,23 ----
  using System.Runtime.CompilerServices;
  
+ //------------------------------------------------------------------------------
+ // <autogenerated>
+ //     This code was generated by a tool.
+ //     Runtime Version: 1.1.4322.573
+ //
+ //     Changes to this file may cause incorrect behavior and will be lost if 
+ //     the code is regenerated.
+ // </autogenerated>
+ //------------------------------------------------------------------------------
  
! [assembly: AssemblyTitleAttribute("NHibernate.Test for Microsoft .NET Framework 1.1")]
! [assembly: AssemblyDescriptionAttribute("The Unit Tests for NHibernate.")]
! [assembly: AssemblyCompanyAttribute("nhibernate.sourceforge.net")]
  [assembly: AssemblyProductAttribute("NHibernate.Test")]
! [assembly: AssemblyCopyrightAttribute("Licensed under LGPL.")]
! [assembly: AssemblyVersionAttribute("0.2.0.0")]
! [assembly: AssemblyInformationalVersionAttribute("0.2")]
! [assembly: AssemblyFileVersionAttribute("0.2.0.0")]
! [assembly: AssemblyDelaySignAttribute(false)]
  

[Nhibernate-commit] nhibernate/src/NHibernate.Tasks AssemblyInfo.cs,1.1,1.2

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate.Tasks
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv10204/src/NHibernate.Tasks

Modified Files:
	AssemblyInfo.cs 
Log Message:
Updated AssemblyInfo files from build 0.2.0.0 - the NHibernate.AssemblyInfo
had the AssemblyKeyFileAttribute commented out but it was built for 
distribution with it left in.

Index: AssemblyInfo.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate.Tasks/AssemblyInfo.cs,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -d -r1.1 -r1.2
*** AssemblyInfo.cs	25 Jul 2004 11:41:34 -0000	1.1
--- AssemblyInfo.cs	2 Sep 2004 16:53:55 -0000	1.2
***************
*** 2,58 ****
  using System.Runtime.CompilerServices;
  
  //
! // General Information about an assembly is controlled through the following 
! // set of attributes. Change these attribute values to modify the information
! // associated with an assembly.
! //
! [assembly: AssemblyTitle("")]
! [assembly: AssemblyDescription("")]
! [assembly: AssemblyConfiguration("")]
! [assembly: AssemblyCompany("")]
! [assembly: AssemblyProduct("")]
! [assembly: AssemblyCopyright("")]
! [assembly: AssemblyTrademark("")]
! [assembly: AssemblyCulture("")]		
! 
! //
! // Version information for an assembly consists of the following four values:
! //
! //      Major Version
! //      Minor Version 
! //      Build Number
! //      Revision
! //
! // You can specify all the values or you can default the Revision and Build Numbers 
! // by using the '*' as shown below:
  
! [assembly: AssemblyVersion("1.0.*")]
  
- //
- // In order to sign your assembly you must specify a key to use. Refer to the 
- // Microsoft .NET Framework documentation for more information on assembly signing.
- //
- // Use the attributes below to control which key is used for signing. 
- //
- // Notes: 
- //   (*) If no key is specified, the assembly is not signed.
- //   (*) KeyName refers to a key that has been installed in the Crypto Service
- //       Provider (CSP) on your machine. KeyFile refers to a file which contains
- //       a key.
- //   (*) If the KeyFile and the KeyName values are both specified, the 
- //       following processing occurs:
- //       (1) If the KeyName can be found in the CSP, that key is used.
- //       (2) If the KeyName does not exist and the KeyFile does exist, the key 
- //           in the KeyFile is installed into the CSP and used.
- //   (*) In order to create a KeyFile, you can use the sn.exe (Strong Name) utility.
- //       When specifying the KeyFile, the location of the KeyFile should be
- //       relative to the project output directory which is
- //       %Project Directory%\obj\<configuration>. For example, if your KeyFile is
- //       located in the project directory, you would specify the AssemblyKeyFile 
- //       attribute as [assembly: AssemblyKeyFile("..\\..\\mykey.snk")]
- //   (*) Delay Signing is an advanced option - see the Microsoft .NET Framework
- //       documentation for more information on this.
- //
- [assembly: AssemblyDelaySign(false)]
- [assembly: AssemblyKeyFile("")]
- [assembly: AssemblyKeyName("")]
--- 2,23 ----
  using System.Runtime.CompilerServices;
  
+ //------------------------------------------------------------------------------
+ // <autogenerated>
+ //     This code was generated by a tool.
+ //     Runtime Version: 1.1.4322.573
  //
! //     Changes to this file may cause incorrect behavior and will be lost if 
! //     the code is regenerated.
! // </autogenerated>
! //------------------------------------------------------------------------------
  
! [assembly: AssemblyTitleAttribute("NHibernate.Tasks for Microsoft .NET Framework 1.1")]
! [assembly: AssemblyDescriptionAttribute("NAnt Tasks for NHibernate Tools.")]
! [assembly: AssemblyCompanyAttribute("nhibernate.sourceforge.net")]
! [assembly: AssemblyProductAttribute("NHibernate.Tasks")]
! [assembly: AssemblyCopyrightAttribute("Licensed under LGPL.")]
! [assembly: AssemblyVersionAttribute("0.2.0.0")]
! [assembly: AssemblyInformationalVersionAttribute("0.2")]
! [assembly: AssemblyFileVersionAttribute("0.2.0.0")]
! [assembly: AssemblyDelaySignAttribute(false)]
  

[Nhibernate-commit] nhibernate/src/NHibernate.DomainModel AssemblyInfo.cs,1.6,1.7

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate.DomainModel
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv10204/src/NHibernate.DomainModel

Modified Files:
	AssemblyInfo.cs 
Log Message:
Updated AssemblyInfo files from build 0.2.0.0 - the NHibernate.AssemblyInfo
had the AssemblyKeyFileAttribute commented out but it was built for 
distribution with it left in.

Index: AssemblyInfo.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate.DomainModel/AssemblyInfo.cs,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -d -r1.6 -r1.7
*** AssemblyInfo.cs	23 Jul 2004 13:17:07 -0000	1.6
--- AssemblyInfo.cs	2 Sep 2004 16:53:54 -0000	1.7
***************
*** 2,27 ****
  using System.Runtime.CompilerServices;
  
! 
! [assembly: AssemblyTitleAttribute("NHibernate.DomainModel")]
! [assembly: AssemblyDescriptionAttribute("The business classes used by the Unit Tests.")]
! [assembly: AssemblyCompanyAttribute("nhibernate.sf.net")]
! [assembly: AssemblyProductAttribute("NHibernate.DomainModel")]
! [assembly: AssemblyCopyright("Licensed under LGPL.")]
! [assembly: AssemblyTrademark("")]
! [assembly: AssemblyCulture("")]		
! 
! //
! // Version information for an assembly consists of the following four values:
! //
! //      Major Version
! //      Minor Version 
! //      .NET Framwork Version
! //      Build Number
  //
! // You can specify all the values or you can default the Revision and Build Numbers 
! // by using the '*' as shown below:
! [assembly: AssemblyVersionAttribute("0.0.5000.6")]
! [assembly: AssemblyInformationalVersionAttribute("0.0")]
! [assembly: AssemblyFileVersionAttribute("0.0000.6")]
  
  [assembly: AssemblyDelaySignAttribute(false)]
--- 2,23 ----
  using System.Runtime.CompilerServices;
  
! //------------------------------------------------------------------------------
! // <autogenerated>
! //     This code was generated by a tool.
! //     Runtime Version: 1.1.4322.573
  //
! //     Changes to this file may cause incorrect behavior and will be lost if 
! //     the code is regenerated.
! // </autogenerated>
! //------------------------------------------------------------------------------
  
+ [assembly: AssemblyTitleAttribute("NHibernate.DomainModel for Microsoft .NET Framework 1.1")]
+ [assembly: AssemblyDescriptionAttribute("The Domain Model used by the Unit Tests.")]
+ [assembly: AssemblyCompanyAttribute("nhibernate.sourceforge.net")]
+ [assembly: AssemblyProductAttribute("NHibernate.DomainModel")]
+ [assembly: AssemblyCopyrightAttribute("Licensed under LGPL.")]
+ [assembly: AssemblyVersionAttribute("0.2.0.0")]
+ [assembly: AssemblyInformationalVersionAttribute("0.2")]
+ [assembly: AssemblyFileVersionAttribute("0.2.0.0")]
  [assembly: AssemblyDelaySignAttribute(false)]
+ 

[Nhibernate-commit] nhibernate/src/NHibernate AssemblyInfo.cs,1.7,1.8

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv10204/src/NHibernate

Modified Files:
	AssemblyInfo.cs 
Log Message:
Updated AssemblyInfo files from build 0.2.0.0 - the NHibernate.AssemblyInfo
had the AssemblyKeyFileAttribute commented out but it was built for 
distribution with it left in.

Index: AssemblyInfo.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/AssemblyInfo.cs,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -d -r1.7 -r1.8
*** AssemblyInfo.cs	23 Jul 2004 13:17:06 -0000	1.7
--- AssemblyInfo.cs	2 Sep 2004 16:53:53 -0000	1.8
***************
*** 2,31 ****
  using System.Runtime.CompilerServices;
  
  
! [assembly: AssemblyTitleAttribute("NHibernate")]
  [assembly: AssemblyDescriptionAttribute("An object persistence library for relational databases.")]
! [assembly: AssemblyCompanyAttribute("nhibernate.sf.net")]
  [assembly: AssemblyProductAttribute("NHibernate")]
! [assembly: AssemblyCopyright("Licensed under LGPL.")]
! [assembly: AssemblyTrademark("")]
! [assembly: AssemblyCulture("")]		
! 
! //
! // Version information for an assembly consists of the following four values:
! //
! //      Major Version
! //      Minor Version 
! //      .NET Framwork Version
! //      Build Number
! //
! // You can specify all the values or you can default the Revision and Build Numbers 
! // by using the '*' as shown below:
! [assembly: AssemblyVersionAttribute("0.0.5000.6")]
! [assembly: AssemblyInformationalVersionAttribute("0.0")]
! [assembly: AssemblyFileVersionAttribute("0.0000.6")]
! 
! [assembly: AssemblyDelaySignAttribute(false)]
! //[assembly: AssemblyKeyFile("..\\..\\NHibernate.snk")]
! 
! 
  
--- 2,23 ----
  using System.Runtime.CompilerServices;
  
+ //------------------------------------------------------------------------------
+ // <autogenerated>
+ //     This code was generated by a tool.
+ //     Runtime Version: 1.1.4322.573
+ //
+ //     Changes to this file may cause incorrect behavior and will be lost if 
+ //     the code is regenerated.
+ // </autogenerated>
+ //------------------------------------------------------------------------------
  
! [assembly: AssemblyTitleAttribute("NHibernate for Microsoft .NET Framework 1.1")]
  [assembly: AssemblyDescriptionAttribute("An object persistence library for relational databases.")]
! [assembly: AssemblyCompanyAttribute("nhibernate.sourceforge.net")]
  [assembly: AssemblyProductAttribute("NHibernate")]
! [assembly: AssemblyCopyrightAttribute("Licensed under LGPL.")]
! [assembly: AssemblyVersionAttribute("0.2.0.0")]
! [assembly: AssemblyInformationalVersionAttribute("0.2")]
! [assembly: AssemblyFileVersionAttribute("0.2.0.0")]
! //[assembly: AssemblyKeyFileAttribute("..\\NHibernate.snk")]
  

[Nhibernate-commit] nhibernate/src/NHibernate.Tool.hbm2net AssemblyInfo.cs,1.1,1.2

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate.Tool.hbm2net
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv10204/src/NHibernate.Tool.hbm2net

Modified Files:
	AssemblyInfo.cs 
Log Message:
Updated AssemblyInfo files from build 0.2.0.0 - the NHibernate.AssemblyInfo
had the AssemblyKeyFileAttribute commented out but it was built for 
distribution with it left in.

Index: AssemblyInfo.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate.Tool.hbm2net/AssemblyInfo.cs,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -d -r1.1 -r1.2
*** AssemblyInfo.cs	25 Jul 2004 11:41:03 -0000	1.1
--- AssemblyInfo.cs	2 Sep 2004 16:53:56 -0000	1.2
***************
*** 2,32 ****
  using System.Runtime.CompilerServices;
  
! 
! [assembly: AssemblyTitleAttribute("NHibernate.Tool.hbm2net")]
! [assembly: AssemblyDescriptionAttribute("Tool to Generate Classes from hbm.xml files.")]
! [assembly: AssemblyCompanyAttribute("nhibernate.sf.net")]
! [assembly: AssemblyProductAttribute("NHibernate")]
! [assembly: AssemblyCopyright("Licensed under LGPL.")]
! [assembly: AssemblyTrademark("")]
! [assembly: AssemblyCulture("")]		
! 
! //
! // Version information for an assembly consists of the following four values:
! //
! //      Major Version
! //      Minor Version 
! //      .NET Framwork Version
! //      Build Number
  //
! // You can specify all the values or you can default the Revision and Build Numbers 
! // by using the '*' as shown below:
! [assembly: AssemblyVersionAttribute("0.0.5000.6")]
! [assembly: AssemblyInformationalVersionAttribute("0.0")]
! [assembly: AssemblyFileVersionAttribute("0.0000.6")]
  
  [assembly: AssemblyDelaySignAttribute(false)]
- //[assembly: AssemblyKeyFile("..\\..\\NHibernate.snk")]
- 
- 
- 
  
--- 2,23 ----
  using System.Runtime.CompilerServices;
  
! //------------------------------------------------------------------------------
! // <autogenerated>
! //     This code was generated by a tool.
! //     Runtime Version: 1.1.4322.573
  //
! //     Changes to this file may cause incorrect behavior and will be lost if 
! //     the code is regenerated.
! // </autogenerated>
! //------------------------------------------------------------------------------
  
+ [assembly: AssemblyTitleAttribute("NHibernate.Tool.hbm2net for Microsoft .NET Framework 1.1")]
+ [assembly: AssemblyDescriptionAttribute("Tool to Generate Classes from hbm.xml files.")]
+ [assembly: AssemblyCompanyAttribute("nhibernate.sourceforge.net")]
+ [assembly: AssemblyProductAttribute("NHibernate.Tool.hbm2net")]
+ [assembly: AssemblyCopyrightAttribute("Licensed under LGPL.")]
+ [assembly: AssemblyVersionAttribute("0.2.0.0")]
+ [assembly: AssemblyInformationalVersionAttribute("0.2")]
+ [assembly: AssemblyFileVersionAttribute("0.2.0.0")]
  [assembly: AssemblyDelaySignAttribute(false)]
  

[Nhibernate-commit] nhibernate NHibernateSolution.build,1.10,1.11

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26183/nhibernate

Modified Files:
	NHibernateSolution.build 
Log Message:
Prep for build 0.2.0.0

Index: NHibernateSolution.build
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/NHibernateSolution.build,v
retrieving revision 1.10
retrieving revision 1.11
diff -C2 -d -r1.10 -r1.11
*** NHibernateSolution.build	11 Aug 2004 11:46:33 -0000	1.10
--- NHibernateSolution.build	2 Sep 2004 15:41:30 -0000	1.11
***************
*** 19,23 ****
  	<property name="project.name" value="nhibernate" />
  	<property name="project.version.major" value="0" />
! 	<property name="project.version.minor" value="1" />
  	<property name="project.version.build" value="0" />
  	<property name="project.version.revision" value="0" />
--- 19,23 ----
  	<property name="project.name" value="nhibernate" />
  	<property name="project.version.major" value="0" />
! 	<property name="project.version.minor" value="2" />
  	<property name="project.version.build" value="0" />
  	<property name="project.version.revision" value="0" />

[Nhibernate-commit] nhibernate releasenotes.txt,1.11,1.12

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24032

Modified Files:
	releasenotes.txt 
Log Message:
Prep for build 0.2.0.0

Index: releasenotes.txt
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/releasenotes.txt,v
retrieving revision 1.11
retrieving revision 1.12
diff -C2 -d -r1.11 -r1.12
*** releasenotes.txt	30 Aug 2004 18:32:04 -0000	1.11
--- releasenotes.txt	2 Sep 2004 15:30:10 -0000	1.12
***************
*** 1,9 ****
! PreAlpha Build 0.2.0.0
  ======================== 
! - Removed support for <dynabean> mapping since it doesn't exist in .net
! - Fixed bug in nhibernate.build file when not signing NHibernate.dll
  - Fixed bug with Hql and SetParameter() where there were 2 parameters with same name.
! - Fixed bug with Hql and "IN (:namedParam)"
! - Fixed bug with Hql and multi column IType
  - Fixed bug with NullReferenceException and TypeType class.
  - ISession.Filter() is now working.
--- 1,10 ----
! Alpha Build 0.2.0.0
  ======================== 
! - Removed support for <dynabean> mapping since it doesn't exist in .net.
! - Fixed bug in nhibernate.build file when not signing NHibernate.dll.
  - Fixed bug with Hql and SetParameter() where there were 2 parameters with same name.
! - Fixed bug with Hql and "IN (:namedParam)".
! - Fixed bug with Hql and multi column IType.
! - Fixed bug with Hql and scalar queries 
  - Fixed bug with NullReferenceException and TypeType class.
  - ISession.Filter() is now working.
***************
*** 11,20 ****
  - Refactored Hql to use a SqlString instead of string containing sql.
  - Dialect has had public API changed because of Sql to SqlCommand refactoring.
! - IPreparer has had methods removed from public API
  - type="System.Object" no longer matches to SerializableType - instead it matches to ObjectType.  Use type="Serializable" instead.
  - Added "access" attribute for NHibernate to get to fields and properties with no setters.  See NHibernate.Property.PropertyAccessorFactory for all valid value types and how to plug in your own implementation of IPropertyAccessor.
  - Added Types to read BLOB/CLOB columns to a byte[]/string Property.
  - TypeFactory was modified to allow the attribute "type" to be the Assembly Qualified Name, Full Name, NHibernate IType.Name, or Hibernate name to help with porting hibernate hbm.xml files and Net2Hbm that John is writing.
! - Fixed bug with Hql and scalar queries 
  
  PreAlpha Build 0.1.0.0
--- 12,25 ----
  - Refactored Hql to use a SqlString instead of string containing sql.
  - Dialect has had public API changed because of Sql to SqlCommand refactoring.
! - IPreparer has had methods removed from public API.
  - type="System.Object" no longer matches to SerializableType - instead it matches to ObjectType.  Use type="Serializable" instead.
  - Added "access" attribute for NHibernate to get to fields and properties with no setters.  See NHibernate.Property.PropertyAccessorFactory for all valid value types and how to plug in your own implementation of IPropertyAccessor.
  - Added Types to read BLOB/CLOB columns to a byte[]/string Property.
+ - Modified Expression.Sql() to require use of SqlString if parameters are used.
  - TypeFactory was modified to allow the attribute "type" to be the Assembly Qualified Name, Full Name, NHibernate IType.Name, or Hibernate name to help with porting hibernate hbm.xml files and Net2Hbm that John is writing.
! - hibernate.connection.isolation configuration now affects the IDbTransaction's IsolationLevel, it is parsed as the name value of the IsolationLevel enum - "Chaos", "ReadCommitted", "ReadUncommitted", "RepeatableRead", "Serializable", and "Unspecified".
! - ICriteria.SetMaxResults() is now working.
! - IQuery.SetMaxResults().Enumerable() is now working.
! - Modifed Test Fixtures to help isolate problems caused by DataProviders.
  
  PreAlpha Build 0.1.0.0

[Nhibernate-commit] nhibernate/src/NHibernate/Loader Loader.cs,1.33,1.34

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Loader
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20931/src/NHibernate/Loader

Modified Files:
	Loader.cs 
Log Message:
Removed obsolete methods and renamed to be more .net

Index: Loader.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Loader/Loader.cs,v
retrieving revision 1.33
retrieving revision 1.34
diff -C2 -d -r1.33 -r1.34
*** Loader.cs	2 Sep 2004 13:04:58 -0000	1.33
--- Loader.cs	2 Sep 2004 15:13:35 -0000	1.34
***************
*** 230,234 ****
  				finally 
  				{
! 					ClosePreparedStatement(st, rs, session);
  				}
  			}
--- 230,234 ----
  				finally 
  				{
! 					ClosePreparedCommand(st, rs, session);
  				}
  			}
***************
*** 559,578 ****
  		}
  
- 		[Obsolete("Use PrepareCommand instead")]
- 		protected virtual IDbCommand PrepareQueryStatement(string sql, object[] values, IType[] types, IDictionary namedParams, RowSelection selection, bool scroll, ISessionImplementor session) 
- 		{
- 			// TODO: this is just a hack because I moved it to Hql.QueryTranslator.  It will be removed
- 			// once everything is converted to SqlString instead of strings holding sql...
- 			return null;
- 		}
- 
- 		[Obsolete("Use PrepareCommand instead")]
- 		protected virtual IDbCommand PrepareQueryStatement(SqlString sql, object[] values, IType[] types, IDictionary namedParams, RowSelection selection, bool scroll, ISessionImplementor session) 
- 		{
- 			// TODO: this is just a hack because I moved it to Hql.QueryTranslator.  It will be removed
- 			// once everything is converted to SqlString instead of strings holding sql...
- 			return null;
- 		}
- 
  		/// <summary>
  		/// Creates an IDbCommand object and populates it with the values necessary to execute it against the 
--- 559,562 ----
***************
*** 639,643 ****
  			catch(Exception sqle) 
  			{
! 				ClosePreparedStatement(command, null, session);
  				throw sqle;
  			}
--- 623,627 ----
  			catch(Exception sqle) 
  			{
! 				ClosePreparedCommand(command, null, session);
  				throw sqle;
  			}
***************
*** 716,720 ****
  			catch (Exception sqle) 
  			{
! 				ClosePreparedStatement(st, rs, session);
  				throw sqle;
  			}
--- 700,704 ----
  			catch (Exception sqle) 
  			{
! 				ClosePreparedCommand(st, rs, session);
  				throw sqle;
  			}
***************
*** 722,727 ****
  
  		
! 		//TODO: H2.0.3 - synch with CloseQueryStatement in the Batcher also
! 		protected void ClosePreparedStatement(IDbCommand st, IDataReader reader, ISessionImplementor session) 
  		{
  			session.Batcher.CloseQueryCommand(st, reader);
--- 706,716 ----
  
  		
! 		/// <summary>
! 		/// Cleans up the resources used by this Loader.
! 		/// </summary>
! 		/// <param name="st">The <see cref="IDbCommand"/> to close.</param>
! 		/// <param name="reader">The <see cref="IDataReader"/> to close.</param>
! 		/// <param name="session">The <see cref="ISession"/> this Loader is using.</param>
! 		protected void ClosePreparedCommand(IDbCommand st, IDataReader reader, ISessionImplementor session) 
  		{
  			session.Batcher.CloseQueryCommand(st, reader);
***************
*** 731,737 ****
  		/// Bind named parameters to the <c>IDbCommand</c>
  		/// </summary>
! 		/// <param name="st"></param>
! 		/// <param name="namedParams"></param>
! 		/// <param name="session"></param>
  		/// <remarks>
  		/// This has an empty implementation on this superclass and should be implemented by
--- 720,726 ----
  		/// Bind named parameters to the <c>IDbCommand</c>
  		/// </summary>
! 		/// <param name="st">The <see cref="IDbCommand"/> that contains the parameters.</param>
! 		/// <param name="namedParams">The named parameters (key) and the values to set.</param>
! 		/// <param name="session">The <see cref="ISession"/> this Loader is using.</param>
  		/// <remarks>
  		/// This has an empty implementation on this superclass and should be implemented by

[Nhibernate-commit] nhibernate/src/NHibernate.DomainModel/NHSpecific BasicClass.cs,1.4,1.5

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate.DomainModel/NHSpecific
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20749/src/NHibernate.DomainModel/NHSpecific

Modified Files:
	BasicClass.cs 
Log Message:
removed an unused field

Index: BasicClass.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate.DomainModel/NHSpecific/BasicClass.cs,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -d -r1.4 -r1.5
*** BasicClass.cs	1 Sep 2004 00:10:12 -0000	1.4
--- BasicClass.cs	2 Sep 2004 15:12:32 -0000	1.5
***************
*** 12,16 ****
  		private int _id;
  
- 		private byte[] _binaryProperty;
  		private bool _booleanProperty;
  		private byte _byteProperty;
--- 12,15 ----

[Nhibernate-commit] nhibernate/src/NHibernate/Persister AbstractEntityPersister.cs,1.23,1.24 IClassPersister.cs,1.6,1.7

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Persister
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20359/src/NHibernate/Persister

Modified Files:
	AbstractEntityPersister.cs IClassPersister.cs 
Log Message:
Added some comments and moved an abstract method to be with the other
abstract methods.

Index: IClassPersister.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Persister/IClassPersister.cs,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -d -r1.6 -r1.7
*** IClassPersister.cs	23 Jun 2004 21:08:20 -0000	1.6
--- IClassPersister.cs	2 Sep 2004 15:11:01 -0000	1.7
***************
*** 154,161 ****
  
  		/// <summary>
! 		/// 
  		/// </summary>
! 		/// <returns></returns>
! 		//TODO: Added in H2.0.3 - what exactly does it do...
  		bool HasIdentifierPropertyOrEmbeddedCompositeIdentifier{get;}
  
--- 154,161 ----
  
  		/// <summary>
! 		/// Gets if the Type has a Property for the &lt;id&gt; or uses a &lt;composite-id&gt;
! 		/// to store the id.
  		/// </summary>
! 		/// <returns><c>true if there is a Identifier Property or Composite Identifier.</c></returns>
  		bool HasIdentifierPropertyOrEmbeddedCompositeIdentifier{get;}
  
***************
*** 170,175 ****
  		/// Set the identifier of an instance (or do nothing if no identifier property)
  		/// </summary>
! 		/// <param name="obj"></param>
! 		/// <param name="id"></param>
  		void SetIdentifier(object obj, object id);
  
--- 170,175 ----
  		/// Set the identifier of an instance (or do nothing if no identifier property)
  		/// </summary>
! 		/// <param name="obj">The object to set the Id property on.</param>
! 		/// <param name="id">The value to set the Id property to.</param>
  		void SetIdentifier(object obj, object id);
  
***************
*** 282,287 ****
--- 282,301 ----
  		string[] PropertyNames { get; }
  
+ 		/// <summary>
+ 		/// Gets if the Property is updatable
+ 		/// </summary>
+ 		/// <value><c>true</c> if the Property's value can be updated.</value>
+ 		/// <remarks>
+ 		/// This is for formula columns and if the user sets the update attribute on the &lt;property&gt; element.
+ 		/// </remarks>
  		bool[] PropertyUpdateability { get; }
  
+ 		/// <summary>
+ 		/// Gets if the Property is insertable.
+ 		/// </summary>
+ 		/// <value><c>true</c> if the Property's value can be inserted.</value>
+ 		/// <remarks>
+ 		/// This is for formula columns and if the user sets the insert attribute on the &lt;property&gt; element.
+ 		/// </remarks>
  		bool[] PropertyInsertability { get; }
  

Index: AbstractEntityPersister.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Persister/AbstractEntityPersister.cs,v
retrieving revision 1.23
retrieving revision 1.24
diff -C2 -d -r1.23 -r1.24
*** AbstractEntityPersister.cs	28 Aug 2004 17:20:17 -0000	1.23
--- AbstractEntityPersister.cs	2 Sep 2004 15:11:01 -0000	1.24
***************
*** 117,123 ****
  		}
  
! 		//TODO: not in same spot in h2.0.3
! 		public abstract string[] ToColumns(string name, string path) ;
! 
  		public virtual IType GetPropertyType(string path) 
  		{
--- 117,121 ----
  		}
  
! 		
  		public virtual IType GetPropertyType(string path) 
  		{
***************
*** 829,832 ****
--- 827,831 ----
  		public abstract string TableName { get; }
  		public abstract string[] ToColumns(string name, int i);
+ 		public abstract string[] ToColumns(string name, string path) ;
  		public abstract SqlString WhereJoinFragment(string alias, bool innerJoin, bool includeSubclasses);
  		public abstract string DiscriminatorColumnName { get; }

[Nhibernate-commit] nhibernate/src/NHibernate/Collection List.cs,1.12,1.13 Map.cs,1.12,1.13 PersistentCollection.cs,1.12,1.13 Set.cs,1.11,1.12 SortedSet.cs,1.6,1.7

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Collection
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv19639/src/NHibernate/Collection

Modified Files:
	List.cs Map.cs PersistentCollection.cs Set.cs SortedSet.cs 
Log Message:
Removed collection proxies that did not have any use in .net since
collection interfaces are diff than java collection interfaces

Index: SortedSet.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Collection/SortedSet.cs,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -d -r1.6 -r1.7
*** SortedSet.cs	9 Aug 2004 03:11:45 -0000	1.6
--- SortedSet.cs	2 Sep 2004 15:07:19 -0000	1.7
***************
*** 83,91 ****
  			initialized = true;
  		}
- 
- 
- 		//TODO: H2.0.3 has an internal class SubSetProxy that inherits from another
- 		// undefined class PersistentCollection.SetProxy
- 
  	}
  }
--- 83,86 ----

Index: Map.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Collection/Map.cs,v
retrieving revision 1.12
retrieving revision 1.13
diff -C2 -d -r1.12 -r1.13
*** Map.cs	9 Aug 2004 18:33:11 -0000	1.12
--- Map.cs	2 Sep 2004 15:07:19 -0000	1.13
***************
*** 121,125 ****
  			{ 
  				Read();
! 				return new CollectionProxy(this, map.Keys);
  			}
  		}
--- 121,125 ----
  			{ 
  				Read();
! 				return map.Keys; 
  			}
  		}
***************
*** 129,133 ****
  			{  
  				Read();
! 				return new CollectionProxy(this, map.Values);
  			}
  			
--- 129,133 ----
  			{  
  				Read();
! 				return map.Values;
  			}
  			

Index: PersistentCollection.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Collection/PersistentCollection.cs,v
retrieving revision 1.12
retrieving revision 1.13
diff -C2 -d -r1.12 -r1.13
*** PersistentCollection.cs	9 Aug 2004 03:11:45 -0000	1.12
--- PersistentCollection.cs	2 Sep 2004 15:07:19 -0000	1.13
***************
*** 318,323 ****
  		}
  
- 		// In H2.0.3 all of this is underneat the ProxyClasses
- 		
  		public virtual ICollectionSnapshot CollectionSnapshot 
  		{
--- 318,321 ----
***************
*** 359,709 ****
  
  		
! 		
! 
! 		//TODO: H2.0.3 has an IteratorProxy implement Iterator
! 		//TODO: H2.0.3 has a ListIteratorProxy implements ListIterator
! 		//TODO: H2.0.3 has an SetProxy implements Set
! 
! 		internal class CollectionProxy : ICollection
! 		{
! 			protected PersistentCollection pc;
! 			private ICollection collection;
! 
! 			public CollectionProxy(PersistentCollection pc, ICollection collection) 
! 			{
! 				this.pc = pc;
! 				this.collection = collection;
! 			}
! 
! 			#region ICollection Members
! 
! 			public bool IsSynchronized
! 			{
! 				get{ return false; }
! 			}
! 
! 			public int Count
! 			{
! 				get{return collection.Count;}
! 			}
! 
! 			public void CopyTo(Array array, int index)
! 			{
! 				collection.CopyTo(array, index);
! 			}
! 
! 			public object SyncRoot
! 			{
! 				get{return null;}
! 			}
! 
! 			#endregion
! 
! 			#region IEnumerable Members
! 
! 			public IEnumerator GetEnumerator()
! 			{
! 				return new EnumeratorProxy(collection.GetEnumerator());
! 			}
! 
! 			#endregion
! 		}
! 
! 		
! 		internal sealed class ListProxy : CollectionProxy, IList 
! 		{
! 			private IList list;
! 			
! 			public ListProxy(PersistentCollection pc, IList list) : base(pc, list)
! 			{
! 				this.list = list;
! 			}
! 
! 			#region IList Members
! 
! 			public bool IsReadOnly
! 			{
! 				get { return list.IsReadOnly; }
! 			}
! 
! 			public object this[int index]
! 			{
! 				get { return list[index];}
! 				set 
! 				{ 
! 					pc.Write();
! 					list[index] = value;
! 				}
! 			}
! 
! 			public void RemoveAt(int index)
! 			{
! 				pc.Write();
! 				list.RemoveAt(index);
! 			}
! 
! 			public void Insert(int index, object value)
! 			{
! 				pc.Write();
! 				list.Insert(index, value);
! 			}
! 
! 			public void Remove(object value)
! 			{
! 				pc.Write();
! 				list.Remove(value);
! 			}
! 
! 			public bool Contains(object value)
! 			{
! 				return list.Contains(value);
! 			}
! 
! 			public void Clear()
! 			{
! 				pc.Write();
! 				list.Clear();
! 			}
! 
! 			public int IndexOf(object value)
! 			{
! 				return list.IndexOf(value);
! 			}
! 
! 			public int Add(object value)
! 			{
! 				pc.Write();
! 				return list.Add(value);
! 			}
! 
! 			public bool IsFixedSize
! 			{
! 				get	{ return list.IsFixedSize;}
! 			}
! 
! 			#endregion
! 
! 		}
  
  		
- 		internal sealed class DictionaryProxy : IDictionary
- 		{
- 			private PersistentCollection pc;
- 			private IDictionary dictionary;
- 
- 			public DictionaryProxy(PersistentCollection pc, IDictionary dictionary)
- 			{
- 				this.pc = pc;
- 				this.dictionary = dictionary;
- 			}
- 
- 			#region IDictionary Members
- 
- 			public bool IsReadOnly
- 			{
- 				get
- 				{
- 					// TODO:  Add DictionaryProxy.IsReadOnly getter implementation
- 					return false;
- 				}
- 			}
- 
- 			public IDictionaryEnumerator GetEnumerator()
- 			{
- 				// TODO:  Add DictionaryProxy.GetEnumerator implementation
- 				return null;
- 			}
- 
- 			public object this[object key]
- 			{
- 				get
- 				{
- 					// TODO:  Add DictionaryProxy.this getter implementation
- 					return null;
- 				}
- 				set
- 				{
- 					// TODO:  Add DictionaryProxy.this setter implementation
- 				}
- 			}
- 
- 			public void Remove(object key)
- 			{
- 				// TODO:  Add DictionaryProxy.Remove implementation
- 			}
- 
- 			public bool Contains(object key)
- 			{
- 				// TODO:  Add DictionaryProxy.Contains implementation
- 				return false;
- 			}
- 
- 			public void Clear()
- 			{
- 				// TODO:  Add DictionaryProxy.Clear implementation
- 			}
- 
- 			public ICollection Values
- 			{
- 				get
- 				{
- 					// TODO:  Add DictionaryProxy.Values getter implementation
- 					return null;
- 				}
- 			}
  
! 			public void Add(object key, object value)
! 			{
! 				// TODO:  Add DictionaryProxy.Add implementation
! 			}
! 
! 			public ICollection Keys
! 			{
! 				get
! 				{
! 					// TODO:  Add DictionaryProxy.Keys getter implementation
! 					return null;
! 				}
! 			}
! 
! 			public bool IsFixedSize
! 			{
! 				get
! 				{
! 					// TODO:  Add DictionaryProxy.IsFixedSize getter implementation
! 					return false;
! 				}
! 			}
! 
! 			#endregion
! 
! 			#region ICollection Members
! 
! 			public bool IsSynchronized
! 			{
! 				get{ return false; }
! 			}
! 
! 			public int Count
! 			{
! 				get{return dictionary.Count;}
! 			}
! 
! 			public void CopyTo(Array array, int index)
! 			{
! 				dictionary.CopyTo(array, index);
! 			}
! 
! 			public object SyncRoot
! 			{
! 				get{return null;}
! 			}
! 
! 			#endregion
! 
! 			#region IEnumerable Members
! 
! 			IEnumerator System.Collections.IEnumerable.GetEnumerator()
! 			{
! 				// TODO:  Add DictionaryProxy.System.Collections.IEnumerable.GetEnumerator implementation
! 				return null;
! 			}
! 
! 			#endregion
! 		}
! 
! 		/// <summary>
! 		/// 
! 		/// </summary>
! 		/// <remarks>
! 		/// I don't know how needed this is because the java.util.Iterator provides methods
! 		/// to modify the underlying object - such as remove() and set(Object).  In .NET
! 		/// the IEnumerator does not provide any means to modify the underlying collection 
! 		/// while using the IEnumerator interface.
! 		/// </remarks>
! 		internal sealed class EnumeratorProxy : IEnumerator 
! 		{
! 			private IEnumerator en;
! 
! 			public EnumeratorProxy(IEnumerator en) 
! 			{
! 				this.en = en;
! 			}
! 
! 			public object Current 
! 			{
! 				get { return en.Current; }
! 			}
! 
! 			public bool MoveNext() 
! 			{
! 				return en.MoveNext();
! 			}
! 
! 			public void Reset() 
! 			{
! 				en.Reset();
! 			}
! 		}
! 
! 		/// <summary>
! 		/// 
! 		/// </summary>
! 		/// <remarks>
! 		/// I don't know how needed this is because the java.util.Iterator provides methods
! 		/// to modify the underlying object - such as remove() and set(Object).  In .NET
! 		/// the IEnumerator does not provide any means to modify the underlying collection 
! 		/// while using the IEnumerator interface.
! 		/// </remarks>
! 		internal sealed class DictionaryEnumeratorProxy : IDictionaryEnumerator
! 		{
! 			private IDictionaryEnumerator en;
! 			
! 			public DictionaryEnumeratorProxy(IDictionaryEnumerator en) 
! 			{
! 				this.en = en;
! 			}
! 
! 			#region IDictionaryEnumerator Members
! 
! 			public object Key
! 			{
! 				get{ return en.Key; }
! 			}
! 
! 			public object Value
! 			{
! 				get	{ return en.Value; }
! 			}
! 
! 			public DictionaryEntry Entry
! 			{
! 				get	{ return new DictionaryEntry(Key, Value); }
! 			}
! 
! 			#endregion
! 
! 			#region IEnumerator Members
! 
! 			public void Reset()
! 			{
! 				en.Reset();
! 			}
! 
! 			public object Current
! 			{
! 				get	{ return en.Current; }
! 			}
! 
! 			public bool MoveNext()
! 			{
! 				return en.MoveNext();
! 			}
! 
! 			#endregion
! 
! 		}
! 
! 		
  
  	}
--- 357,371 ----
  
  		
! 		#region - Hibernate Collection Proxy Classes
  
+ 		/*
+ 		 * These were needed by Hibernate because Java's collections provide methods
+ 		 * to get sublists, modify a collection with an iterator - all things that 
+ 		 * Hibernate needs to be made aware of.  If .net changes their collection interfaces
+ 		 * then we can readd these back in.
+ 		 */ 
  		
  
! 		#endregion
  
  	}

Index: Set.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Collection/Set.cs,v
retrieving revision 1.11
retrieving revision 1.12
diff -C2 -d -r1.11 -r1.12
*** Set.cs	9 Aug 2004 18:33:11 -0000	1.11
--- Set.cs	2 Sep 2004 15:07:19 -0000	1.12
***************
*** 159,163 ****
  			{ 
  				Read();
! 				return new CollectionProxy(this, map.Keys); 
  			}
  		}
--- 159,163 ----
  			{ 
  				Read();
! 				return map.Keys;
  			}
  		}
***************
*** 171,175 ****
  			{ 
  				Read();
! 				return new CollectionProxy(this, map.Values);
  			}
  		}
--- 171,175 ----
  			{ 
  				Read();
! 				return map.Values;
  			}
  		}

Index: List.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Collection/List.cs,v
retrieving revision 1.12
retrieving revision 1.13
diff -C2 -d -r1.12 -r1.13
*** List.cs	9 Aug 2004 18:33:11 -0000	1.12
--- List.cs	2 Sep 2004 15:07:19 -0000	1.13
***************
*** 98,102 ****
  		public override IEnumerator GetEnumerator() {
  			Read();
! 			return new EnumeratorProxy(list.GetEnumerator());
  		}
  
--- 98,102 ----
  		public override IEnumerator GetEnumerator() {
  			Read();
! 			return list.GetEnumerator();
  		}