[Nhibernate-commit] nhibernate/src/NHibernate/Dialect Dialect.cs,1.32,1.33 MsSql2000Dialect.cs,1.12,1.13 MySQLDialect.cs,1.15,1.16 Oracle9Dialect.cs,1.8,1.9 PostgreSQLDialect.cs,1.5,1.6 SybaseDialect.cs,1.8,1.9

[Michael D. <mik...@us...>]

Update of /cvsroot/nhibernate/nhibernate/src/NHibernate/Dialect
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29415/src/NHibernate/Dialect

Modified Files:
	Dialect.cs MsSql2000Dialect.cs MySQLDialect.cs 
	Oracle9Dialect.cs PostgreSQLDialect.cs SybaseDialect.cs 
Log Message:
Drivers are now setting the default properties for OuterJoins.  This has the
potential to have a huge impact on the sql being generated if the Driver by 
default supports outer joins (ie - MsSql) and the config file does not have a
hibernate.use_outer_joins=false set.


Index: PostgreSQLDialect.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Dialect/PostgreSQLDialect.cs,v
retrieving revision 1.5
retrieving revision 1.6
diff -C2 -d -r1.5 -r1.6
*** PostgreSQLDialect.cs	19 May 2004 04:14:18 -0000	1.5
--- PostgreSQLDialect.cs	11 Jul 2004 21:04:13 -0000	1.6
***************
*** 29,37 ****
  			Types.NUMERIC, "NUMERIC" );
  			*/
! 
! 			/*
! 			getDefaultProperties().setProperty(Environment.OUTER_JOIN, "true");
! 			getDefaultProperties().setProperty(Environment.STATEMENT_BATCH_SIZE, DEFAULT_BATCH_SIZE);
! 			*/
  		}
  
--- 29,35 ----
  			Types.NUMERIC, "NUMERIC" );
  			*/
! 			DefaultProperties[Cfg.Environment.OuterJoin] = "true";
! 			DefaultProperties[Cfg.Environment.StatementBatchSize] = DefaultBatchSize;
! 			
  		}
  

Index: SybaseDialect.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Dialect/SybaseDialect.cs,v
retrieving revision 1.8
retrieving revision 1.9
diff -C2 -d -r1.8 -r1.9
*** SybaseDialect.cs	19 May 2004 04:14:18 -0000	1.8
--- SybaseDialect.cs	11 Jul 2004 21:04:13 -0000	1.9
***************
*** 31,38 ****
  			*/			
  		
! 			/*
! 			getDefaultProperties().setProperty(Environment.OUTER_JOIN, "true");
! 			getDefaultProperties().setProperty(Environment.STATEMENT_BATCH_SIZE, NO_BATCH);
! 			*/
  		}
  
--- 31,36 ----
  			*/			
  		
! 			DefaultProperties[Cfg.Environment.OuterJoin] = "true";
! 			DefaultProperties[Cfg.Environment.StatementBatchSize] = NoBatch;
  		}
  

Index: MsSql2000Dialect.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Dialect/MsSql2000Dialect.cs,v
retrieving revision 1.12
retrieving revision 1.13
diff -C2 -d -r1.12 -r1.13
*** MsSql2000Dialect.cs	28 Apr 2004 03:46:11 -0000	1.12
--- MsSql2000Dialect.cs	11 Jul 2004 21:04:13 -0000	1.13
***************
*** 15,22 ****
  		public MsSql2000Dialect() : base() 
  		{
! 			/*
! 			getDefaultProperties().setProperty(Environment.OUTER_JOIN, "true");
! 			getDefaultProperties().setProperty(Environment.STATEMENT_BATCH_SIZE, NO_BATCH);
! 			*/
  		}
  
--- 15,20 ----
  		public MsSql2000Dialect() : base() 
  		{
! 			DefaultProperties[Cfg.Environment.OuterJoin] = "true";
! 			DefaultProperties[Cfg.Environment.StatementBatchSize] = NoBatch;
  		}
  

Index: Oracle9Dialect.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Dialect/Oracle9Dialect.cs,v
retrieving revision 1.8
retrieving revision 1.9
diff -C2 -d -r1.8 -r1.9
*** Oracle9Dialect.cs	19 May 2004 03:39:04 -0000	1.8
--- Oracle9Dialect.cs	11 Jul 2004 21:04:13 -0000	1.9
***************
*** 24,32 ****
  		public Oracle9Dialect() : base() 
  		{
! 			/* TODO:
! 			getDefaultProperties().setProperty(Environment.USE_STREAMS_FOR_BINARY, "true");
! 			getDefaultProperties().setProperty(Environment.STATEMENT_BATCH_SIZE, DEFAULT_BATCH_SIZE);
! 			getDefaultProperties().setProperty(Environment.OUTER_JOIN, "true");
! 			*/
  
  			// add all the functions from the base into this instance
--- 24,30 ----
  		public Oracle9Dialect() : base() 
  		{
! //			DefaultProperties[Cfg.Environment.UseStreamsForBinary] = "true";
! 			DefaultProperties[Cfg.Environment.StatementBatchSize] = DefaultBatchSize;
! 			DefaultProperties[Cfg.Environment.OuterJoin] = "true";
  
  			// add all the functions from the base into this instance

Index: Dialect.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Dialect/Dialect.cs,v
retrieving revision 1.32
retrieving revision 1.33
diff -C2 -d -r1.32 -r1.33
*** Dialect.cs	25 Jun 2004 20:35:02 -0000	1.32
--- Dialect.cs	11 Jul 2004 21:04:13 -0000	1.33
***************
*** 28,33 ****
  		private static readonly IDictionary aggregateFunctions = new Hashtable();
  
! 		const string DefaultBatchSize = "15";
! 		const string NoBatch = "0";
  
  		static Dialect() 
--- 28,33 ----
  		private static readonly IDictionary aggregateFunctions = new Hashtable();
  
! 		protected const string DefaultBatchSize = "15";
! 		protected const string NoBatch = "0";
  
  		static Dialect() 

Index: MySQLDialect.cs
===================================================================
RCS file: /cvsroot/nhibernate/nhibernate/src/NHibernate/Dialect/MySQLDialect.cs,v
retrieving revision 1.15
retrieving revision 1.16
diff -C2 -d -r1.15 -r1.16
*** MySQLDialect.cs	15 Apr 2004 21:07:18 -0000	1.15
--- MySQLDialect.cs	11 Jul 2004 21:04:13 -0000	1.16
***************
*** 15,23 ****
  		public MySQLDialect() : base() 
  		{
! 			
! 			/* TODO:
! 			getDefaultProperties().setProperty(Environment.OUTER_JOIN, "true");
! 			getDefaultProperties().setProperty(Environment.STATEMENT_BATCH_SIZE, DEFAULT_BATCH_SIZE);
! 			*/
  		}
  
--- 15,20 ----
  		public MySQLDialect() : base() 
  		{
! 			DefaultProperties[Cfg.Environment.OuterJoin] = "true";
! 			DefaultProperties[Cfg.Environment.StatementBatchSize] = DefaultBatchSize;
  		}