From: NHibernate J. <mik...@us...> - 2006-11-20 16:09:36
|
[ http://jira.nhibernate.org/browse/NH-813?page=comments#action_14446 ] Stuart Carnie commented on NH-813: ---------------------------------- I just thought it would be better to format the key appropriately earlier on, for performance reasons. If we do it where I suggested, we only remove the spaces once, when the meta-data for the entity is loaded, rather than every time we need to search for an entity in the cache. This results in less memory pressure, since we're not forced to allocate memory for the new string. Cheers, Stu > CacheKey key is invalid - memcached fails to store objects. > ----------------------------------------------------------- > > Key: NH-813 > URL: http://jira.nhibernate.org/browse/NH-813 > Project: NHibernate > Type: Patch > Components: Core > Versions: 1.2.0.Beta2 > Reporter: Stuart Carnie > Fix For: 1.2.0.CR1 > Attachments: cachekey-fix.patch > > The CacheKey derives from IdentifierSpace, which is EntityMetaModel.RootTypeAssemblyQualifiedName. This name contains spaces, which causes an issue with MemCache, in the 'set' command. With the spaces in the key, an invalid command is sent to the memcached server. > I have provided a patch that exposes a new property on EntityMetaModel, RootName (to match the property name in Hibernate), which simply replaces the spaces with underscores '_'. Now memcached caching works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.nhibernate.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |