[nhibernate-issues] [NHJIRA] Commented: (NHV-116) remove reference to obsolete NHibernate.Bytecode.ProxyFactoryFactoryNotConfiguredException

[korkless (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NHV-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20991#action_20991 ] 

korkless commented on NHV-116:
------------------------------

AbstractBytecodeProvider.ProxyFactoryFactory is not throwing ProxyFactoryFactoryNotConfiguredException
but it returns the DefaultProxyFactoryFactory from the nhibernate revision 5479, 

so we can changed the code of NHibernateHelper from
		public static bool IsProxyFactoryConfigurated()
		{
			try
			{
				var f = NHibernate.Cfg.Environment.BytecodeProvider.ProxyFactoryFactory;
				return true;
			}
			catch (ProxyFactoryFactoryNotConfiguredException)
			{
				return false;
			}
		}

to
		public static bool IsProxyFactoryConfigurated()
		{
			var f = NHibernate.Cfg.Environment.BytecodeProvider.ProxyFactoryFactory;
			return true != null;
		}


it's a breaking change, i didn't find a way to keep compatile with the previous nhibernate versions


> remove reference to obsolete NHibernate.Bytecode.ProxyFactoryFactoryNotConfiguredException
> ------------------------------------------------------------------------------------------
>
>                 Key: NHV-116
>                 URL: http://216.121.112.228/browse/NHV-116
>             Project: NHibernate.Validator
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.3.1 GA
>            Reporter: korkless
>            Priority: Critical
>
> in the nhibernate project revision 5718 the class ProxyFactoryFactoryNotConfiguredException has been deleted,
> it is yet used in nhibernate.validator at least in the method NHibernate.Validator.Util.NHibernateHelper.IsProxyFactoryConfigurated() (i have only vs 2005 so i can't check if it's used in other places)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira