[nhibernate-issues] [NHJIRA] Created: (NH-2500) NH 3.0 Linq provider uses query parameters from first call in subsequent calls.

[Andrey T. (JIRA) <nh...@gm...>]

NH 3.0 Linq provider uses query parameters from first call in subsequent calls.
-------------------------------------------------------------------------------

                 Key: NH-2500
                 URL: http://216.121.112.228/browse/NH-2500
             Project:  NHibernate
          Issue Type: Bug
          Components: Linq Provider
    Affects Versions: 3.0.0.GA
            Reporter: Andrey Titov
            Priority: Critical
         Attachments: NHTest3.zip

NH 3.0 Linq provider uses query parameters from first call in subsequent calls if this parameters are not propagated to SQL.

//in first session
this.number = 545;
var cats = session.Query<Cat>().Select(cat => new CatInfo { Name = cat.Name, SomeNumber = this.number }).ToList();
// all works perfect: all CatInfos contains 545

//later in another session
this.number = 842;
var cats = session.Query<Cat>().Select(cat => new CatInfo { Name = cat.Name, SomeNumber = this.number }).ToList();
// magic happens: all CatInfos contains 545 again

I've debugged NH and found that in second query it gets QueryPlan from cache in NHibernate.Impl.AbstractSessionImpl.GetHQLQueryPlan() and it contains parameters from first call of query (NHibernate.Linq.NhLinqExpression.ParameterValuesByName) and then fails to replace them in NHibernate.Linq.NhQueryProvider.SetParameters() because they are not actual SQL parameters (query.NamedParameters).

Sample solution is attached (VS2010, SQL Server Express DB). Put NH and LinFu.DynamicProxy binaries to .Libraries\NHibernate before build.

I think actual parameters should be cleared from query (set to default(T)) before putting plan in QueryPlanCache to let them be garbage collected and prevent real magic happen in case of similar bugs.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira