[nhibernate-issues] [NHJIRA] Commented: (NH-2214) Distinct and Row_number problem

[Marcin D. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20075#action_20075 ] 

Marcin Daczkowski commented on NH-2214:
---------------------------------------

"We have fixed a lot. 
For that reason after 2.0.0 you saw 2.0.1, 2.1.0, 2.1.1 and finally 2.1.2 "
I don't doubt this. I appreciate your work.

"NH3 is not in alpha but in beta and the candidate release is closer. 
There is no reason to release another 2.x. "
Maybe I don't get something. Would you encourage to user 3.x in production code? 

"btw you can call NH as release 5252 because for us each commit is a candidate to be used in production and even if for us are not enough you can't ignore our 2700+ tests. 
The quality is not achieved by the number somebody gave to a deployment."
Sorry but I don't get this completely. If this is relevant please elaborate. 



> Distinct and Row_number problem
> -------------------------------
>
>                 Key: NH-2214
>                 URL: http://216.121.112.228/browse/NH-2214
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: DataProviders / Dialects
>    Affects Versions: 2.1.1.GA, 2.1.2.GA
>            Reporter: Carlos Martinez
>            Priority: Major
>         Attachments: MsSql2005Dialect.cs, NH-2214-reproduction.zip, NH-2214.patch, NH-2214.patch
>
>
> Microsoft.NET Framework 3.5
> MSSQL 2008
> Select distinct T.ID, T.Name from T
> inner join T2 on T.ID = T2.TID
> order by T.Name
> With this native query (using ISQLQuery) and the statement "DISTINCT" is necessary because the union wiht T2 produces duplicate results of T. 
> if I use
> SetFirstResult(index)
> SetMaxResults(max)
> It generates the following Query
> Select top max
>   ID,
>   Name  
>   from
>         (select distinct
>           ID,
>           Name,
>           ROW_NUMBER () over (order by T.Name) as __hibernate_sort_row
>           from T
>           inner join T2) as query
>     where __hibernate_sort_row > index
> first results are generated with ROW_NUMER, for example
> T.ID  T.Name   __hibernate_sort_row
> 2     Carlos   1
> 1     Juan     2
> 1     Juan     3
> 3     Paulina  4
> 4     Zunio    5
> 4     Zunio    6
> 4     Zunio    7
> Then "DISTINCT" no longer makes sense, because all records are different due to ROW_NUMBER.
> In version 2.0.1 GA works perfectly

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira