[nhibernate-issues] [NHJIRA] Commented: (NH-2318) Template functions fail with certain combinations of arguments.

[Patrick E. (JIRA) <nh...@gm...>]

    [ http://216.121.112.228/browse/NH-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=19844#action_19844 ] 

Patrick Earl commented on NH-2318:
----------------------------------

HqlParameterReordering fixes the issue for named parameters in HQL.  Though it doesn't provide support for ordinal parameters, even having the fix in place for named parameters is a significant advantage.  It will not only fix bugs in the current code but allow for far more flexibility in defining functions for HQL.  The assumption that functions use the same number of arguments in the same order is quite limiting and has already been violated several times, causing bugs.

This particular block of code need not change for ordinal parameter support either.  The changes for that would be at a different level.

> Template functions fail with certain combinations of arguments.
> ---------------------------------------------------------------
>
>                 Key: NH-2318
>                 URL: http://216.121.112.228/browse/NH-2318
>             Project:  NHibernate
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.0.0.Alpha2
>            Reporter: Patrick Earl
>         Attachments: HqlParameterReordering.patch, SqlFunctionProjectionFix.patch, TrimFunctionsTest.patch
>
>
> Some template functions such as TRIM() fail since they use repeated arguments in the template.  Additionally, the LEADING and TRAILING trim emulation functions have their ltrim and rtrim reversed.  Included is a unit test that demonstrates that failure.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://216.121.112.228/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira