[Nhibernate-commit] SF.net SVN: nhibernate:[4412] trunk/nhibernate/src/NHibernate

[<fab...@us...>]

Revision: 4412
          http://nhibernate.svn.sourceforge.net/nhibernate/?rev=4412&view=rev
Author:   fabiomaulo
Date:     2009-06-05 04:39:24 +0000 (Fri, 05 Jun 2009)

Log Message:
-----------
Breaking Change for external framework
The method GetSession() was removed (some user is thinking that it is for child-session where it was only to avoid downcast in NHSR)

Modified Paths:
--------------
    trunk/nhibernate/src/NHibernate/Engine/ISessionImplementor.cs
    trunk/nhibernate/src/NHibernate/Impl/AbstractSessionImpl.cs
    trunk/nhibernate/src/NHibernate/Impl/SessionImpl.cs
    trunk/nhibernate/src/NHibernate/Impl/StatelessSessionImpl.cs

Modified: trunk/nhibernate/src/NHibernate/Engine/ISessionImplementor.cs
===================================================================
--- trunk/nhibernate/src/NHibernate/Engine/ISessionImplementor.cs	2009-06-04 23:31:55 UTC (rev 4411)
+++ trunk/nhibernate/src/NHibernate/Engine/ISessionImplementor.cs	2009-06-05 04:39:24 UTC (rev 4412)
@@ -270,13 +270,6 @@
 		/// </summary>
 		bool TransactionInProgress { get; }
 
-		/// <summary>
-		/// Allow to get the ISession instance without having to 
-		/// down cast
-		/// </summary>
-		/// <returns></returns>
-		ISession GetSession();
-
 		/// <summary> Retrieve the entity mode in effect for this session. </summary>
 		EntityMode EntityMode { get; }
 

Modified: trunk/nhibernate/src/NHibernate/Impl/AbstractSessionImpl.cs
===================================================================
--- trunk/nhibernate/src/NHibernate/Impl/AbstractSessionImpl.cs	2009-06-04 23:31:55 UTC (rev 4411)
+++ trunk/nhibernate/src/NHibernate/Impl/AbstractSessionImpl.cs	2009-06-05 04:39:24 UTC (rev 4412)
@@ -99,7 +99,6 @@
 		public abstract IList<T> ListCustomQuery<T>(ICustomQuery customQuery, QueryParameters queryParameters);
 		public abstract object GetFilterParameterValue(string filterParameterName);
 		public abstract IType GetFilterParameterType(string filterParameterName);
-		public abstract ISession GetSession();
 		public abstract IDictionary<string, IFilter> EnabledFilters { get; }
 
 		public virtual IQuery GetNamedSQLQuery(string name)

Modified: trunk/nhibernate/src/NHibernate/Impl/SessionImpl.cs
===================================================================
--- trunk/nhibernate/src/NHibernate/Impl/SessionImpl.cs	2009-06-04 23:31:55 UTC (rev 4411)
+++ trunk/nhibernate/src/NHibernate/Impl/SessionImpl.cs	2009-06-05 04:39:24 UTC (rev 4412)
@@ -2334,11 +2334,6 @@
 			return this;
 		}
 
-		public override ISession GetSession()
-		{
-			return this;
-		}
-
 		public ISession GetSession(EntityMode entityMode)
 		{
 			using (new SessionIdLoggingContext(SessionId))

Modified: trunk/nhibernate/src/NHibernate/Impl/StatelessSessionImpl.cs
===================================================================
--- trunk/nhibernate/src/NHibernate/Impl/StatelessSessionImpl.cs	2009-06-04 23:31:55 UTC (rev 4411)
+++ trunk/nhibernate/src/NHibernate/Impl/StatelessSessionImpl.cs	2009-06-05 04:39:24 UTC (rev 4412)
@@ -924,12 +924,6 @@
 
 		#endregion
 
-		public override ISession GetSession()
-		{
-			// TODO: Verify the use of this method in NH.Search and remove it
-			throw new NotSupportedException();
-		}
-
 		public override int ExecuteNativeUpdate(NativeSQLQuerySpecification nativeSQLQuerySpecification, QueryParameters queryParameters)
 		{
 			using (new SessionIdLoggingContext(SessionId))


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.