[NGL-devel] Re: MSVC6 build fixes

[Vincent C. <v....@ze...>]

Hello John,

  I finally take the time to go through your patch !


> Most changes are workspace/project file tweaks (.dsw/.dsp).

On ngl/libngl{_static}.dsp/dsw, correct me if I'm wrong but do we have the choice
between these two solutions :

- drag 3rd party libs (png, jpeg, zlib, freetype) .dsp into libngl{_static}.dsw as
dependencies. Then we don't have to set explicitly the 'additional libraries' list
(libpng.lib libjpeg.lib ...) in libngl{_static}.dsp, MSVC will do the linking for us.
The  major inconvenient being that then for every application using NGL, we must drag
libngl{_static}.dsp AND the 3rd part libraries projects into its workspace.

- explicitely link against the .lib files in the libngl{_static}.dsp project settings,
then we only need this single project in libngl{_static}.dsw. And a NGL based can drag
the libgnl project into its workspace and see it linking automagically against the 3rd
party libraries.

If I'm right, then your patch brings up a mix of the two situations. I remember we
already went on these questions a looong time ago...


>  - benchapp.cpp: Removed mpFont references from destructor.  mpFont is not
> initialized or used anywhere else.
>  - benchapp.h: Removed declaration of mpFont member variable.

Indeed, applied.


>  - ngl_all.h: Removed #include "nglFont2.h" and #include "nglInput.h" (these
> files don't seem to exist).  Your call on what to do with this (are these
> old files?).

This has already been updated in CVS two weeks ago, but your patch is right (we also
added nglFont1.h and nglInputDevice.h since then).


> I have also created new .dsw/.dsp files for the nui examples.
> I have tested all of them except the OggVorbis and vstplugin examples, which
> I could not do as I don't have all the required files to build them.

Applied. Note : I can see strange strings like '' and '' in libnui.dsp, looks like old
Meeloo experiments that slipped in.


>  - nuimemorydrawcontext.cpp: Changed BITMAPV5HEADER to BITMAPV4HEADER.
> BITMAPV5HEADER is not declared in my headers - must have been added in the
> newer MSVC headers.  Seems to work fine with BITMAPV4HEADER (you don't use
> any of the new fields).

Let's report this one to Meeloo, this is his code (patch attached).


> Previously reported fixes:
>  - nuicontainer.h: Added nuiContainer:: qualifier inside Iterator class
> declaration.

This looks weird, we have such nested classes in NGL and MSVC6 seems to compile them
without this explicit prefix. Meeloo, could you have a look at the attached patch ?


>  - nuiedittext.cpp: Removed return statement from
> nuEditText::Invalidate(..).

This was already in CVS.