Re: [namedgraphs] SQL escaping bug found (and fixed)

[Jennifer C. <jen...@at...>]

This patch has been applied to the NG4J source code.

Asheesh did some testing with MySQL and Apache Derby; I inspected the code
and ran the NG4J tests with HSQLDB (in-memory), Apache Derby, PostgreSQL,
and Oracle Express.

For HSQLDB there were no failures/errors.

For Apache Derby and PostgreSQL, there was a failure/error which was fixed
by the patch, so with the patch no problems.

For Oracle there were almost identical failures/errors both without and
with the patch.  So that needs to be fixed.  It appears that after one of
the failure/errors, the tables are deleted which causes the remaining
tests to fail.  In running other tests which execute the NG4J database
code, there were "maximum open cursors exceeded" type errors, probably due
to ResultSet's not all being closed.  

Anyone have an opinion about using com.sun.rowset.CachedRowSet so that
ResultSet's can be closed, or other suggestions for the memory leak issue
identified by Graeme Stevenson? 

Jennifer


-----Original Message-----
From: Asheesh Laroia [mailto:ng...@as...] 
Sent: Monday, September 13, 2010 2:01 PM
To: Jennifer Cormier
Cc: ng4...@li...
Subject: Re: [namedgraphs] SQL escaping bug found (and fixed)

On Mon, 13 Sep 2010, Asheesh Laroia wrote:

> I've only actually tested Derby yet, but once I finish cleaning up the 
> patches for y'all I expect I'll have test it against MySQL also. We 
> don't have the other ones set up here, so your sanity check will be 
> crucial.

I just tested MySQL, and it works fine (as expected).

https://sourceforge.net/tracker/?func=detail&aid=3065437&group_id=118754&a
tid=682762 
tracks the patches.

Thanks for your super quick, friendly reply! I wish more projects were 
like this. (-:

-- Asheesh.

-- 
For courage mounteth with occasion.
 		-- William Shakespeare, "King John"