From: Tim P. <ti...@pa...> - 2010-01-21 20:17:04
|
Hi Jennifer, On Thursday 21 January 2010 00:21:53 Jennifer Cormier wrote: > Hi Tim, > > Thanks very much for your work on this! > > > Shall I commit these changes? > > That's a good question. If the changes are backwards-compatible (i.e. > don't require anything from Jena 2.6.2 or its dependencies) then it > shouldn't be a problem. If they're not then we need to decide. > > In what package (and jar) does the LiteralLabelFactory class live? > > > Jennifer All I did was change the version of the jar (jenatest is no longer a dependency, if I remember correctly we knew this was the plan at the next version) All the tests pass. As far as I can see this is a minor refactoring in Jena which we are just copying. Indeed the code even has a comment to the effect that the original was copied without comprehension. So I would say that the thing to do is to commit these minor changes, update the jar files in lib and issue another version. This is getting increasingly easy. The important thing, in my view, is to remain in lock step with Jena. I may not notice when new versions of Jena are released and am happy to be nudged when this happens. cheers Tim -- We are in dialogue. |