From: Jennifer C. <jen...@at...> - 2009-09-22 16:57:18
|
Thank you, Tim. I should have run the tests locally before submitting. Thanks for catching that omission! Jennifer -----Original Message----- From: Tim Pizey [mailto:tim...@ou...] Sent: Tuesday, September 22, 2009 4:54 AM To: ng4...@li... Subject: Re: [namedgraphs] Base64 encoding Hi Jennifer, I do not know the requirement here, but the tests reflected what was done previously. I have now corrected the tests to reflect your change. I now have ng4j running under Hudson, unfortunately not on a public url, so I was alerted when the tests failed. yours Tim On Thursday 17 Sep 2009 20:50:09 Jennifer Cormier wrote: > Hi everyone, > > The Base64 encoding is working slightly different since the change > away from the sun libraries. (Note: I have no issues with the change, > and thank Tim for making it! We needed to move away from those libs.) > > If you run the SWPExample (in src/de.fuberlin.wiwiss.ng4j.examples) > and compare the functionality from the prior release, it can be seen > that the sun libraries didn't chunk the data when encoding. (i.e. no > carriage return is added after 76 characters.) > > The new code (e.g. in SWPSignatureUtilities.calculateDigest) is using > Base64.encodeBase64Chunked so it does insert the carriage return. > > >From what I've read, it's actually standard to include the carriage > return. > > HOWEVER I'm not sure we want to do that for the digest in NG4J. The > digest is then added to the warrantGraph as a literal (as the object > in an RDF statement about the digest). Perhaps that's legal, but it > does look odd when the RDF is written in whatever format. > > I'm assuming that change was made unintentionally and we could go back > to the chunk-less style? i.e. change to use Base64.encodeBase64 in > all places? > > Jennifer > > Jennifer P. Cormier > Sr. Computer Scientist > ATC-NY > www.atc-nycorp.com > > > ---------------------------------------------------------------------- > -------- Come build with us! The BlackBerry® Developer Conference > in SF, CA is the only developer event you need to attend this year. > Jumpstart your developing skills, take BlackBerry mobile applications > to market and stay ahead of the curve. Join us from November 9-12, > 2009. Register now! http://p.sf.net/sfu/devconf > _______________________________________________ > ng4j-namedgraphs mailing list > ng4...@li... > https://lists.sourceforge.net/lists/listinfo/ng4j-namedgraphs > -------------------------------------------------------------------------- ---- Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ ng4j-namedgraphs mailing list ng4...@li... https://lists.sourceforge.net/lists/listinfo/ng4j-namedgraphs |