From: Tim P. <tim...@ou...> - 2009-07-29 16:34:27
|
Hi, I can find out little about the sun package however http://www.lumentier.com/java/?pth=/java/jdk-7-bld1/sun.misc/BASE64Encoder/class-javadoc.lmtr seems to give java7 source. http://java.sun.com/products/jdk/faq/faq-sun-packages.html details the problems with using sun packages. The uses in CreateTestKeystore were incidental, that is they were just used to print out informational messages. so I have been able to change to the Apache Base64Encoder without problem. The remaining uses were in SWPSignatureUtilities. I tried to write a test which checked that the my change had no effect. I have found this difficult however. Using http://www.lumentier.com/java/?pth=/java/jdk-7-bld1/sun.misc/BASE64Encoder/class-javadoc.lmtr and clicking the source link seems to suggest that the sun.misc.CharacterEncoder assumes 8859_1 character set. The apache equivalent method inserts "\r\n" rather than just "\n" as the sun method does. to get around this I stripped both line-end chars in the tests before comparison. I do not know whether we really want to be formatting the Base64 strings at all. We now have the sun.misc removed and banned from the Eclipse class path. The RoadMap https://sourceforge.net/apps/mediawiki/ng4j/index.php?title=Post_0.9_Release_Plans shows the next thing to do is remove grddl, nekohtml and tagsoup. Would you like me to have a go at this? I think we should move CreateTestKeyStore to the test hierarchy so that it does not show up in the test coverage reports (see http://paneris.net/ng4j/cobertura/index.html) cheers Tim |