Re: [namedgraphs] Update to latest Jena (Was: Bouncy Castle now in Maven Repository)

[Tim P. <tim...@ou...>]

Hi Olaf, 

On Saturday 25 July 2009 12:40:59 Olaf Hartig wrote:
> Hey Tim,
> 
> On Friday 24 July 2009 12:10:41 Tim Pizey wrote:
> > [...]
> > I have added the patch to the tracker, but also attach here.
> 
> The patch works with Jena 2.5.7. The change in
>    tests/de/fuberlin/wiwiss/ng4j/sparql/MyResultSet.java
> is not necessary.

I will check when I am back at my office, but all I was doing was what Eclipse told me, 
that the method signature had now changed to QuerySolution.
 
> When you edit a source file and want to commit it please respect and keep the 
> indentation style in this file, also for new methods. With 
> NamedGraphDataset.close you didn't do so.

OK, please create and commit an Eclipse style file, if you use Eclipse, 
or I will and will check that I have the style rules correct. 

Maybe I should add a Checkstyle file?

> > What I have not done is changed any jars in /lib.
> > Those changes would be to update antlr to version 2.7.7
> > and replace jena.jar and jenatest.jar with jena 2.5.7 jars
> 
> Don't forget arq.jar

Good catch.

> > The bouncycastle jars should not be different, we are just using them
> > directly fromn the maven repository now.
> 
> What do you mean by "we" here?
> Remember, not everyone is using Maven (e.g. me). Maven shouldn't be a 
> requirement to compile NG4J.

I have patched the Maven pom.xml to use the Maven central repository files, 
this will have no effect on the ant build, the actual jar files, in our lib and 
the maven central repository, I believe to be the same. 

> > I don't know if you are happy to continue to deploy to Melati.org or
> > whether there is a desire to get the ng4j jars into the main maven repos.
> > It is actually a bit of work to get them in and keep them updated.
> > (See the bouncy castle process)
> 
> ??? I was not aware that I/we "deploy to Melati.org." I do not even know what 
> Melati.org is.
> 
> Seriously, I cannot answer this question. You are the Maven expert. What do 
> you say?

OK, what I am asking is do we, like BouncyCastle and Jena, wish to go to 
the effort of trying to get our jars into the Maven central repository, this 
is a bit of work. I do publish our jar to am open repository which I maintain 
for my own use: http://melati.org/maven2, this is hard coded into the pom.xml file.
Unless others are interested I think we should leave this for now.

> > My sourceforge id is timp
> 
> I added you as a developer to the NG4J SourceForge project. This means you 
> have write access to CVS now. Welcome!

Thank you, I will be careful. 

yours
Tim