Hello,
the attached patch adds Zeroconf support for the
following Zeroconf implementations to afpd:
If one wants to de-activate Zeroconf support she can
specify -nozeroconf in afpd.conf (like with SLP).
I did test the patch today against Avahi, but I did not
have the time to test it against the remaining Zeroconf
implementations.
Regards
Daniel S. Haischt
Logged In: YES
user_id=433182
Attached you will find a revised patch. It can be applied
using the following command(s):
~$ cvs co netatalk
~$ cd netatalk
~$ patch -p0 < ../afpd-zeroconf.diff
~$ ./autogen.sh
At this time you should finally states:
Options:
SLP support: no
Zeroconf support: yes
This means that the configure script successfully found a
valid Zerconf implementation (either Avahi, Howl or
Bonjour). It is important to not enable both, SLP and
Zerconf support.
Now you may compile netatalk. After having installed
netatalk (make && make install), Zeroconf support should be
available out of the box. Theres no need to enable it using
a particular flag or config option in one of the netatalk
config files.
After having installed the Zeroconf enabled afp daemon, your
Zeroconf implementation should start to announce that
there's a afp daemon running on your computer.
The announced data should look something like this:
Service Type: _afpovertcp._tcp
Service Name: ubuntu-abysssix
Domain Name: local
Interface: eth0 IPv4
Address: ubuntu-abysssix.local/192.168.120.241:548
TXT org.freedesktop.Avahi.cookie = 1441224273
Zeroconf support for afpd
Logged In: NO
Patch works well with Avahi - and Gentoo is waiting for it
to be applied in this CVS before they will consider it.
http://bugs.gentoo.org/show_bug.cgi?id=133575
We might be able to get this patch accepted soon. However there are some complaints about it on the Gentoo bug page linked below. Anything new to add to this?
Can you please provide a functional diff against current HEAD ?
Sadly, this patch no longer applies cleanly because cvs head added OPTION_UUID to globals.h and now OPTION_NOZEROCONF should now be 1<<8
<<<<<<< globals.h
define OPTION_NOZEROCONF (1 << 7)
=======
define OPTION_UUID (1 << 7)
The main concerns regarding this patch were summarized by Didier here:
https://sourceforge.net/mailarchive/message.php?msg_name=1211722072.7118.242.camel%40server
-Frank
Integrated in git branch branch-zeroconf. To be merged to master soon.