Menu
▾
▴
Re: [Netatalk-admins] Would you miss the "include" directive in afp.conf?
|
From: Andres V. <te...@sm...> - 2025-03-30 08:44:58
|
Perhaps --with-config-files=comma,separated,priority,left,to,right. Side comment only. On 3/30/25 12:30 AM, Daniel Markstedt wrote: > Hi Chris, > > Thanks for sharing your use case. This is a valuable insight regardless > of whether the product you worked on still supports netatalk or not. > > This makes me imagine a potential alternative solution: The netatalk > daemon (and child daemons) currently take the -F option for a custom > path to afp.conf. What if we introduce a, say, -G option for passing the > path to the secondary afp.conf. This would theoretically satisfy your > use case of having a secondary set of per-user settings. > > The main drawback I could see right now, would be that you lose the > flexibility of choosing where exactly in the main afp.conf to "inject" > the contents of the secondary afp.conf. Rather, the two would always be > read and parsed sequentially. > > But the code would be a lot simpler and less error prone, IMO. > > Thoughts? > > Daniel > > On Wednesday, March 26th, 2025 at 8:41 PM, Chris Devers > <cd...@ed...> wrote: >> Hello, >> >> My employer used to provide AFP support with our storage products, and >> when we did, we made use of a mechanism that generated per-user config >> files that made use of `include` directives so that we could provide a >> mix of global and per-user settings. >> >> It’s not really worth getting into implementation specifics though, >> because we dropped Netatalk/AFP support a while ago, so this is >> academic now. Removing that option would have been a big complication >> for us before that, but not now. >> >> Not sure if any other storage vendors are still producing systems that >> support AFP access to shared storage, per-user configurations. If so, >> apparently they aren’t on this mailing list. :-) >> >> >> On Fri, Mar 21, 2025 at 2:34 AM Daniel Markstedt <da...@mi... >> <mailto:da...@mi...>> wrote: >> >> Thanks for the feedback, Andres. :) >> >> Let me cc the mailing list back, for posterity. >> >> I have asked the same question on multiple forums and on Mastodon. >> So far a single person has said they use it. >> >> Cheers, >> Daniel >> >> >> On Sunday, March 16th, 2025 at 11:47 AM, Andres Valloud >> <te...@sm... <mailto:te...@sm...>> wrote: >> >> > >> >> > >> >> > Won't miss :). >> > >> >> > On 3/16/25 3:09 AM, Daniel Markstedt wrote: >> > >> >> > > Dear Netatalk community, >> > > >> >> > > Would you be negatively impacted if we were to remove support >> for the >> > > "include" directive in afp.conf? >> > > >> >> > > As a refresher, "include = /path/to/extra_afp.conf" allows you to >> > > dynamically load a secondary ini file that gets nested inside >> of the >> > > main afp.conf file. >> > > >> >> > > In the main development branch, we have removed the vendored >> iniparser >> > > library in favor of linking with the shared system iniparser >> library. >> > > Our vendored iniparser library contained multiple hacks, >> notably support >> > > for the "include" directive. >> > > >> >> > > There are other ways to achieve similar outcomes, for instance >> > > concatenating multiple ini files into a combined afp.conf temp >> file that >> > > then gets read by iniparser. >> > > However, there's a bunch of logic internally for error >> handling and >> > > polling for modified time stamps on the ini files that >> complicate any >> > > solution. >> > > I'd personally prefer to drop "include" to reduce complexity >> and reduce >> > > the risk of bugs. >> > > >> >> > > I'm looking forward to hear back from you. :) >> > > >> >> > > Daniel >> > > >> >> > > _______________________________________________ >> > > Netatalk-admins mailing list >> > > Net...@li... <mailto:Netatalk- >> ad...@li...> >> > > https://lists.sourceforge.net/lists/listinfo/netatalk-admins >> <https://lists.sourceforge.net/lists/listinfo/netatalk- >> admins>_______________________________________________ >> Netatalk-admins mailing list >> Net...@li... <mailto:Netatalk- >> ad...@li...> >> https://lists.sourceforge.net/lists/listinfo/netatalk-admins >> <https://lists.sourceforge.net/lists/listinfo/netatalk-admins> >> > > > > _______________________________________________ > Netatalk-admins mailing list > Net...@li... > https://lists.sourceforge.net/lists/listinfo/netatalk-admins |
