#634 FPDisconnectOldSession won't work

[kenji uno]

It seems FPDisconnectOldSession doesn't work and it returns kFPMiscErr = -5014 for now.

However it works, if I modify the libatalk\util\serverchild.c:247 like following:

    if (0&&!child->afpch_valid) {
        /* hmm, client 'guess' the pid, rogue? */
        LOG(log_error, logtype_default, "Reconnect: invalidated child[%u]", pid);
        return 0;
    } else if (0&&child->afpch_uid != uid) {
        LOG(log_error, logtype_default, "Reconnect: child[%u] not the same user", pid);
        return 0;
    }

I think that child->afpchvalid and child->afpchuid aren't assigned on runtime well.
Anyone knows about workaround for this?

kenjiuno

[kenji uno]

I have made a instant patch for fixing this problem.
I hope this will help.

kenjiuno

[HAT]

0001-HAVE_LDAP.patch is applied already.
https://github.com/Netatalk/Netatalk/commit/e61041c1e42f2607afc5ae7e3da8e051530d712c

[kenji uno]

Yes, I know.
I have used netatalk-3.1.9.tar.bz2 for base working code, because github version doesn't have configure.
Please ignore 0001-HAVE_LDAP.patch.
I will try if rebase is required.

kenji uno

[Daniel Markstedt]

PR for 0002 submitted as https://github.com/Netatalk/netatalk/pull/296

[Daniel Markstedt]

Merged.