Re: [net-tools-devel] [PATCH] AppleTalk pathnames in /proc/net
Linux networking base tools
Brought to you by:
eckes
Menu
▾
▴
Re: [net-tools-devel] [PATCH] AppleTalk pathnames in /proc/net
|
From: Bernd E. <ec...@zu...> - 2021-08-18 20:05:20
|
<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!-- /* Font Definitions */ @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; font-size:11.0pt; font-family:"Calibri",sans-serif;} a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;} .MsoChpDefault {mso-style-type:export-only;} @page WordSection1 {size:612.0pt 792.0pt; margin:70.85pt 70.85pt 2.0cm 70.85pt;} div.WordSection1 {page:WordSection1;} --></style></head><body lang=DE link=blue vlink="#954F72" style='word-wrap:break-word'><div class=WordSection1><p class=MsoNormal>Hello,</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>if it helps, you can provide a pull request against Github as well, I usually Keep them in sync:</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><a href="https://github.com/ecki/net-tools">GitHub - ecki/net-tools: Linux base networking tools</a></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>And just for reference, I think this is the related bug if you want to Mention #32 in the commit:</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><a href="https://sourceforge.net/p/net-tools/bugs/32/">net-tools / Bugs / #32 DDP (AppleTalk) support broken (sourceforge.net)</a></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Other than that, I prefer to check all the different file names unconditionally (no dependency on kernel versions), and as Mike mention: no need to look at anything besides Linux. (I say this without having checked the patch, is it on netdev?)</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Gruss</p><p class=MsoNormal>Bernd</p><p class=MsoNormal>-- <o:p></o:p></p><p class=MsoNormal>https://bernd.eckenfels.net<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><div style='mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal style='border:none;padding:0cm'><b>Von: </b><a href="mailto:va...@ge...">Mike Frysinger</a><br><b>Gesendet: </b>Mittwoch, 18. August 2021 21:30<br><b>An: </b><a href="mailto:joe...@gm...">Joe Jamison</a><br><b>Cc: </b><a href="mailto:ph...@gn...">ph...@gn...</a>; <a href="mailto:net...@li...">net...@li...</a><br><b>Betreff: </b>Re: [net-tools-devel] [PATCH] AppleTalk pathnames in /proc/net</p></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>On 01 Aug 2021 15:27, Joe Jamison wrote:</p><p class=MsoNormal>> From 9efbaa165fec64bb832940f752e7f2fe113cdaf8 Mon Sep 17 00:00:00 2001</p><p class=MsoNormal>> From: Joe Jamison <jo...@sm...></p><p class=MsoNormal>> Date: Sun, 1 Aug 2021 12:17:52 -0500</p><p class=MsoNormal>> Subject: [PATCH] Updated AppleTalk/DDP pathnames in /proc/net</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>for future patches, can you include our mailing list ?</p><p class=MsoNormal>net...@li...</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>> As of Linux 2.5.41 (Oct-2002), the proc directory entry for</p><p class=MsoNormal>> AppleTalk was changed from 'appletalk' to 'atalk'. This patch</p><p class=MsoNormal>> adds checks to see if net-tools is being compiled for Linux,</p><p class=MsoNormal>> and if compiling against versions greater than 2.5.41, re-defining</p><p class=MsoNormal>> _PATH_PROCNET_ATALK as "/proc/net/atalk". Previously,</p><p class=MsoNormal>> ifconfig would try to access "/proc/net/appletalk", which would</p><p class=MsoNormal>> result in an ENOENT error on newer Linux systems. The path is</p><p class=MsoNormal>> left alone for other UNIXes where this may apply.</p><p class=MsoNormal>> </p><p class=MsoNormal>> </p><p class=MsoNormal>> Tested on: net-tools latest w/atalkd 2.2.6, Linux 4.14.240-amd64</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>we only support Linux, so we don't need __linux__ checks.</p><p class=MsoNormal>you can see how we hardcode linux/ includes everywhere.</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>wrt version checks, we document:</p><p class=MsoNormal>> These have largely been tested against Linux kernels 2.6+. They might work</p><p class=MsoNormal>> against older ones if anyone actually still cares about those anymore.</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>so i'm inclined to just assume 2.6.0+ nowadays. no one is shipping 2.5 (which</p><p class=MsoNormal>was largely dev only), and no one is building or testing 2.2 or 2.4.</p><p class=MsoNormal>-mike</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>_______________________________________________</p><p class=MsoNormal>net-tools-devel mailing list</p><p class=MsoNormal>net...@li...</p><p class=MsoNormal>https://lists.sourceforge.net/lists/listinfo/net-tools-devel</p><p class=MsoNormal><o:p> </o:p></p></div></body></html> |
