#32 DDP (AppleTalk) support broken

[Martín Ferrari]

Hi, it seems that AppleTalk support has been broken for a long time. There is a Debian bug open for some 16 years about this :-)

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=33415

The proc path names have changed, and possibly the format too, but I don't have a atalk setup to test it:

$ sudo modprobe appletalk

$ ls /proc/net/atalk
arp interface route socket

$ LANG=C netstat -A ddp -r
Error opening /proc/net/atalk_route: No such file or directory
DDP (AppleTalk) not configured on this system.

[Joe Jamison]

I know this is an esoteric bug, but in 2.6+ kernel versions, the /proc pathnames have changed. The formats are still the same. I got it to work by updating _PATH_PROCNET_ATALK to "/proc/net/atalk", and _PATH_PROCNET_ATALK_ROUTE to "/proc/net/atalk/route". (./lib/pathnames.h, lines 41 and 58). I also updated ./lib/ddp.c line 62 from "/proc/net/appletalk" to _PATH_PROCNET_ATALK. ./lib/ddp_gr.c already used the macro, so no update was necessary. For testing, I used netatalk-2.2.6. You have to patch main.c (https://github.com/Netatalk/Netatalk/commit/bbc0d89c056be3a2b5efa6bf5428f7ba8f07a1d0), and get an old libssl-dev (https://sourceforge.net/p/netatalk/bugs/653/), but then it will compile with
./configure --prefix=/ --enable-ddp --enable-systemd && make && make install
My /etc/netatalk/atalkd.conf file has a line "enp0s3 -phase 2 -net 0-2 -addr 1.10", and ifconfig and route --ddp both show the correct output.