Re: RFC / IF-MIB network namespaces (linux)

[Robert S. <rs...@fr...>]

On Wed, 4 Feb 2015 15:14:16 +0000 (UTC) Tobias wrote:
TH> we recently had the need to expose interface counter of
TH> network namespaced interfaces on Linux.
TH> 
TH> So this patch adds partial support for this by wrapping
TH> relevant code in setns() pairs.
TH> 
TH> Feedback is welcome!

Thanks for submitting this patch. Please submit this to our patch
tracker so it doesn't get lost!

I've only skimmed the patch, but I have a few questions/comments.

- indices. Currently on Linux we use the same index as the kernel.
  In your example in the readme, it looks like there is a fixed
  offset (~ 1024) for each namespace. I assume that this means that
  interfaces indices within each namespace start at 1? (Blech)

- localname. you added ns and localname to the interface entry
  structure. ns I understand. what is the difference between the
  original name and the new localname.

- a configure test is needed to test for setns() and setting a
  define to conditionally compile the namespace code.

- a new conf file token should be defined to enable/disable the
  code, instead of using an environment variable.

- license. Your readme has a copyright, but makes no mention of a
  license. We can only accept code with a BSD style license.

Robert