#7 Go to column in "Goto Line Number" dialog

closed-accepted
None
5
2001-11-20
2001-01-26
No

This patch adds the ability to specify an optional column in the "Goto Line Number" dialog, by appending ".colNum" to the line number. For example, "76.15" will take you to line 76, column 15. You can also jump to a column in the current line by just entering ".colNum" (ie ".15").

"Why?" you may ask...

One of the main compilers I use (IBM's C compiler for AIX) prints the line and column where errors occur. With this patch, I can go directly to the line and column where the error occurs, instead of using the dialog to go to the line and the cursor or mouse to go to the column.

Discussion

  • Richard Griswold

    None

     
  • Alexander Mai

    Alexander Mai - 2001-01-29

    Patch doesn't apply for me against current CVS version,
    but seems to work - once being applied manually.

     
  • Richard Griswold

    Original patch didn't handle the case where the column specified was greater than the line length. The latest patch fixes this problem. This patch is based on NEdit 5.1.1.

     
  • Richard Griswold

    New patch is built against CVS version. Removed some redundant logic.

     
  • Richard Griswold

    New patch is built against CVS version. Removed some redundant logic.

     
  • Scott Tringali

    Scott Tringali - 2001-02-25
    • assigned_to: nobody --> edel
     
  • Scott Tringali

    Scott Tringali - 2001-02-25
    • summary: Go to column in "Goto Line Number" dialog --> Go to column in "Goto Line Number" dialog
     
  • Scott Tringali

    Scott Tringali - 2001-02-25

    Logged In: YES
    user_id=11321

    Latest consensus seems to be not to accept this patch due,
    due to conflicts with macro language.

     
  • Scott Tringali

    Scott Tringali - 2001-03-25
    • summary: Go to column in "Goto Line Number" dialog --> Go to column in "Goto Line Number" dialog
    • status: open --> open-rejected
     
  • Scott Tringali

    Scott Tringali - 2001-03-25

    Logged In: YES
    user_id=11321

    Submitter to address Mark's issues, or it will be closed.

     
  • Richard Griswold

    • summary: Go to column in "Goto Line Number" dialog --> Go to column in "Goto Line Number" dialog
     
  • Richard Griswold

    Logged In: YES
    user_id=142294

    The latest patch addresses Mark's concerns. The main fix is
    that macro language is no longer broken. I've tested macro
    learn and replay, paste learn/replay macro, and
    goto_line_number(), and they all seem to work correctly.
    I've also removed the dependency on a specific separator
    character. Any non-numeric character can be used. I've
    also added the column support to the "Goto Selected"
    function and I've added additional text to the "Line
    Numbers" help message.

    I added the code that extracts the line and column numbers
    from the text to selection.c. I wasn't sure exactly where
    to put it, but I can move it if someone has a better place
    for it. I've also divided the code that turns the line and
    column numbers into a offset into the buffer into two
    functions: TextLineAndColToPos() in text.c and
    TextDLineAndColToPos() in textDisp.c. This seems more in
    line with existing code than my previous patch. I wrote
    TextDLineAndColToPos() since I didn't see any other
    functions to convert a line number and column to a
    position. This function is based off of xyToPos().

     
  • Scott Tringali

    Scott Tringali - 2001-03-27
    • summary: Go to column in "Goto Line Number" dialog --> Go to column in "Goto Line Number" dialog
     
  • Scott Tringali

    Scott Tringali - 2001-03-27

    Logged In: YES
    user_id=11321

    Sounds good, though I don't understand the need for a
    separator character. I think it would be a bit friendlier
    if there was a separate text field labeled "column number"
    in the UI. Otherwise, the feature is all but
    invisible to the user. Similarly, the macro routine should
    have an extra, optional parameter.

    If there is some special-case code as a shortcut from
    compiler output, I can buy that, but I think having the UI
    reflect the true functionality would be a better design.

     
  • Alexander Mai

    Alexander Mai - 2001-08-25
    • assigned_to: edel --> amai
    • summary: Go to column in "Goto Line Number" dialog --> Go to column in "Goto Line Number" dialog
    • status: open-rejected --> open-postponed
     
  • Alexander Mai

    Alexander Mai - 2001-08-25

    Logged In: YES
    user_id=15180

    I don't think a second field to enter the
    column would make it any more user-friendly.
    Let people try and complain sounds like a
    better approach to me!
    When I find time I'll try and see whether
    the patch still applies to our main trunk...

     
  • Alexander Mai

    Alexander Mai - 2001-11-20

    Logged In: YES
    user_id=15180

    Applied.

     
  • Alexander Mai

    Alexander Mai - 2001-11-20
    • summary: Go to column in "Goto Line Number" dialog --> Go to column in "Goto Line Number" dialog
    • status: open-postponed --> closed-accepted
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks