#617 calltip's ID not returned correctly

open
nobody
None
5
2008-02-06
2008-02-06
No

The built-in macro function calltip() returns calltip's ID only in tipText mode. The attached patch fixes it.

Discussion

  • Joerg Fischer

    Joerg Fischer - 2008-02-06
     
    Attachments
  • Bert Wesarg

    Bert Wesarg - 2008-02-26

    Logged In: YES
    user_id=122956
    Originator: NO

    you wrote in you devel mail:

    Therefore, I see no harm to change the return values to -2 on error, -1 for nothing found, and some number >= 0 for something found.

    But 0 is used in tips mode to indicate that nothinig was found, because calltip IDs are >= 1.

     
  • Joerg Fischer

    Joerg Fischer - 2008-02-27

    Logged In: YES
    user_id=918104
    Originator: YES

    I made that statement before I wrote the patch, and the statement is wrong.

    What the patch does is: In tips mode, return 0 on failure (i.e., nothing found) or the calltips id on success - just like the docs claim. In tags mode, return <=0 on errors or if nothing found, or > 0 if a tag was found.

     
  • Bert Wesarg

    Bert Wesarg - 2008-03-01

    Logged In: YES
    user_id=122956
    Originator: NO

    joerg can you look at my new solution for the not-found-tip in patch SF#1633136.

    Thanks.

    I will tomorrow test your patch, and report than back here.

     
  • Joerg Fischer

    Joerg Fischer - 2008-03-06

    Logged In: YES
    user_id=918104
    Originator: YES

    Updated for current CVS version.
    File Added: calltipsID2.diff

     
  • Joerg Fischer

    Joerg Fischer - 2008-03-06

    Update for current CVS

     
    Attachments

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks