#616 fix possible stack overflow in interpreter

open-fixed
nobody
Program (402)
5
2008-03-09
2008-02-06
Bert Wesarg
No

the check for stack overflow in pushSymVal() should be done before writing to the stack

Discussion

<< < 1 2 3 (Page 3 of 3)
  • Thorsten Haude

    Thorsten Haude - 2008-03-09
    • status: closed-fixed --> open-fixed
     
  • Thorsten Haude

    Thorsten Haude - 2008-03-09

    Logged In: YES
    user_id=119143
    Originator: NO

    I never checked, I assumed that you already changed ReleaseNotes.

     
  • Bert Wesarg

    Bert Wesarg - 2008-03-09

    Logged In: YES
    user_id=122956
    Originator: YES

    nope, I didn't should I, or do we do this in a bigger hunk?

     
  • Thorsten Haude

    Thorsten Haude - 2008-03-09

    Logged In: YES
    user_id=119143
    Originator: NO

    During the Big Beef someone pointed out that I did three feature commits without stating the SF patch number in the commit messages. After that I added the $NEXT_VERSION section and add my comment immediately or in a small batch for a group of recent patches. I don't see a downside.

     
  • Bert Wesarg

    Bert Wesarg - 2008-03-09

    Logged In: YES
    user_id=122956
    Originator: YES

    Ok

    BTW for this and other bugs I found, I posted the patch first to the list, than after a while (without response) I put it in the tracker. Now that I have write access, I would skip the SF entry and commit it directly, with a good commit message. I don't think that such bugs (found by a developer) should be in the ReleaseNoters

     
  • Tony Balinski

    Tony Balinski - 2008-05-14

    Logged In: YES
    user_id=618141
    Originator: NO

    A "first round" of this was committed in March. It made use of PUSH and POP macros much more consistent, but did not add the "PUSH/POP look like functions" fix Bert told us about (using a do{}while(0) to allow correct behaviour with if statements, and requiring a trailing semicolon). Can we have that final fixed stuff now please?

    Tony

     
  • Bert Wesarg

    Bert Wesarg - 2008-05-14

    Logged In: YES
    user_id=122956
    Originator: YES

    I have no problem with committing part two. I just thought that this commit wouldn't fit into the current phase of the release plan.

     
<< < 1 2 3 (Page 3 of 3)

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks