Thread: [Ndiswrapper-general] status
Status: Beta
Brought to you by:
pgiri
From: Pontus F. <pon...@ta...> - 2003-11-23 14:25:38
|
Hi, I have been flooded with patches lately which is very positive. It's a real burden to try to merge some of the monsters you have sent me so please try to follow these guidelines. * I like smaller patches adding one feature or fixing one bug. * Make sure that you make the diff against the latest CVS. * Use diff -u. I can only read unified diffs. * Please try to follow my coding-style as much as possible. Stefan: I don't like the windows-like code. I want this to look like linux-code. I'm trying to hand-merge as much as possible of your code. Please rewrite, rediff and resend any patches that I fail to merge. Keep the patches coming... Pontus |
From: Dolf S. <do...@st...> - 2003-11-24 20:21:07
|
At 06:25 AM 11/23/2003, Pontus Fuchs wrote: >Hi, > >I have been flooded with patches lately which is very positive. It's a >real burden to try to merge some of the monsters you have sent me so >please try to follow these guidelines. > >* I like smaller patches adding one feature or fixing one bug. >* Make sure that you make the diff against the latest CVS. >* Use diff -u. I can only read unified diffs. >* Please try to follow my coding-style as much as possible. > >Stefan: I don't like the windows-like code. I want this to look like >linux-code. I'm trying to hand-merge as much as possible of your code. >Please rewrite, rediff and resend any patches that I fail to merge. This one was actually meant for me. While I agree with Pontus's sentiment of making the code look more linux like, the reality is that we are actually trying to make code using an MS API work. In my many years experience (I was a BSD Unix kernel developer in 1982 and Vax and PDP-11) and have done SUN Solaris developement a lot, and then Macintosh, Windows and Java), when doing something like this there are great benefits to using the definitions for the API as is: - You can literally use the .h files, which is a lot easier than retyping everything and coming up with new names - You avoid an easy opportunity for translation mistakes - Should a new version of the API be released, you can run a diff and update your code. This becomes a 100% manual and error prone process if you have renamed everything - In a stage like the one we're in, where you are looking at other people's code, and possibly even traces of code from Windows, it is a lot easier to see identical names constants and structs on both sides of the fence and compare code and find differences. I think my embedded comment about the "evil empire" tells you enough about my love for MS coding style etc. Nevertheless, I would like Pontus to rethink this issue based on the above observations. If, after that, this is still decided unacceptable, I'll live. BTW. The windows like code is isolated to: - A single include file - Those minimal places where we have to reference the constants, and structs. All the rest can stay "linux style" >Keep the patches coming... > >Pontus > > > > >------------------------------------------------------- >This SF.net email is sponsored by: SF.net Giveback Program. >Does SourceForge.net help you be more productive? Does it >help you create better code? SHARE THE LOVE, and help us help >YOU! Click Here: http://sourceforge.net/donate/ >_______________________________________________ >Ndiswrapper-general mailing list >Ndi...@li... >https://lists.sourceforge.net/lists/listinfo/ndiswrapper-general |
From: M. A. K. <ma...@zo...> - 2003-11-24 20:35:26
|
Dolf, If indeed you don't mean to "reinvent the wheel" so to speak, then why not include the real MS provided header files instead of creating your own ms_ndis.h from scratch? You can find them easily here: http://www.microsoft.com/whdc/hwdev/tech/network/802x/80211_netadapt.mspx Dolf Starreveld wrote: > At 06:25 AM 11/23/2003, Pontus Fuchs wrote: > >> Hi, >> >> I have been flooded with patches lately which is very positive. It's a >> real burden to try to merge some of the monsters you have sent me so >> please try to follow these guidelines. >> >> * I like smaller patches adding one feature or fixing one bug. >> * Make sure that you make the diff against the latest CVS. >> * Use diff -u. I can only read unified diffs. >> * Please try to follow my coding-style as much as possible. >> >> Stefan: I don't like the windows-like code. I want this to look like >> linux-code. I'm trying to hand-merge as much as possible of your code. >> Please rewrite, rediff and resend any patches that I fail to merge. > > > This one was actually meant for me. While I agree with Pontus's sentiment > of making the code look more linux like, the reality is that we are > actually > trying to make code using an MS API work. In my many years experience > (I was > a BSD Unix kernel developer in 1982 and Vax and PDP-11) and have done SUN > Solaris developement a lot, and then Macintosh, Windows and Java), when > doing something like this there are great benefits to using the > definitions > for the API as is: > - You can literally use the .h files, which is a lot easier than retyping > everything and coming up with new names > - You avoid an easy opportunity for translation mistakes > - Should a new version of the API be released, you can run a diff and > update your code. This becomes a 100% manual and error prone process > if you have renamed everything > - In a stage like the one we're in, where you are looking at other > people's code, and possibly even traces of code from Windows, > it is a lot easier to see identical names constants and structs > on both sides of the fence and compare code and find differences. > I think my embedded comment about the "evil empire" tells you enough > about my love for MS coding style etc. Nevertheless, I would like Pontus > to rethink this issue based on the above observations. If, after that, > this is still decided unacceptable, I'll live. > BTW. The windows like code is isolated to: > - A single include file > - Those minimal places where we have to reference the constants, > and structs. All the rest can stay "linux style" > >> Keep the patches coming... >> >> Pontus >> >> >> >> >> ------------------------------------------------------- >> This SF.net email is sponsored by: SF.net Giveback Program. >> Does SourceForge.net help you be more productive? Does it >> help you create better code? SHARE THE LOVE, and help us help >> YOU! Click Here: http://sourceforge.net/donate/ >> _______________________________________________ >> Ndiswrapper-general mailing list >> Ndi...@li... >> https://lists.sourceforge.net/lists/listinfo/ndiswrapper-general > > > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: SF.net Giveback Program. > Does SourceForge.net help you be more productive? Does it > help you create better code? SHARE THE LOVE, and help us help > YOU! Click Here: http://sourceforge.net/donate/ > _______________________________________________ > Ndiswrapper-general mailing list > Ndi...@li... > https://lists.sourceforge.net/lists/listinfo/ndiswrapper-general > |
From: Jelle F. <jel...@fo...> - 2003-11-24 21:42:44
|
Hello, I can think of an important reason why not to use the MS provided header file: Maybe because that header file is not GPL-compatible? Jelle. On Mon, 2003-11-24 at 15:35, M. Adam Kendall wrote: Dolf, If indeed you don't mean to "reinvent the wheel" so to speak, then why not include the real MS provided header files instead of creating your own ms_ndis.h from scratch? You can find them easily here: http://www.microsoft.com/whdc/hwdev/tech/network/802x/80211_netadapt.mspx Dolf Starreveld wrote: > At 06:25 AM 11/23/2003, Pontus Fuchs wrote: > >> Hi, >> >> I have been flooded with patches lately which is very positive. It's a >> real burden to try to merge some of the monsters you have sent me so >> please try to follow these guidelines. >> >> * I like smaller patches adding one feature or fixing one bug. >> * Make sure that you make the diff against the latest CVS. >> * Use diff -u. I can only read unified diffs. >> * Please try to follow my coding-style as much as possible. >> >> Stefan: I don't like the windows-like code. I want this to look like >> linux-code. I'm trying to hand-merge as much as possible of your code. >> Please rewrite, rediff and resend any patches that I fail to merge. > > > This one was actually meant for me. While I agree with Pontus's sentiment > of making the code look more linux like, the reality is that we are > actually > trying to make code using an MS API work. In my many years experience > (I was > a BSD Unix kernel developer in 1982 and Vax and PDP-11) and have done SUN > Solaris developement a lot, and then Macintosh, Windows and Java), when > doing something like this there are great benefits to using the > definitions > for the API as is: > - You can literally use the .h files, which is a lot easier than retyping > everything and coming up with new names > - You avoid an easy opportunity for translation mistakes > - Should a new version of the API be released, you can run a diff and > update your code. This becomes a 100% manual and error prone process > if you have renamed everything > - In a stage like the one we're in, where you are looking at other > people's code, and possibly even traces of code from Windows, > it is a lot easier to see identical names constants and structs > on both sides of the fence and compare code and find differences. > I think my embedded comment about the "evil empire" tells you enough > about my love for MS coding style etc. Nevertheless, I would like Pontus > to rethink this issue based on the above observations. If, after that, > this is still decided unacceptable, I'll live. > BTW. The windows like code is isolated to: > - A single include file > - Those minimal places where we have to reference the constants, > and structs. All the rest can stay "linux style" > >> Keep the patches coming... >> >> Pontus >> >> >> >> >> ------------------------------------------------------- >> This SF.net email is sponsored by: SF.net Giveback Program. >> Does SourceForge.net help you be more productive? Does it >> help you create better code? SHARE THE LOVE, and help us help >> YOU! Click Here: http://sourceforge.net/donate/ >> _______________________________________________ >> Ndiswrapper-general mailing list >> Ndi...@li... >> https://lists.sourceforge.net/lists/listinfo/ndiswrapper-general > > > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: SF.net Giveback Program. > Does SourceForge.net help you be more productive? Does it > help you create better code? SHARE THE LOVE, and help us help > YOU! Click Here: http://sourceforge.net/donate/ > _______________________________________________ > Ndiswrapper-general mailing list > Ndi...@li... > https://lists.sourceforge.net/lists/listinfo/ndiswrapper-general > ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ Ndiswrapper-general mailing list Ndi...@li... https://lists.sourceforge.net/lists/listinfo/ndiswrapper-general |
From: M. A. K. <ma...@zo...> - 2003-11-24 21:55:56
|
Interesting.. perhaps you should let the cygwin, mingw32, nmap and libpcap folks know as they distribute this file along with their source code. Doesn't seem to bother them in the least. Jelle Foks wrote: >Hello, > >I can think of an important reason why not to use the MS provided header >file: Maybe because that header file is not GPL-compatible? > >Jelle. > >On Mon, 2003-11-24 at 15:35, M. Adam Kendall wrote: > Dolf, > If indeed you don't mean to "reinvent the wheel" so to speak, then why > not include the real MS provided header files instead of creating your > own ms_ndis.h from scratch? You can find them > easily here: > http://www.microsoft.com/whdc/hwdev/tech/network/802x/80211_netadapt.mspx > > > Dolf Starreveld wrote: > > > At 06:25 AM 11/23/2003, Pontus Fuchs wrote: > > > >> Hi, > >> > >> I have been flooded with patches lately which is very positive. It's a > >> real burden to try to merge some of the monsters you have sent me so > >> please try to follow these guidelines. > >> > >> * I like smaller patches adding one feature or fixing one bug. > >> * Make sure that you make the diff against the latest CVS. > >> * Use diff -u. I can only read unified diffs. > >> * Please try to follow my coding-style as much as possible. > >> > >> Stefan: I don't like the windows-like code. I want this to look like > >> linux-code. I'm trying to hand-merge as much as possible of your code. > >> Please rewrite, rediff and resend any patches that I fail to merge. > > > > > > This one was actually meant for me. While I agree with Pontus's sentiment > > of making the code look more linux like, the reality is that we are > > actually > > trying to make code using an MS API work. In my many years experience > > (I was > > a BSD Unix kernel developer in 1982 and Vax and PDP-11) and have done SUN > > Solaris developement a lot, and then Macintosh, Windows and Java), when > > doing something like this there are great benefits to using the > > definitions > > for the API as is: > > - You can literally use the .h files, which is a lot easier than retyping > > everything and coming up with new names > > - You avoid an easy opportunity for translation mistakes > > - Should a new version of the API be released, you can run a diff and > > update your code. This becomes a 100% manual and error prone process > > if you have renamed everything > > - In a stage like the one we're in, where you are looking at other > > people's code, and possibly even traces of code from Windows, > > it is a lot easier to see identical names constants and structs > > on both sides of the fence and compare code and find differences. > > I think my embedded comment about the "evil empire" tells you enough > > about my love for MS coding style etc. Nevertheless, I would like Pontus > > to rethink this issue based on the above observations. If, after that, > > this is still decided unacceptable, I'll live. > > BTW. The windows like code is isolated to: > > - A single include file > > - Those minimal places where we have to reference the constants, > > and structs. All the rest can stay "linux style" > > > >> Keep the patches coming... > >> > >> Pontus > >> > >> > >> > >> > >> ------------------------------------------------------- > >> This SF.net email is sponsored by: SF.net Giveback Program. > >> Does SourceForge.net help you be more productive? Does it > >> help you create better code? SHARE THE LOVE, and help us help > >> YOU! Click Here: http://sourceforge.net/donate/ > >> _______________________________________________ > >> Ndiswrapper-general mailing list > >> Ndi...@li... > >> https://lists.sourceforge.net/lists/listinfo/ndiswrapper-general > > > > > > > > > > > > > > ------------------------------------------------------- > > This SF.net email is sponsored by: SF.net Giveback Program. > > Does SourceForge.net help you be more productive? Does it > > help you create better code? SHARE THE LOVE, and help us help > > YOU! Click Here: http://sourceforge.net/donate/ > > _______________________________________________ > > Ndiswrapper-general mailing list > > Ndi...@li... > > https://lists.sourceforge.net/lists/listinfo/ndiswrapper-general > > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: SF.net Giveback Program. > Does SourceForge.net help you be more productive? Does it > help you create better code? SHARE THE LOVE, and help us help > YOU! Click Here: http://sourceforge.net/donate/ > _______________________________________________ > Ndiswrapper-general mailing list > Ndi...@li... >https://lists.sourceforge.net/lists/listinfo/ndiswrapper-general > > > > > > > |
From: Dolf S. <do...@st...> - 2003-11-25 15:15:10
|
At 03:35 PM 11/24/2003, M. Adam Kendall wrote: True, but.... a) I did not have a copy. I scrounged the info off the net b) The file as a whole may be copyrighted (don't know) c) Copying published information from the net does not violate copyright (I think) Either way, if we end up going this route I'll leave it up to experts to decide whether we can include the whole file. >Dolf, >If indeed you don't mean to "reinvent the wheel" so to speak, then why not >include the real MS provided header files instead of creating your own >ms_ndis.h from scratch? You can find them >easily here: >http://www.microsoft.com/whdc/hwdev/tech/network/802x/80211_netadapt.mspx > > >Dolf Starreveld wrote: > >>At 06:25 AM 11/23/2003, Pontus Fuchs wrote: >> >>>Hi, >>> >>>I have been flooded with patches lately which is very positive. It's a >>>real burden to try to merge some of the monsters you have sent me so >>>please try to follow these guidelines. >>> >>>* I like smaller patches adding one feature or fixing one bug. >>>* Make sure that you make the diff against the latest CVS. >>>* Use diff -u. I can only read unified diffs. >>>* Please try to follow my coding-style as much as possible. >>> >>>Stefan: I don't like the windows-like code. I want this to look like >>>linux-code. I'm trying to hand-merge as much as possible of your code. >>>Please rewrite, rediff and resend any patches that I fail to merge. >> >> >>This one was actually meant for me. While I agree with Pontus's sentiment >>of making the code look more linux like, the reality is that we are actually >>trying to make code using an MS API work. In my many years experience (I was >>a BSD Unix kernel developer in 1982 and Vax and PDP-11) and have done SUN >>Solaris developement a lot, and then Macintosh, Windows and Java), when >>doing something like this there are great benefits to using the definitions >>for the API as is: >>- You can literally use the .h files, which is a lot easier than retyping >> everything and coming up with new names >>- You avoid an easy opportunity for translation mistakes >>- Should a new version of the API be released, you can run a diff and >> update your code. This becomes a 100% manual and error prone process >> if you have renamed everything >>- In a stage like the one we're in, where you are looking at other >> people's code, and possibly even traces of code from Windows, >> it is a lot easier to see identical names constants and structs >> on both sides of the fence and compare code and find differences. >>I think my embedded comment about the "evil empire" tells you enough >>about my love for MS coding style etc. Nevertheless, I would like Pontus >>to rethink this issue based on the above observations. If, after that, >>this is still decided unacceptable, I'll live. >>BTW. The windows like code is isolated to: >>- A single include file >>- Those minimal places where we have to reference the constants, >> and structs. All the rest can stay "linux style" >> >>>Keep the patches coming... >>> >>>Pontus >>> >>> >>> >>> >>>------------------------------------------------------- >>>This SF.net email is sponsored by: SF.net Giveback Program. >>>Does SourceForge.net help you be more productive? Does it >>>help you create better code? SHARE THE LOVE, and help us help >>>YOU! Click Here: http://sourceforge.net/donate/ >>>_______________________________________________ >>>Ndiswrapper-general mailing list >>>Ndi...@li... >>>https://lists.sourceforge.net/lists/listinfo/ndiswrapper-general >> >> >> >> >> >> >>------------------------------------------------------- >>This SF.net email is sponsored by: SF.net Giveback Program. >>Does SourceForge.net help you be more productive? Does it >>help you create better code? SHARE THE LOVE, and help us help >>YOU! Click Here: http://sourceforge.net/donate/ >>_______________________________________________ >>Ndiswrapper-general mailing list >>Ndi...@li... >>https://lists.sourceforge.net/lists/listinfo/ndiswrapper-general > > > >------------------------------------------------------- >This SF.net email is sponsored by: SF.net Giveback Program. >Does SourceForge.net help you be more productive? Does it >help you create better code? SHARE THE LOVE, and help us help >YOU! Click Here: http://sourceforge.net/donate/ >_______________________________________________ >Ndiswrapper-general mailing list >Ndi...@li... >https://lists.sourceforge.net/lists/listinfo/ndiswrapper-general |