Thread: Re: [Ndiswrapper-general] Issues with release 0.4 (Page 2)
Status: Beta
Brought to you by:
pgiri
From: Giridhar P. <gi...@lm...> - 2004-01-08 17:30:44
|
I take back my comment that your patch is wrong. I didn't see that at the bottom you modify if_name to wlan%d; I saw only the top where you register_netdev (due to small window size I am using in xemacs). Anyway, in that case making if_name to basname is a good idea, but this causes confusion. Giri. |
From: Martin W. <mar...@nt...> - 2004-01-08 18:49:37
|
Giridhar Pemmasani wrote: > I take back my comment that your patch is wrong. I didn't see that at > the bottom you modify if_name to wlan%d; I saw only the top where you > register_netdev (due to small window size I am using in > xemacs). Anyway, in that case making if_name to basname is a good > idea, but this causes confusion. I split my patch into three parts, as they can be applied independantly - sorry if this caused confusion. Did you see the third one (which is completely separate from the subject under discussion - I just spotted what looks like a minor bug while making the other changes)? The nice thing is that the patched code supports both fixed and template based interface names. So if a user really needs a fixed name, they can have it, either by modifying wrapper.c, or by adding an options statement in modules.conf Because 'if_name' can either be a fixed name or a template, I think it is best to stick with that as the variable name, rather than going back to 'basename'. If you think this will cause confusion, you could change MODULE_PARM_DESC(if_name, "Network interface name (default: wlan%d)"); to MODULE_PARM_DESC(if_name, "Network interface name (fixed name or template) (default: wlan%d)"); Martin |
From: Giridhar P. <gi...@lm...> - 2004-01-08 19:07:07
|
I totally agree with you; this is a good solution. I myself would like to commit this. Let us wait to see if others have any objections to it (I doubt). Moreover, I am in the middle of committing support for realtek based cards. Once that is done, I will come back to it. Thanks, Giri |
From: Timo <ti...@ti...> - 2004-01-08 19:46:15
|
=2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > I totally agree with you; this is a good solution. I myself would like > to commit this. >=20 > Let us wait to see if others have any objections to it (I doubt). why don't we use two parameters: =2D - basename: append %d to parameter =2D - if_name: use as is they should then be excluding each other. that way the use can have automatic number assignment without having to append %d (that's why basename was introduced) or a fixed device name. Timo =2D----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iQEVAwUBP/2ze0n74FOC+06tAQJJDQf9HG8U7yqRWdAZzIjE/iEPjInEh6e/r1DZ cJBU2o8Nn3HZFtcbz3M4RMQYPZ2qTN25g46/YOBMMtH/jLmQ20Od+7cS0ydem3ST +H0afdf2iyhfXDaCNzkhFDg0oGncCGeN3T62mSg3eSCeUdcj5MkjYXmzTARmsF02 0xxKPyoKLVUJ/J7GKH29gDIxli+iEBTxlzansay1WMWMq6zzE7yQuUCID3JrxGb3 cNRIHlKH5qT26cVfQzQi6LI/lODkjTjau6U9STLbKxEIYE0vJfkRx2IlJplC/eWj K9dOyKZhiP2ZNXxAbT1KftSmAf6VQkVn5sDXqQ7UGiwwtJJcufIPzQ=3D=3D =3DcVEm =2D----END PGP SIGNATURE----- |
From: Tomas S. <sz...@pi...> - 2004-01-08 23:10:30
|
On Jan-08 2004, Thu, 14:06 -0500 Giridhar Pemmasani <gi...@lm...> wrote: > I totally agree with you; this is a good solution. I myself would like > to commit this. > > Let us wait to see if others have any objections to it (I doubt). BUT, what's *the default* going to be? It definitely has to be a template name, for the reasons I've listed in my other posts. -- Tomas Szepe <sz...@pi...> |
From: Giridhar P. <gi...@lm...> - 2004-01-09 00:43:55
|
Patches applied with slight modifications noted below: |> + res = register_netdev(dev); |> printk(KERN_INFO "%s: %s ethernet device " |> "%02x:%02x:%02x:%02x:%02x:%02x\n", |> name, DRV_NAME, |> mac[0], mac[1], mac[2], mac[3], mac[4], mac[5]); |> - return register_netdev(dev); |> + return res; |> } If register_netdev fails, appropriate error message is printed. |> -MODULE_PARM_DESC(if_name, "Network interface name (default: wlan0)"); |> +MODULE_PARM_DESC(if_name, "Network interface name (default: wlan%d)"); The description is changed to "Network interface name or template" |> - if (strlen(if_name) > (IFNAMSIZ-2)) |> + if (strlen(if_name) > (IFNAMSIZ-1)) |> { |> printk(KERN_ERR "%s: interface name '%s' is too long\n", |> DRV_NAME, if_name); |> return -1; |> } |> - strncpy(dev->name, if_name, IFNAMSIZ-2); |> + strncpy(dev->name, if_name, IFNAMSIZ-1); |> name[IFNAMSIZ-1] = '\0'; Applied. Thanks for the patches! -- Giri |