#41 1.11 ncidd.blacklist Issue

[Anonymous]

If the final line in the ncidd.blacklist file does not end in a comment the service will not start.

Mar 04 16:19:51 ncid systemd[1]: Starting Network Caller ID server...
Mar 04 16:19:51 ncid systemd[1]: ncidd.service: Control process exited, code=exited status=11
Mar 04 16:19:51 ncid systemd[1]: Failed to start Network Caller ID server.
Mar 04 16:19:51 ncid systemd[1]: ncidd.service: Unit entered failed state.
Mar 04 16:19:51 ncid systemd[1]: ncidd.service: Failed with result 'exit-code'.

ncidd.log with no final line with a comment

A final dummy line that ends in a comment will get the server to start.
"..............." # No Final Comment Bug 1.11

Started: 03/04/2020 16:29:03
Server: ncidd (NCID) 1.11
API: 1.10 Feature Set 1 2 3 4 5
Sysname: Linux
Nodename: ncid
Machine: armv6l
Release: 4.19.66+
Version: #1253 Thu Aug 15 11:37:30 BST 2019
Command line: /usr/sbin/ncidd
--pidfile /run/ncidd.pid
Logfile: /var/log/ncidd.log
Processed config file: /etc/ncid/ncidd.conf
Verbose level: 7
cidinput = 0
sendinfo = 1
Configured to send 'cidlog' to clients.
Configured to send 'cidinfo' to clients.
Helper tools:
/usr/bin/cidupdate
/usr/bin/ncidutil
Using simple expressions for alias/blacklist/whitelist entries

Begin: Loading alias, blacklist and whitelist files [16:29:03]
Processed alias file: /etc/ncid/ncidd.alias
Alias Table:
Number of Entries: 0
Processed blacklist file: /etc/ncid/ncidd.blacklist
Blacklist Table:
Number of Entries: 29
SLOT ENTRY MATCH NAME
---- ----- ----------
000 "^1?999"
001 "^1?264"
002 "^1?268"
003 "^1?284"
004 "^1?273"
005 "^1?345"
006 "^1?441"
007 "^1?473"
008 "^1?649"
009 "^1?658"
010 "^1?664"
011 "^1?758"
012 "^1?767"
013 "^1?784"
014 "^1?876"
015 "^1?809"
016 "^1?829"
017 "^1?849"
018 "^1?900"
019 "MIDDLETOWN NJ"
020 "732706"
021 "FREEHOLD NJ"
022 "PERSONAL"
023 "CAPITA"
024 "SPAM?"
025 "800"
026 "Service"
027 "NJ$"
028 "ASBURYPARKPRESS"
Calls in the blacklist file will be terminated

[Ed Attfield]

Quite right, that's really odd.

Not just the last line in the file, but the last blacklist entry, even if followed by comment lines.

The whitelist file is not affected the same way.

[Ed Attfield]

By some accident, the ncidd.whitelist that comes with 1.11 has a second line that contains a single tab character.

The parser for blacklist and whitelist do not handle lines with only white space properly, so that the results are somewhat erratic., with some input leftover from the previous line. When the leftover is '#' the blank line is treated as a comment, otherwise it exits with a Segmentation fault.

You can recreate the error by adding three lines to the blacklist, with the middle line being a few spaces or tabs:

41612345678
       <-- some spaces
 4161237890

[Anonymous]

Thank you! So this was always there.
I thought it has something to do with the parser changing for the new $ feature. I turned debugging on, looked at the code but nothing jumped out.

[Anonymous]

Reassuring to see this reported, I'm facing the same issue. I thought it was me not understanding the blackilst file format. For the time being I'm just adding lines higher up.

[Ed Attfield]

the starter ncidd.whitelist, ncidd and cidupdate have been fixed for the next release.