Menu

#4 isnan does not take integers as input

v1.0_(example)
closed
None
1
2017-02-24
2017-01-25
Anonymous
No

I experienced a build error when building nccmp with gcc 6.3.1 on Fedora 24. I get a long list of the following errors during the build:
nccmp_data.c:3460:9: error: non-floating-point argument in call to function ‘__builtin_isnan’

A solution (inspired on https://github.com/torch/torch7/issues/355) is to cast the inputs of the isnan() calls in src/nccmp_data.c explicitely to a double in all 12 calls in this file. After that change the build runs fine again, and all checks pass.
The attached patch shows how I did it.

1 Attachments

Discussion

  • Jos de Kloe

    Jos de Kloe - 2017-01-25

    forgot to login, so another line just to be able to track this issue.

     
  • Anonymous

    Anonymous - 2017-02-06
    Post awaiting moderation.
  • Remik Ziemlinski

    Thanks for your input. I released v1.8.2.1 that fixes it. If you don't mind, I gave you credit on the project home page.

     
  • Remik Ziemlinski

    • status: open --> closed
    • assigned_to: Remik Ziemlinski
     
  • Jos de Kloe

    Jos de Kloe - 2017-02-24

    Thanks, glad I could help, and ofcourse I don't mind to be mentioned.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB