nasm-devel — NASM development work

[Nasm-devel] [PATCH] asm: Always check the size of address is sitting inside bounds

[Cyrill G. <gor...@gm...>]

In particular

 | call 0xdeadbeef12345678

should warn a user about address cutoff.

https://bugzilla.nasm.us/show_bug.cgi?id=3392422

Signed-off-by: Cyrill Gorcunov <gor...@gm...>
---

Peter, I don't get why we check for address not being overflowed
under _if_ condition only, looks like a bug for me, no?

 asm/assemble.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/asm/assemble.c b/asm/assemble.c
index 6d3e25e..e81354f 100644
--- a/asm/assemble.c
+++ b/asm/assemble.c
@@ -374,8 +374,8 @@ static void out(struct out_data *data)
         nasm_assert(data->size <= 8);
         asize = data->size;
         amax = ofmt->maxbits >> 3; /* Maximum address size in bytes */
+        warn_overflow_out(addrval, asize, data->sign);
         if (data->tsegment == fixseg && data->twrt == NO_SEG) {
-            warn_overflow_out(addrval, asize, data->sign);
             xdata.q = cpu_to_le64(addrval);
             data->data = xdata.b;
             data->type = OUT_RAWDATA;
-- 
2.7.5

[Nasm-devel] [PATCH] preproc: Add found files to the list of dependencies even when cached

[Martin S. <ma...@ma...>]

This fixes the dependency listings as generated with -MD (if assembling
runs in multiple passes?).

https://bugzilla.nasm.us/show_bug.cgi?id=3392420
---
 asm/preproc.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/asm/preproc.c b/asm/preproc.c
index 0d0e1040..94e9a798 100644
--- a/asm/preproc.c
+++ b/asm/preproc.c
@@ -1574,6 +1574,14 @@ static FILE *inc_fopen(const char *file,
     hp = hash_find(&FileHash, file, &hi);
     if (hp) {
         path = *hp;
+        if (path || omode != INC_NEEDED) {
+            const char *name = path ? path : file;
+            size_t name_len = strlen(name);
+            sl = nasm_malloc(name_len + sizeof sl->next);
+            memcpy(sl->str, name, name_len+1);
+            sl->next = NULL;
+            nasm_add_to_strlist(dhead, sl);
+        }
     } else {
         /* Need to do the actual path search */
         size_t file_len;
-- 
2.11.0 (Apple Git-81)

[Nasm-devel] [PATCHv2] preproc: Add found files to the list of dependencies even when cached

[Martin S. <ma...@ma...>]

This fixes the dependency listings as generated with -MD (if assembling
runs in multiple passes?).

https://bugzilla.nasm.us/show_bug.cgi?id=3392420

Signed-off-by: Martin Storsjö <ma...@ma...>
---
Resending with the signed-off-by.
---
 asm/preproc.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/asm/preproc.c b/asm/preproc.c
index 0d0e1040..94e9a798 100644
--- a/asm/preproc.c
+++ b/asm/preproc.c
@@ -1574,6 +1574,14 @@ static FILE *inc_fopen(const char *file,
     hp = hash_find(&FileHash, file, &hi);
     if (hp) {
         path = *hp;
+        if (path || omode != INC_NEEDED) {
+            const char *name = path ? path : file;
+            size_t name_len = strlen(name);
+            sl = nasm_malloc(name_len + sizeof sl->next);
+            memcpy(sl->str, name, name_len+1);
+            sl->next = NULL;
+            nasm_add_to_strlist(dhead, sl);
+        }
     } else {
         /* Need to do the actual path search */
         size_t file_len;
-- 
2.11.0 (Apple Git-81)

Re: [Nasm-devel] Make buildsystem adhere to GNU conventions

[Cyrill G. <gor...@gm...>]

On Mon, Jul 03, 2017 at 09:52:21AM +0300, Cyrill Gorcunov wrote:
> On Sun, Jul 02, 2017 at 12:55:55PM -0700, David Seifert wrote:
> > Hi nasmers,
> > I've fixed the build system such that it adheres to the GNU conventions
> > more strictly. This is to 1) respect user choice (CPPFLAGS, docdir,
> > htmldir) and 2) to make it easier for distros to prepare the package
> > (DESTDIR is the universal standard for the staging dir variable).
> 
> Thanks, David! Will take a look today.

OK, I like it, thank you! There is a nit with DESTDIR -- we need
to update nasm.spec as well, but I'll do it on top. Anyway, gonna
commit it up in a few days.

	Cyrill

Re: [Nasm-devel] Make buildsystem adhere to GNU conventions

[Cyrill G. <gor...@gm...>]

On Sun, Jul 02, 2017 at 12:55:55PM -0700, David Seifert wrote:
> Hi nasmers,
> I've fixed the build system such that it adheres to the GNU conventions
> more strictly. This is to 1) respect user choice (CPPFLAGS, docdir,
> htmldir) and 2) to make it easier for distros to prepare the package
> (DESTDIR is the universal standard for the staging dir variable).
> 

Thanks, David! Will take a look today.

[Nasm-devel] Make buildsystem adhere to GNU conventions

[David S. <so...@ge...>]

Hi nasmers,
I've fixed the build system such that it adheres to the GNU conventions
more strictly. This is to 1) respect user choice (CPPFLAGS, docdir,
htmldir) and 2) to make it easier for distros to prepare the package
(DESTDIR is the universal standard for the staging dir variable).

Regards
David

[Nasm-devel] [PATCH 2/2] doc/psfonts.ph: Add liberation font options for all styles

[Jordan J. <jor...@in...>]

Signed-off-by: Jordan Justen <jor...@in...>
---
 doc/psfonts.ph | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/doc/psfonts.ph b/doc/psfonts.ph
index c33db8b8..2e34d845 100644
--- a/doc/psfonts.ph
+++ b/doc/psfonts.ph
@@ -10,10 +10,11 @@ my @TItal = ('SourceSansPro-BoldIt', 'ClearSans-BoldItalic',
 	     'LiberationSans-BoldItalic', 'Arial-BoldItalic',
 	     'Helvetica-BoldItalic');
 my @TCode = ('SourceCodePro-Bold', 'LiberationMono-Bold', 'Courier-Bold');
-my @HText = ('SourceSansPro-Semibold', 'ClearSans-Bold', 'Arial-Bold',
-	     'Helvetica-Bold');
-my @HItal = ('SourceSansPro-SemiboldIt', 'ClearSans-BoldItalic',
-	     'Arial-BoldItalic', 'Helvetica-BoldItalic');
+my @HText = ('SourceSansPro-Semibold', 'LiberationMono-Bold', 'ClearSans-Bold',
+	     'Arial-Bold', 'Helvetica-Bold');
+my @HItal = ('SourceSansPro-SemiboldIt', 'LiberationMono-BoldItalic',
+	     'ClearSans-BoldItalic', 'Arial-BoldItalic',
+	     'Helvetica-BoldItalic');
 my @HCode = ('SourceCodePro-Semibold', 'LiberationMono-Bold', 'Courier-Bold');
 my @BText = ('SourceSansPro-Regular', 'ClearSans', 'LiberationSans', 'Arial',
 	     'Helvetica');
-- 
2.11.0

[Nasm-devel] [PATCH 1/2] doc/psfonts.ph: Reflow lines to less than 80 columns

[Jordan J. <jor...@in...>]

Signed-off-by: Jordan Justen <jor...@in...>
---
 doc/psfonts.ph | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/doc/psfonts.ph b/doc/psfonts.ph
index 093d9dc4..c33db8b8 100644
--- a/doc/psfonts.ph
+++ b/doc/psfonts.ph
@@ -6,20 +6,25 @@
 # Font substitution lists, in order of preference
 my @TText = ('SourceSansPro-Bold', 'ClearSans-Bold', 'LiberationSans-Bold',
 	     'Arial-Bold', 'Helvetica-Bold');
-my @TItal = ('SourceSansPro-BoldIt', 'ClearSans-BoldItalic', 'LiberationSans-BoldItalic',
-	     'Arial-BoldItalic', 'Helvetica-BoldItalic');
+my @TItal = ('SourceSansPro-BoldIt', 'ClearSans-BoldItalic',
+	     'LiberationSans-BoldItalic', 'Arial-BoldItalic',
+	     'Helvetica-BoldItalic');
 my @TCode = ('SourceCodePro-Bold', 'LiberationMono-Bold', 'Courier-Bold');
-my @HText = ('SourceSansPro-Semibold', 'ClearSans-Bold', 'Arial-Bold', 'Helvetica-Bold');
+my @HText = ('SourceSansPro-Semibold', 'ClearSans-Bold', 'Arial-Bold',
+	     'Helvetica-Bold');
 my @HItal = ('SourceSansPro-SemiboldIt', 'ClearSans-BoldItalic',
 	     'Arial-BoldItalic', 'Helvetica-BoldItalic');
 my @HCode = ('SourceCodePro-Semibold', 'LiberationMono-Bold', 'Courier-Bold');
-my @BText = ('SourceSansPro-Regular', 'ClearSans', 'LiberationSans', 'Arial', 'Helvetica');
+my @BText = ('SourceSansPro-Regular', 'ClearSans', 'LiberationSans', 'Arial',
+	     'Helvetica');
 my @BItal = ('SourceSansPro-It', 'ClearSans-Italic', 'LiberationSans-Italic',
 	     'Arial-Italic', 'Helvetica-Italic');
 my @BCode = ('SourceCodePro-Regular', 'LiberationMono', 'Courier');
 my @QText = ('SourceSansPro-It', 'ClearSans-Italic', 'LiberationSans-Italic',
 	     'Arial-Italic', 'Helvetica-Italic');
-my @QBold = ('SourceSansPro-BoldIt', 'ClearSans-BoldItalic', 'LiberationSans-BoldItalic', 'Arial-Bold', 'Helvetica-BoldItalic');
+my @QBold = ('SourceSansPro-BoldIt', 'ClearSans-BoldItalic',
+	     'LiberationSans-BoldItalic', 'Arial-Bold',
+	     'Helvetica-BoldItalic');
 my @QCode = ('SourceCodePro-Regular', 'LiberationMono', 'Courier');
 
 # The fonts we want to use for various things
-- 
2.11.0

Re: [Nasm-devel] [PATCH] Use cpu_to_le64 instead of htole64

[Henrik G. <he...@gr...>]

On Mon, May 22, 2017 at 12:54 PM, Martin Storsjö <ma...@ma...> wrote:
> This fixes compilation on macOS.

I might add that it fixes compilation on MSYS2 (and likely some other
platforms) as well.

[Nasm-devel] [PATCH] Use cpu_to_le64 instead of htole64

[Martin S. <ma...@ma...>]

This fixes compilation on macOS.

Signed-off-by: Martin Storsjö <ma...@ma...>
---
 asm/assemble.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/asm/assemble.c b/asm/assemble.c
index 4f9cead2..6fd80274 100644
--- a/asm/assemble.c
+++ b/asm/assemble.c
@@ -375,7 +375,7 @@ static void out(struct out_data *data)
         amax = ofmt->maxbits >> 3; /* Maximum address size in bytes */
         if (data->tsegment == fixseg && data->twrt == NO_SEG) {
             warn_overflow_out(addrval, asize, data->sign);
-            xdata.q = htole64(addrval);
+            xdata.q = cpu_to_le64(addrval);
             data->data = xdata.b;
             data->type = OUT_RAWDATA;
             asize = amax = 0;   /* No longer an address */
-- 
2.11.0 (Apple Git-81)

Re: [Nasm-devel] NASM 2.13 released

[H. P. A. <hp...@zy...>]

On 05/02/17 18:01, anonymous coward wrote:
>> You are missing the Perl module Font::TTF, and it looks like you are also missing asciidoc+xmlto.
> 
> since only nasm wants these, I'm unlikely to
> fiddle with them... and in a corporate setting
> folks might be unable to convince admins to
> permit and/or support them
> 
> can we go back to not requiring these? if not,
> then switch to pre-built documentation similar
> to pre-built insns.dat stuff... plus dependency
> checks/warnings during make

It's not really possible, because modern font files don't have separate
font metrics files -- which quite frankly were an insane idea to begin
with.

None of these should be necessary to install as root/Administrator; if
that is the case on any platform we should fix it.

Font::TTF, like other Perl modules, is available from CPAN which has a
standard way of installing, if it isn't available with your distribution.

In Fedora 25, these packages seem to depend on Font::TTF:

perl(Font::TTF::Font) is needed by fontpackages-tools-1.44-17.fc24.noarch
perl(Font::TTF::Font) is needed by perl-Text-PDF-0.29a-20.fc25.noarch
perl(Font::TTF::Font) >= 0.23 is needed by (installed)
perl-Text-PDF-0.29a-20.fc25.noarch
perl(Font::TTF::Font) is needed by (installed)
perl-PDF-API2-2.031-1.fc25.noarch

On other Unix systems there is a "cpan" command that installs with Perl.

StrawberryPerl for Windows comes with a CPAN install client GUI; not
sure if it also has the "cpan" command.

	-hpa

Re: [Nasm-devel] NASM 2.13 released

[<hp...@zy...>]

On May 2, 2017 6:01:30 PM PDT, anonymous coward <nas...@us...> wrote:
>> You are missing the Perl module Font::TTF, and it looks like you are
>also missing asciidoc+xmlto.
>
>since only nasm wants these, I'm unlikely to
>fiddle with them... and in a corporate setting
>folks might be unable to convince admins to
>permit and/or support them
>
>can we go back to not requiring these? if not,
>then switch to pre-built documentation similar
>to pre-built insns.dat stuff... plus dependency
>checks/warnings during make

The documentation is available prebuilt as nasm-xxxx-xdoc.* on nasm.us.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Re: [Nasm-devel] NASM 2.13 released

[anonymous c. <nas...@us...>]

> You are missing the Perl module Font::TTF, and it looks like you are also missing asciidoc+xmlto.

since only nasm wants these, I'm unlikely to
fiddle with them... and in a corporate setting
folks might be unable to convince admins to
permit and/or support them

can we go back to not requiring these? if not,
then switch to pre-built documentation similar
to pre-built insns.dat stuff... plus dependency
checks/warnings during make

Re: [Nasm-devel] NASM 2.13 released

[<hp...@zy...>]

On May 1, 2017 9:11:12 AM PDT, anonymous coward <nas...@us...> wrote:
>> Using OS X, the documentation fails to build,
>> with a couple of issues.
>
>> make: *** [nasm.xml] Error 1
>
>> cp: illegal option -- u
>
>more (while trying to make step-by-step progress]:
>
>#  make nasmdoc.pdf
>perl -I. ./inslist.pl ./../x86/insns.dat
>Reading insns.dat...
>Writing inslist.src...
>Done: 5050 instructions
>perl -I. ../version.pl docsrc \
>		< ../version > version.src
>perl -I. ./rdsrc.pl -I./ dip nasmdoc.src
>Reading input...done.
>Fixing up cross-references...done.
>Sorting index tags...done.
>Producing Documentation Intermediate Paragraphs: done.
>perl -I. ./genps.pl -epsdir "." \
>		-headps ./head.ps nasmdoc.dip \
>		> nasmdoc.ps
>Can't locate Font/TTF/Font.pm in @INC (you may need to install the
>Font::TTF::Font module) (@INC contains: .
>/Library/Perl/5.18/darwin-thread-multi-2level /Library/Perl/5.18
>/Network/Library/Perl/5.18/darwin-thread-multi-2level
>/Network/Library/Perl/5.18 /Library/Perl/Updates/5.18.2
>/System/Library/Perl/5.18/darwin-thread-multi-2level
>/System/Library/Perl/5.18
>/System/Library/Perl/Extras/5.18/darwin-thread-multi-2level
>/System/Library/Perl/Extras/5.18 .) at ttfmetrics.ph line 3.
>BEGIN failed--compilation aborted at ttfmetrics.ph line 3.
>Compilation failed in require at findfont.ph line 47.
>Compilation failed in require at ./genps.pl line 43.
>make: *** [nasmdoc.ps] Error 2

You are missing the Perl module Font::TTF, and it looks like you are also missing asciidoc+xmlto.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Re: [Nasm-devel] NASM 2.13 released

[anonymous c. <nas...@us...>]

> Using OS X, the documentation fails to build,
> with a couple of issues.

> make: *** [nasm.xml] Error 1

> cp: illegal option -- u

more (while trying to make step-by-step progress]:

#  make nasmdoc.pdf
perl -I. ./inslist.pl ./../x86/insns.dat
Reading insns.dat...
Writing inslist.src...
Done: 5050 instructions
perl -I. ../version.pl docsrc \
		< ../version > version.src
perl -I. ./rdsrc.pl -I./ dip nasmdoc.src
Reading input...done.
Fixing up cross-references...done.
Sorting index tags...done.
Producing Documentation Intermediate Paragraphs: done.
perl -I. ./genps.pl -epsdir "." \
		-headps ./head.ps nasmdoc.dip \
		> nasmdoc.ps
Can't locate Font/TTF/Font.pm in @INC (you may need to install the
Font::TTF::Font module) (@INC contains: .
/Library/Perl/5.18/darwin-thread-multi-2level /Library/Perl/5.18
/Network/Library/Perl/5.18/darwin-thread-multi-2level
/Network/Library/Perl/5.18 /Library/Perl/Updates/5.18.2
/System/Library/Perl/5.18/darwin-thread-multi-2level
/System/Library/Perl/5.18
/System/Library/Perl/Extras/5.18/darwin-thread-multi-2level
/System/Library/Perl/Extras/5.18 .) at ttfmetrics.ph line 3.
BEGIN failed--compilation aborted at ttfmetrics.ph line 3.
Compilation failed in require at findfont.ph line 47.
Compilation failed in require at ./genps.pl line 43.
make: *** [nasmdoc.ps] Error 2

Re: [Nasm-devel] NASM 2.13 released

[anonymous c. <nas...@us...>]

> I have -- finally -- released NASM 2.13.

Using OS X, the documentation fails to build,
with a couple of issues.

# git clone git://repo.or.cz/nasm.git nasm
# cd nasm
# sh autogen.sh
# sh configure
# make everything
...
false -b docbook -d manpage -o nasm.xml nasm.txt
make: *** [nasm.xml] Error 1

# make -n everything
false -b docbook -d manpage -o nasm.xml nasm.txt
false man --skip-validation nasm.xml 2>/dev/null
false -b docbook -d manpage -o ndisasm.xml ndisasm.txt
false man --skip-validation ndisasm.xml 2>/dev/null
cd doc && /Library/Developer/CommandLineTools/usr/bin/make all
mkdir -p html
for f in nasmdoc.css local.css nasmlogw.png; do cp -ufv "./$f" html/; done
/Library/Developer/CommandLineTools/usr/bin/make html/nasmdoc0.html
perl -I. ./inslist.pl ./../x86/insns.dat
perl -I. ../version.pl docsrc \
		< ../version > version.src
rm -f html/*.html
perl -I. ./rdsrc.pl -I./ -ohtml html nasmdoc.src
perl -I. ./inslist.pl ./../x86/insns.dat
perl -I. ../version.pl docsrc \
		< ../version > version.src
perl -I. ./rdsrc.pl -I./ txt nasmdoc.src
perl -I. ./rdsrc.pl -I./ dip nasmdoc.src
perl -I. ./genps.pl -epsdir "." \
		-headps ./head.ps nasmdoc.dip \
		> nasmdoc.ps
perl -I. ./pspdf.pl  nasmdoc.ps nasmdoc.pdf
rm nasm.xml ndisasm.xml

[not really sure what the nasa.xml problem is]

# cd doc

# make all
mkdir -p html
for f in nasmdoc.css local.css nasmlogw.png; do cp -ufv "./$f" html/; done
cp: illegal option -- u
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file ...
target_directory
cp: illegal option -- u
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file ...
target_directory
cp: illegal option -- u
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file ...
target_directory
make: *** [html] Error 64

# man cp
[confirms that -u isn't supported under OS X]

[Nasm-devel] NASM 2.13 released

[H. P. A. <hp...@zy...>]

Hi all,

I have -- finally -- released NASM 2.13.  This is now the recommended
production version of NASM.

Accordingly, there is now a nasm-2.13.xx maintenance branch, and the
master branch is now once again a development branch.  The development
branch has been tagged 2.14rc0 to indicate that it is logically newer
than the 2.13 maintenance branch.


>  C.1.1 Version 2.13
> 
>        (*) Support the official forms of the `UD0' and `UD1' instructions.
> 
>        (*) Allow self-segment-relative expressions in immediates and
>            displacements, even when combined with an external or otherwise
>            out-of-segment special symbol, e.g.:
> 
>             extern foo 
>             mov eax,[foo - $ + ebx]               ; Now legal
> 
>        (*) Handle a 64-bit origin in NDISASM.
> 
>        (*) NASM can now generate sparse output files for relevant output
>            formats, if the underlying operating system supports them.
> 
>        (*) The `macho' object format now supports the
>            `subsections_via_symbols' and `no_dead_strip' directives, see
>            section 7.8.4.
> 
>        (*) The `macho' object format now supports the `no_dead_strip',
>            `live_support' and `strip_static_syms' section flags, see
>            section 7.8.1.
> 
>        (*) The `macho' object format now supports the `dwarf' debugging
>            format, as required by newer toolchains.
> 
>        (*) All warnings can now be suppressed if desired; warnings not
>            otherwise part of any warning class are now considered its own
>            warning class called `other' (e.g. `-w-other'). Furthermore,
>            warning-as-error can now be controlled on a per warning class
>            basis, using the syntax `-w+error='_warning-class_ and its
>            equivalent for all other warning control options. See section
>            2.1.24 for the command-line options and warning classes and
>            section 6.10 for the `[WARNING]' directive.
> 
>        (*) Fix a number of bugs related to AVX-512 decorators.
> 
>        (*) Significant improvements to building NASM with Microsoft Visual
>            Studio via `Mkfiles/msvc.mak'. It is now possible to build the
>            full Windows installer binary as long as the necessary
>            prerequisites are installed; see `Mkfiles/README'
> 
>        (*) To build NASM with custom modifications (table changes) or from
>            the git tree now requires Perl 5.8 at the very minimum, quite
>            possibly a higher version (Perl 5.24.1 tested.) There is no
>            requirement to have Perl on your system at all if all you want
>            to do is build unmodified NASM from source archives.
> 
>        (*) Fix the `{z}' decorator on AVX-512 `VMOVDQ*' instructions.
> 
>        (*) Add new warnings for certain dangerous constructs which never
>            ought to have been allowed. In particular, the `RESB' family of
>            instructions should have been taking a critical expression all
>            along.
> 
>        (*) Fix the EVEX (AVX-512) versions of the `VPBROADCAST', `VPEXTR',
>            and `VPINSR' instructions.
> 
>        (*) Support contracted forms of additional instructions. As a
>            general rule, if an instruction has a non-destructive source
>            immediately after a destination register that isn't used as an
>            input, NASM supports omitting that source register, using the
>            destination register as that value. This among other things
>            makes it easier to convert SSE code to the equivalent AVX code:
> 
>             addps xmm1,xmm0                       ; SSE instruction 
>             vaddps ymm1,ymm1,ymm0                 ; AVX official long form 
>             vaddps ymm1,ymm0                      ; AVX contracted form
> 
>        (*) Fix Codeview malformed compiler version record.
> 
>        (*) Add the `CLWB' and `PCOMMIT' instructions. Note that the
>            `PCOMMIT' instruction has been deprecated and will never be
>            included in a shipping product; it is included for completeness
>            only.
> 
>        (*) Add the `%pragma' preprocessor directive.
>
>        (*) Add the `RDPID' instruction.
> 

Re: [Nasm-devel] [PATCH] Fix ModR/M.mod for EVEX instructions

[<hp...@zy...>]

On April 20, 2017 7:02:19 AM PDT, Henrik Gramner <he...@gr...> wrote:
>It was incorrectly set to 01b in some cases when where it should be
>10b.
>
>Fixes BR 3392402.
>
>Signed-off-by: Henrik Gramner <he...@gr...>
>---
>This fixes things for my use case, but it'd be great if someone more
>familiar with the codebase could verify that this is correct.
>---
> asm/assemble.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
>diff --git a/asm/assemble.c b/asm/assemble.c
>index 9c76b0ea..31db516a 100644
>--- a/asm/assemble.c
>+++ b/asm/assemble.c
>@@ -2426,13 +2426,11 @@ static enum match_result matches(const struct
>itemplate *itemp,
>  * - offset can fit in a byte when EVEX is not used
>  * - offset can be compressed when EVEX is used
>  */
>-#define IS_MOD_01()     (input->eaflags & EAF_BYTEOFFS ||       \
>-                         (o >= -128 && o <= 127 &&              \
>-                          seg == NO_SEG && !forw_ref &&         \
>-                          !(input->eaflags & EAF_WORDOFFS) &&   \
>-                          !(ins->rex & REX_EV)) ||              \
>-                         (ins->rex & REX_EV &&                  \
>-                          is_disp8n(input, ins, &output->disp8)))
>+#define IS_MOD_01() (!(input->eaflags & EAF_WORDOFFS) &&              
>\
>+                    (ins->rex & REX_EV ? seg == NO_SEG && !forw_ref &&
>\
>+                     is_disp8n(input, ins, &output->disp8) :          
>\
>+                     input->eaflags & EAF_BYTEOFFS || (o >= -128 &&   
>\
>+                     o <= 127 && seg == NO_SEG && !forw_ref)))
> 
> static enum ea_type process_ea(operand *input, ea *output, int bits,
>                               int rfield, opflags_t rflags, insn *ins,

Oh, thank you!  I was just about to try to look at that.

Also, thank you so much for your testing, too.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[Nasm-devel] [PATCH] Fix ModR/M.mod for EVEX instructions

[Henrik G. <he...@gr...>]

It was incorrectly set to 01b in some cases when where it should be 10b.

Fixes BR 3392402.

Signed-off-by: Henrik Gramner <he...@gr...>
---
This fixes things for my use case, but it'd be great if someone more
familiar with the codebase could verify that this is correct.
---
 asm/assemble.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/asm/assemble.c b/asm/assemble.c
index 9c76b0ea..31db516a 100644
--- a/asm/assemble.c
+++ b/asm/assemble.c
@@ -2426,13 +2426,11 @@ static enum match_result matches(const struct itemplate *itemp,
  * - offset can fit in a byte when EVEX is not used
  * - offset can be compressed when EVEX is used
  */
-#define IS_MOD_01()     (input->eaflags & EAF_BYTEOFFS ||       \
-                         (o >= -128 && o <= 127 &&              \
-                          seg == NO_SEG && !forw_ref &&         \
-                          !(input->eaflags & EAF_WORDOFFS) &&   \
-                          !(ins->rex & REX_EV)) ||              \
-                         (ins->rex & REX_EV &&                  \
-                          is_disp8n(input, ins, &output->disp8)))
+#define IS_MOD_01() (!(input->eaflags & EAF_WORDOFFS) &&               \
+                    (ins->rex & REX_EV ? seg == NO_SEG && !forw_ref && \
+                     is_disp8n(input, ins, &output->disp8) :           \
+                     input->eaflags & EAF_BYTEOFFS || (o >= -128 &&    \
+                     o <= 127 && seg == NO_SEG && !forw_ref)))
 
 static enum ea_type process_ea(operand *input, ea *output, int bits,
                                int rfield, opflags_t rflags, insn *ins,
-- 
2.11.0

[Nasm-devel] debugging for Mach-O

[Mike B. <mik...@gm...>]

The release candidate for NASM is supposed to have debugging support for
Mach-O, but it doesn't seem to work for me. I tried both macho64 and macho.
It is very possible I'm using the wrong incantations; please let me know if
I'm supposed to be doing something differently.

 $ ~/Downloads/nasm-2.13rc20/nasm -f macho64 -g -F dwarf he.s
 $ ld -o he he.o
 $ ggdb he
GNU gdb (GDB) 7.12
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html
>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-apple-darwin15.6.0".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from he...(no debugging symbols found)...done.
(gdb)

[Nasm-devel] NASM 2.13rc20 - hopefully final, please help test

[H. P. A. <hp...@zy...>]

After quite a number of iterations, we now have a NASM release with
Mach-O DWARF support and a number of other enhancements.  This is what I
fully expect to be the final release minus any bug fixes.

Although this is quite a jump in version numbers from the previously
announced rc20, a lot of the intervening rc's have been rather small
changes, sometimes only in the build infrastructure and/or documentation.

2.13rc20, as well as git tree and nightly build, is available from
http://www.nasm.us/ as usual.

Any feedback, good or bad, appreciated.  For problems, the preferred
method is to file a bug report at http://bugzilla.nasm.us/ to make sure
it doesn't get lost or forgotten.

Many thanks,

	-hpa

Re: [Nasm-devel] On the future of the NASM documentation

[Cyrill G. <gor...@gm...>]

On Thu, Apr 13, 2017 at 05:05:50PM -0700, H. Peter Anvin wrote:
> 
> The NASM documentation is already written in a fairly TeX-like language,
> and I'm genuinely wondering how hard it would be to convert it to LaTeX,
> perhaps with extra macros.

I believe we could start generating transitional html/pdf as separate
document where we would cut off the parts from original documentation
into new one. Once everything is merged we could zap old files.
This will force us to re-read our own docs again probably fixing
typos and etc. Also we may try use asciidoc/sphinx or whatever.

Re: [Nasm-devel] On the future of the NASM documentation

[Ed B. <be...@mi...>]

On 04/14/2017 01:32 PM, H. Peter Anvin wrote:

> In the meantime I did some work to make both the PDF and HTML
> documentation look quite a bit nicer.
> 
> Opinions appreciated...

I wrote this back in 2001, almost exactly 16 years ago and still agree 
with myself.  :)  Interestingly, the tool that was called "Buttress" 
back then, and not finished, has long since been completed and renamed 
"halibut".  Could be an option?  I haven't looked at it in any detail.


> To: nas...@ya...
> From: Ed Beroset <be...@mi...>
> Subject: Re: [nasm-devel] RDSRC.PL of Netwide Assembler
> 
> At 15:11 3/19/01 -0500, you wrote:
> Robert Riebisch wrote:
> 
>>>> I am looking for someone who would be so kind to modify RDSRC.PL (from
>>>> the Netwide Assembler source code distribution archive) "a little
>>>> bit".
>>>
>>>You might want to look at what Simon has to say about rdsrc.pl:
>>>
>>>http://www.chiark.greenend.org.uk/~sgtatham/buttress.html
>>>
>> Unfortunately, Buttress seems to be just "vaporware", but Simon seems to
>> think rdsrc.pl is *not* the way to go. Perhaps someone *really* good at
>> Perl could do something with it.
> 
> I'm good with Perl, but I don't see the need for Yet Another Documentation Tool.  If somebody needs or wants the document in something other than the currently supported six different formats, does this really require a special NASM tool?  Why not use one of those six formats as input to some more general purpose tool?
> 
> If I were the king of the world, I'd turn the *source* document into XML and then simply use XSLT to transform into whatever other hundred formats were desired.  There are already tools for this kind of thing -- why reinvent the wheel? 
> 
>>Here is my "to do" list:
>>...
>>8. Read over the source, and create documentation that reflects what the
>>damn thing *actually* does...
> There's a relatively easy way to do that, which I would highly recommend:  
> http://www.stack.nl/~dimitri/doxygen/
> 
>> 9. World Peace? Naw, that would *really* be overkill..
> 
> Technically, that would be "underkill."  ;-)
> 
> Ed

Re: [Nasm-devel] Fixed out of directory builds

[Ed B. <be...@mi...>]

Oops!  Looks like I missed a few items.  I've attached another patch to 
address the remaining items.

Ed

Re: [Nasm-devel] On the future of the NASM documentation

[H. P. A. <hp...@zy...>]

On 04/13/17 17:27, Ed Beroset wrote:
> H. Peter Anvin wrote:
>> It is becoming pretty clear that maintaining our own typesetting
>> system for the documentation is getting increasingly ridiculous.
> 
> I've not been active here for some time, but would heartily agree with that.
> 
>> Obviously we would have to make sure that the output not just looks
>> right but has the proper metadata, which would mean using a stylized
>> LaTeX, but that's not a problem -- it would still give us
>> flexibility far beyond what we currently get.
> 
> Another possibility is markdown, although the processing might need to 
> be somewhat customized.  The advantage is that it puts very little 
> extraneous stuff into the human-edited input.
> 
> LaTeX has the advantage of a very long history and a plethora of tools.
> 

In the meantime I did some work to make both the PDF and HTML
documentation look quite a bit nicer.

Opinions appreciated...

	-hpa