nasm-devel — NASM development work

Re: [Nasm-devel] [nasm:master] BR3392253: Fix potential buffer overflow in number conversion

[Cyrill G. <gor...@op...>]

On Tue, May 07, 2013 at 01:08:30PM -0700, anonymous coward wrote:
> > -    char numbuf[20];
> > +    char numbuf[32];
> >      snprintf(numbuf, sizeof(numbuf), "%"PRId64"", val);
> 
> This should be 21, not 32.
> 
> # echo "l(2^63)/l(10)" | bc -l
> 18.96488972683081529852
> 
> So 1+19+1=21, to hold '-', the digits, and the '\0'.

32 here is to be 8 byte aligned for easier review on
object disasm level if needed. Is there some problem
I missed?

Re: [Nasm-devel] [nasm:master] BR3392253: Fix potential buffer overflow in number conversion

[anonymous c. <nas...@us...>]

> -    char numbuf[20];
> +    char numbuf[32];
>      snprintf(numbuf, sizeof(numbuf), "%"PRId64"", val);

This should be 21, not 32.

# echo "l(2^63)/l(10)" | bc -l
18.96488972683081529852

So 1+19+1=21, to hold '-', the digits, and the '\0'.

Re: [Nasm-devel] [PATCH] Make F2 and F3 SSE prefixes override 66

[H. P. A. <hp...@zy...>]

On 03/19/2013 06:51 PM, anonymous coward wrote:
>> What is XED?
> 
> x86 encoder decoder -- a software library
> 
> keywords: pin, Intel SDE, Mark Charney
> 

Gotcha.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: [Nasm-devel] [PATCH] Make F2 and F3 SSE prefixes override 66

[anonymous c. <nas...@us...>]

> What is XED?

x86 encoder decoder -- a software library

keywords: pin, Intel SDE, Mark Charney

Re: [Nasm-devel] [PATCH] Make F2 and F3 SSE prefixes override 66

[H. P. A. <hp...@zy...>]

On 03/03/2013 12:52 PM, Cyrill Gorcunov wrote:
> On Sun, Mar 03, 2013 at 12:40:51PM -0800, Ben Rudiak-Gould wrote:
>> According to XED and experimentation, the 66 is ignored.
> 
> Thanks, will try to take a look on the week.
> 

What is XED?

	-hpa

[Nasm-devel] [PATCH] Add IF_NO16 and IF_NO32 and remove IF_SZ and iwd

[Ben Rudiak-G. <ben...@gm...>]

This changes the disassembly of 68... in long mode from "push qword ..."
to "push ...". There should be no other behavior changes.

Re: [Nasm-devel] [PATCH] Make F2 and F3 SSE prefixes override 66

[Cyrill G. <gor...@op...>]

On Sun, Mar 03, 2013 at 12:40:51PM -0800, Ben Rudiak-Gould wrote:
> According to XED and experimentation, the 66 is ignored.

Thanks, will try to take a look on the week.

Re: [Nasm-devel] [PATCH] Remove SAME_AS

[Cyrill G. <gor...@op...>]

On Sun, Mar 03, 2013 at 12:09:48PM -0800, Ben Rudiak-Gould wrote:
> Here's this patch rebased and in format-patch format (but still as a
> gzipped attachment to avoid whatever munging gmail was doing).

Applied, thanks. (hpa@ CC'ed just to make sure he is fine with such change)

	Cyrill

[Nasm-devel] [PATCH] Make F2 and F3 SSE prefixes override 66

[Ben Rudiak-G. <ben...@gm...>]

According to XED and experimentation, the 66 is ignored.

Re: [Nasm-devel] [PATCH] Remove SAME_AS

[Ben Rudiak-G. <ben...@gm...>]

Here's this patch rebased and in format-patch format (but still as a
gzipped attachment to avoid whatever munging gmail was doing).

Re: [Nasm-devel] [PATCH] Remove pushseg/popseg

[Cyrill G. <gor...@op...>]

On Sat, Feb 23, 2013 at 11:20:54PM -0800, Ben Rudiak-Gould wrote:
> It doesn't remove the x86 instructions, just the internal
> pushseg(2)/popseg(2) bytecodes. There should be no visible effect on
> assembly or disassembly.

Applied, thanks!

	Cyrill

Re: [Nasm-devel] [PATCH] Remove +s

[Cyrill G. <gor...@op...>]

On Tue, Feb 26, 2013 at 08:40:29PM -0800, Ben Rudiak-Gould wrote:
> Here's a revised patch that fixes the warnings. It now warns in all
> the same places as before the patch, but some messages are changed, I
> think for the better (e.g. add ax,0FFFFFFFFh now complains about an
> out-of-range word instead of an out-of-range signed byte).
> 
> In the description delete the last sentence ("The assembler warns in a
> few cases it didn't before...")
> 
> Signed-off-by: Ben Rudiak-Gould <benrudiak_at_gmail.com>

Thanks Ben, applied! Could you please next time attach a complete
patch generated by "git format-patch"? Not just diff gzipp'ed.

Re: [Nasm-devel] [PATCH] Remove +s

[Cyrill G. <gor...@op...>]

On Wed, Feb 27, 2013 at 02:26:22PM -0800, H. Peter Anvin wrote:
> On 02/26/2013 08:40 PM, Ben Rudiak-Gould wrote:
> > Here's a revised patch that fixes the warnings. It now warns in all
> > the same places as before the patch, but some messages are changed, I
> > think for the better (e.g. add ax,0FFFFFFFFh now complains about an
> > out-of-range word instead of an out-of-range signed byte).
> > 
> > In the description delete the last sentence ("The assembler warns in a
> > few cases it didn't before...")
> > 
> > Signed-off-by: Ben Rudiak-Gould <benrudiak_at_gmail.com>
> > 
> 
> Looks much better!

Thanks for review, Peter! I'll grab it tomorrow (if you've not yet
picked it up)

/me still out of time

Re: [Nasm-devel] [PATCH] Remove +s

[H. P. A. <hp...@zy...>]

On 02/26/2013 08:40 PM, Ben Rudiak-Gould wrote:
> Here's a revised patch that fixes the warnings. It now warns in all
> the same places as before the patch, but some messages are changed, I
> think for the better (e.g. add ax,0FFFFFFFFh now complains about an
> out-of-range word instead of an out-of-range signed byte).
> 
> In the description delete the last sentence ("The assembler warns in a
> few cases it didn't before...")
> 
> Signed-off-by: Ben Rudiak-Gould <benrudiak_at_gmail.com>
> 

Looks much better!

	-hpa

[Nasm-devel] [PATCH] Remove SAME_AS

[Ben Rudiak-G. <ben...@gm...>]

It was there to support the SSE5 DREX encoding, which as far as I know
is dead forever.

Signed-off-by: Ben Rudiak-Gould <benrudiak_at_gmail.com>

Re: [Nasm-devel] [PATCH] Remove +s

[Ben Rudiak-G. <ben...@gm...>]

Here's a revised patch that fixes the warnings. It now warns in all
the same places as before the patch, but some messages are changed, I
think for the better (e.g. add ax,0FFFFFFFFh now complains about an
out-of-range word instead of an out-of-range signed byte).

In the description delete the last sentence ("The assembler warns in a
few cases it didn't before...")

Signed-off-by: Ben Rudiak-Gould <benrudiak_at_gmail.com>

Re: [Nasm-devel] [PATCH] Remove +s

[H. P. A. <hp...@zy...>]

> --- a/test/immwarn.asm
> +++ b/test/immwarn.asm
> @@ -14,15 +14,17 @@
>  %endif
>         push -1
>         push 0ffffh
> +%if WARN
>         push byte 0FFFFh
> +%endif
>
>         add ax,0FFFFh
>  %if WARN
>         add ax,0FFFFFFFFh
>  %endif
>         add ax,-1
> -       add ax,byte 0FFFFh
>  %if WARN
> +       add ax,byte 0FFFFh
>         add ax,byte 0FFFFFFFFh
>  %endif
>         add ax,-1
> @@ -32,8 +34,8 @@
>         add cx,0FFFFFFFFh
>  %endif
>         add cx,-1
> -       add cx,byte 0FFFFh
>  %if WARN
> +       add cx,byte 0FFFFh
>         add cx,byte 0FFFFFFFFh
>  %endif
>         add cx,-1

These changes are wrong.


	push byte 0FFFFh

... in 16-bit mode is okay, since only 16 bits are pushed on the stack 
using the sbyte form there is correct.  It is not okay in 32- or 64-bit 
mode, neither is "push byte 0FFFFFFFFh" okay in 64-bit mode, but it is 
in 32-bit mode.

Similarly, "add <rm16>,byte 0FFFFh" is perfectly fine, since the sbyte 
form will correctly expand to 0FFFFh.

	-hpa

Re: [Nasm-devel] [PATCH] Fix warnings generated by clang 3.0

[Cyrill G. <gor...@op...>]

On Sun, Feb 24, 2013 at 11:08:40PM +0400, Andrew Nayenko wrote:
> Fix warnings like this:
> 

Applied, thanks.

[Nasm-devel] [PATCH] Fix warnings generated by clang 3.0

[Andrew N. <re...@gm...>]

Fix warnings like this:

output/outelf32.c:2120:33: warning: equality comparison with extraneous
      parentheses [-Wparentheses-equality]
            if ((match->section == index)) {
                 ~~~~~~~~~~~~~~~^~~~~~~~
output/outelf32.c:2120:33: note: remove extraneous parentheses around the
      comparison to silence this warning
            if ((match->section == index)) {
                ~               ^       ~
output/outelf32.c:2120:33: note: use '=' to turn this equality comparison into
      an assignment
            if ((match->section == index)) {
                                ^~
                                =
1 warning generated.

Signed-off-by: Andrew Nayenko <re...@gm...>

diff --git a/output/outelf32.c b/output/outelf32.c
index 00b3f5e..48f9177 100644
--- a/output/outelf32.c
+++ b/output/outelf32.c
@@ -2117,7 +2117,7 @@ static void dwarf32_findsect(const int index)
     if (dwarf_fsect) {
         match = dwarf_fsect;
         for (sinx = 0; sinx < dwarf_nsections; sinx++) {
-            if ((match->section == index)) {
+            if (match->section == index) {
                 dwarf_csect = match;
                 return;
             }
diff --git a/output/outelf64.c b/output/outelf64.c
index 9776972..8175aed 100644
--- a/output/outelf64.c
+++ b/output/outelf64.c
@@ -2204,7 +2204,7 @@ static void dwarf64_findsect(const int index)
     if (dwarf_fsect) {
         match = dwarf_fsect;
         for (sinx = 0; sinx < dwarf_nsections; sinx++) {
-            if ((match->section == index)) {
+            if (match->section == index) {
                 dwarf_csect = match;
                 return;
             }
diff --git a/output/outelfx32.c b/output/outelfx32.c
index 914a83e..57bbf75 100644
--- a/output/outelfx32.c
+++ b/output/outelfx32.c
@@ -2159,7 +2159,7 @@ static void dwarfx32_findsect(const int index)
     if (dwarf_fsect) {
         match = dwarf_fsect;
         for (sinx = 0; sinx < dwarf_nsections; sinx++) {
-            if ((match->section == index)) {
+            if (match->section == index) {
                 dwarf_csect = match;
                 return;
             }
-- 
 Andrew Nayenko <re...@gm...>

Re: [Nasm-devel] [PATCH] Remove pushseg/popseg

[Ben Rudiak-G. <ben...@gm...>]

It doesn't remove the x86 instructions, just the internal
pushseg(2)/popseg(2) bytecodes. There should be no visible effect on
assembly or disassembly.

-- Ben


On Sat, Feb 23, 2013 at 2:28 PM, Debbie Wiles <deb...@ho...> wrote:
> Why remove legitimate instructions that are needed for some programs?
>
> From: ben...@gm...
> Date: Sat, 23 Feb 2013 13:39:26 -0800
> To: nas...@li...
> Subject: [Nasm-devel] [PATCH] Remove pushseg/popseg
>
>
> Pretty simple.
>
> Signed-off-by: Ben Rudiak-Gould <benrudiak_at_gmail.com>

Re: [Nasm-devel] [PATCH] Remove pushseg/popseg

[Debbie W. <deb...@ho...>]

Why remove legitimate instructions that are needed for some programs?

From: ben...@gm...
Date: Sat, 23 Feb 2013 13:39:26 -0800
To: nas...@li...
Subject: [Nasm-devel] [PATCH] Remove pushseg/popseg

Pretty simple.
 
Signed-off-by: Ben Rudiak-Gould <benrudiak_at_gmail.com>

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
Nasm-devel mailing list
Nas...@li...
https://lists.sourceforge.net/lists/listinfo/nasm-devel 		 	   		  

[Nasm-devel] [PATCH] Remove pushseg/popseg

[Ben Rudiak-G. <ben...@gm...>]

Pretty simple.

Signed-off-by: Ben Rudiak-Gould <benrudiak_at_gmail.com>

Re: [Nasm-devel] [PATCH] Remove +s

[Cyrill G. <gor...@op...>]

On Sat, Feb 23, 2013 at 10:14:37AM -0800, Ben Rudiak-Gould wrote:
> It doesn't seem worth >200 lines of C and Perl to save ~50 lines in insns.dat.
> 
> In order to make this work I had to rename sbyte16/sbyte32 so that
> they can take an ordinary size suffix (their size suffix was formerly
> treated specially).
> 
> This fixes one disassembly bug: 48C7C000000080 disassembles to mov
> rax,0x80000000, which reassembles to B800000080, which loads a
> different value. The assembler warns in a few cases it didn't before,
> such as push byte 0xFFFF.
> 
> Signed-off-by: Ben Rudiak-Gould <benrudiak_at_gmail.com>

Thanks Ben, i'll take a look once time permits.

[Nasm-devel] [PATCH] Remove +s

[Ben Rudiak-G. <ben...@gm...>]

It doesn't seem worth >200 lines of C and Perl to save ~50 lines in insns.dat.

In order to make this work I had to rename sbyte16/sbyte32 so that
they can take an ordinary size suffix (their size suffix was formerly
treated specially).

This fixes one disassembly bug: 48C7C000000080 disassembles to mov
rax,0x80000000, which reassembles to B800000080, which loads a
different value. The assembler warns in a few cases it didn't before,
such as push byte 0xFFFF.

Signed-off-by: Ben Rudiak-Gould <benrudiak_at_gmail.com>

Re: [Nasm-devel] [PATCH] Fix jmp/call near offsets in long mode

[Cyrill G. <gor...@op...>]

On Wed, Feb 20, 2013 at 11:10:57AM -0800, Ben Rudiak-Gould wrote:
>
> Here are both patches as text/plain attachments. I think it may have
> been gmail on my end that screwed them up.

OK, thanks!