[Nasm-devel] Question for a patch: How to handle a warning class that is a superset of another warning class?

[C. M. <pu...@38...>]

Hello,

I want to provide a patch to add a warning label-missing-colon, which
should trigger for every occurrence of a label without a colon (except
when the label is defined using equ).

That got me thinking, how should this be handled when interacting with
orphan-labels? If orphan-labels is off, then I would apply
label-missing-colon to every label, whether error-and-on,
no-error-and-on, or off. Likewise, if label-missing-colon is off,
applying orphan-labels is straightforward. (However, even that may
require asking whether the one or the other is an enabled warning.)

However, when both are on, the question is how to handle that?

* Show both warnings?

* Show only orphan-labels, since it's more specific?

What if both are on and their error statuses differ? Especially the case
of +error=label-missing-colon and -error=orphan-labels comes to mind. If
we only show the more specific one and do *not* treat it as an error,
then the demand to error for the more general one is not honoured.

What do you think? Would such a patch be welcome? How should I handle this?

Regards,
ecm