[Nasm-devel] clang patches

[Daniel L. <da...@ma...>]

Hi,

With this patch, it almost builds with -Werror. Just the below left:

nasmlib/file.c:193:9: warning: variable 'f' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
    if (again)
        ^~~~~
nasmlib/file.c:196:10: note: uninitialized use occurs here
    if (!f && (flags & NF_FATAL))
         ^
nasmlib/file.c:193:5: note: remove the 'if' if its condition is always true
    if (again)
    ^~~~~~~~~~
nasmlib/file.c:179:12: note: initialize the variable 'f' to silence this warning
    FILE *f;
           ^
            = NULL
1 warning generated.

Unfortunately clang does not realise that 'again' will never be false for non-glibc. How do you want that fixed? Is it OK to just initialise f to NULL or do you prefer something else?