Re: [Nasm-devel] [PATCH 3/4] macros: standard.mac needs to be first arg to macros.pl

[H. P. A. <hp...@zy...>]

On 07/18/16 04:55, Cyrill Gorcunov wrote:
> On Wed, Jul 13, 2016 at 05:22:00PM -0700, Fabian Giesen wrote:
>> The sequence of files passed to macros.pl needs to be, in that order:
>> 1. standard.mac
>> 2. version.mac
>> 3. <other macro files>
>>
>> If standard.mac isn't first, the "tasm_compatible_mode" logic in
>> preproc.c (nasm_stdmac / nasm_stdmac_after_tasm) breaks badly.
>>
>> That means standard.mac is special and "macros/*.mac" doesn't work
>> right (it depends on file name enumeration order); making the file
>> name special seems like the cleanest way to accomplish that.
>>
>> Signed-off-by: Fabian Giesen <fa...@ra...>
> 
>  | ./macros/macros.pl: ./macros/_standard.mac: macro declarations outside a known block
>  | Makefile:189: recipe for target 'macros/macros.c' failed
>  | make: *** [macros/macros.c] Error 25
> 
> Are you sure the patch is correct?
> 

I think this is in conflict with a patch I already checked in which
fixes the problem in a different way.

	-hpa