Re: [Nasm-devel] [PATCH 00/18] Preliminary work on Elf unification

[H. P. A. <hp...@zy...>]

On 04/07/16 15:16, Cyrill Gorcunov wrote:
> Not everything yet covered but just to share for easier review.
> It's sitting in https://github.com/cyrillos/nasm/tree/uelf
>
> The series is on top of 89c1770e14c8ca3fa478ddf3106f76835fc0704f
>
> Cyrill Gorcunov (18):
>    out: Elfx32, Elf32 -- Unify elf_add_reloc
>    out: Elf32 -- Add missing comment
>    out: Elf32, Elfx32, Elf64 -- Use ofmt->maxbits
>    out: Elf64, Elf32, Elfx32 -- Style merge
>    out: Elf32 -- Unify struct symlininfo
>    out: Elf32 -- Reuse TY_DEBUGSYMLIN
>    out: Elf32, Elfx32 -- Unify struct ELF_SECTDATA and @elf_foffs
>    out: Elf64, Elfx32 -- Style fix
>    out: Elf32, Elfx32 -- Unify elf_sect_write, elf_section_header and add
>      elf_sect_writeaddr
>    out: Elf32, Elfx32, Elf64 -- more unifications
>    out: Elf32 -- Unify dwarf_ nums
>    out: Elf32, Elfx32, Elf64 -- Unify elf_init and elf_deflabel
>    out: Elf64, Elfx32 -- Drop useless DEBUG
>    output: Elf32, Elfx32, Elf64 -- Declare ofmt for all
>    out: Elf32 -- A few more constants usage
>    output: Elf32, Elfx32 -- Unify elf_add_gsym_reloc
>    output: Elf32 -- Shuffle few lines to make it close to other code
>    output: Elf32, Elfx32 -- Use 64 bit address
>

Looks really good to me.

	-hpa