Re: [Nasm-devel] [PATCH] msvc.mak: Build fixes, updates and improvements.

[H. P. A. <hp...@zy...>]

On 04/17/16 11:21, Cyrill Gorcunov wrote:
> On Thu, Apr 14, 2016 at 11:58:46PM +0200, Knut St. Osmundsen wrote:
>> Hi!
>>
>> Since I had to fix the broken mkfiles/msvc.mak to fix and build me a new
>> nasm here, I thought I share the patch.
>>
>> msvc.mak: Build fixes, updates and improvements.
>> * Added missing rules for creating a library out of LIBOBJ and using it
>> when linking.
>> * Updated the clean rule and PRELREQ list.
>> * Always build with debug info as it ends up in external PDB files
>> anyway and doesn't really impact binary size.
>> * Added /RELEASE to the LDFLAGS so the linker checksums the headers and
>> the binary can be signed.
>>
>> .gitignore: Ignore above libraries, debuginfo.
>>
>>
>> Kind Regards,
>>    bird.
>>
>> Signed-off-by: Knut St. Osmundsen <bir...@an...>
>
> Hi Knut! Thanks a huge for the patch! (And sorry for delay
> in response). The patch istself looks ok to me, but I'm not
> msvc nmake expert. I tend to merge it, but would love
> to hear Peter's opinion first (CC'ed).
>

Looks good to me!

	-hpa